Home » Mailing list archives » linux-kernel » 2007 » September » 27

[PATCH] fs: Correct SuS compliance for open of large file without options

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Alan Cox <alan@...>
To: <akpm@...>, <linux-kernel@...>, <linux-fsdevel@...>
Subject: [PATCH] fs: Correct SuS compliance for open of large file without options
Date: Thursday, September 27, 2007 - 9:29 am

The early LFS work that Linux uses favours EFBIG in various places. SuSv3
specifically uses EOVERFLOW for this as noted by Michael (Bug 7253)

--

[EOVERFLOW]
    The named file is a regular file and the size of the file cannot be
represented correctly in an object of type off_t. We should therefore
transition to the proper error return code

Signed-off-by: Alan Cox <alan@redhat.com>

diff -u --new-file --exclude-from /usr/src/exclude --recursive linux.vanilla-2.6.23rc8-mm1/fs/gfs2/ops_file.c linux-2.6.23rc8-mm1/fs/gfs2/ops_file.c
--- linux.vanilla-2.6.23rc8-mm1/fs/gfs2/ops_file.c	2007-09-26 16:46:54.000000000 +0100
+++ linux-2.6.23rc8-mm1/fs/gfs2/ops_file.c	2007-09-27 13:45:48.000000000 +0100
@@ -406,7 +406,7 @@
 
 		if (!(file->f_flags & O_LARGEFILE) &&
 		    ip->i_di.di_size > MAX_NON_LFS) {
-			error = -EFBIG;
+			error = -EOVERFLOW;
 			goto fail_gunlock;
 		}
 
diff -u --new-file --exclude-from /usr/src/exclude --recursive linux.vanilla-2.6.23rc8-mm1/fs/ntfs/file.c linux-2.6.23rc8-mm1/fs/ntfs/file.c
--- linux.vanilla-2.6.23rc8-mm1/fs/ntfs/file.c	2007-09-26 16:46:55.000000000 +0100
+++ linux-2.6.23rc8-mm1/fs/ntfs/file.c	2007-09-27 13:47:35.000000000 +0100
@@ -61,7 +61,7 @@
 {
 	if (sizeof(unsigned long) < 8) {
 		if (i_size_read(vi) > MAX_LFS_FILESIZE)
-			return -EFBIG;
+			return -EOVERFLOW;
 	}
 	return generic_file_open(vi, filp);
 }
diff -u --new-file --exclude-from /usr/src/exclude --recursive linux.vanilla-2.6.23rc8-mm1/fs/open.c linux-2.6.23rc8-mm1/fs/open.c
--- linux.vanilla-2.6.23rc8-mm1/fs/open.c	2007-09-26 16:46:55.000000000 +0100
+++ linux-2.6.23rc8-mm1/fs/open.c	2007-09-27 13:45:10.000000000 +0100
@@ -1210,7 +1210,7 @@
 int generic_file_open(struct inode * inode, struct file * filp)
 {
 	if (!(filp->f_flags & O_LARGEFILE) && i_size_read(inode) > MAX_NON_LFS)
-		return -EFBIG;
+		return -EOVERFLOW;
 	return 0;
 }
 

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] fs: Correct SuS compliance for open of large file wi..., Alan Cox, (Thu Sep 27, 9:29 am)
Re: [PATCH] fs: Correct SuS compliance for open of large fil..., Arjan van de Ven, (Thu Sep 27, 10:01 am)
Re: [PATCH] fs: Correct SuS compliance for open of large fil..., Alan Cox, (Thu Sep 27, 10:19 am)
Re: [PATCH] fs: Correct SuS compliance for open of large fil..., Jens Axboe, (Thu Sep 27, 10:35 am)
Re: [PATCH] fs: Correct SuS compliance for open of large fil..., Alan Cox, (Thu Sep 27, 10:44 am)
Re: [PATCH] fs: Correct SuS compliance for open of large fil..., Jens Axboe, (Thu Sep 27, 11:08 am)
Re: [PATCH] fs: Correct SuS compliance for open of large fil..., Alan Cox, (Thu Sep 27, 11:19 am)
Re: [PATCH] fs: Correct SuS compliance for open of large fil..., Theodore Tso, (Thu Sep 27, 11:59 am)
Re: [PATCH] fs: Correct SuS compliance for open of large fil..., Jens Axboe, (Thu Sep 27, 7:41 pm)
Re: [PATCH] fs: Correct SuS compliance for open of large fil..., Andrew Morton, (Thu Sep 27, 1:23 pm)
Re: [PATCH] fs: Correct SuS compliance for open of large fil..., Greg KH, (Thu Sep 27, 1:59 pm)
Re: [PATCH] fs: Correct SuS compliance for open of large fil..., Theodore Tso, (Thu Sep 27, 2:37 pm)
Re: [PATCH] fs: Correct SuS compliance for open of large fil..., Greg KH, (Thu Sep 27, 5:34 pm)
Re: [PATCH] fs: Correct SuS compliance for open of large fil..., Theodore Tso, (Thu Sep 27, 7:19 pm)
Re: [PATCH] fs: Correct SuS compliance for open of large fil..., Greg KH, (Thu Sep 27, 11:21 pm)
Re: [PATCH] fs: Correct SuS compliance for open of large fil..., Matthew Wilcox, (Thu Sep 27, 7:28 pm)
Re: [PATCH] fs: Correct SuS compliance for open of large fil..., Greg KH, (Thu Sep 27, 11:22 pm)
Re: [PATCH] fs: Correct SuS compliance for open of large fil..., Theodore Tso, (Thu Sep 27, 10:21 pm)
Re: [PATCH] fs: Correct SuS compliance for open of large fil..., Kyle Moffett, (Thu Sep 27, 6:27 pm)
Re: [PATCH] fs: Correct SuS compliance for open of large fil..., Greg KH, (Thu Sep 27, 7:11 pm)
Re: [PATCH] fs: Correct SuS compliance for open of large fil..., Matthew Wilcox, (Thu Sep 27, 2:45 pm)