Home » Mailing list archives » linux-kernel » 2007 » September » 27

[PATCH] Compile handle_percpu_irq even for uniprocessor kernels

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Ralf Baechle <ralf@...>
To: Andrew Morton <akpm@...>, Thomas Gleixner <tglx@...>, Molnar Ingo <mingo@...>, <benh@...>
Cc: <linux-kernel@...>, <linux-mips@...>
Subject: [PATCH] Compile handle_percpu_irq even for uniprocessor kernels
Date: Thursday, September 27, 2007 - 7:24 am

Compiling handle_percpu_irq only on uniprocessor generates an artificial
special case so a typical use like:

  set_irq_chip_and_handler(irq, &some_irq_type, handle_percpu_irq);

needs to be conditionally compiled only on SMP systems as well and an
alternative UP construct is usually needed - for no good reason.

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

---
This fixes uniprocessor configurations for some MIPS SMP systems.

diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index f1a73f0..9b5dff6 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -503,7 +503,6 @@ out_unlock:
 	spin_unlock(&desc->lock);
 }
 
-#ifdef CONFIG_SMP
 /**
  *	handle_percpu_IRQ - Per CPU local irq handler
  *	@irq:	the interrupt number
@@ -529,8 +528,6 @@ handle_percpu_irq(unsigned int irq, struct irq_desc *desc)
 		desc->chip->eoi(irq);
 }
 
-#endif /* CONFIG_SMP */
-
 void
 __set_irq_handler(unsigned int irq, irq_flow_handler_t handle, int is_chained,
 		  const char *name)
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] Compile handle_percpu_irq even for uniprocessor kern..., Ralf Baechle, (Thu Sep 27, 7:24 am)
Re: [PATCH] Compile handle_percpu_irq even for uniprocessor ..., Thomas Gleixner, (Thu Sep 27, 7:28 am)