Re: [PATCH]PCI:disable resource decode in PCI BAR detection

Previous thread: [RFC] QoS power Management enabling patch set by Mark Gross on Wednesday, September 26, 2007 - 6:37 pm. (23 messages)

Next thread: 2.6.23-rc8: Known regressions from 2.6.22 by Rafael J. Wysocki on Wednesday, September 26, 2007 - 7:27 pm. (7 messages)
To: Benjamin Herrenschmidt <benh@...>
Cc: Ivan Kokshaysky <ink@...>, Greg KH <gregkh@...>, Matthew Wilcox <matthew@...>, Shaohua Li <shaohua.li@...>, lkml <linux-kernel@...>, linux-pci <linux-pci@...>, Andrew Morton <akpm@...>
Date: Wednesday, September 26, 2007 - 7:01 pm

How is this a change in behavior as far as this device is concerned? If
we are doing BAR sizing and moving the base address around, it's going
to cause problems if you try to access the device during this time
whether we disable decode or not.

--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from hancockr@nospamshaw.ca
Home Page: http://www.roberthancock.com/

-

To: Robert Hancock <hancockr@...>
Cc: Ivan Kokshaysky <ink@...>, Greg KH <gregkh@...>, Matthew Wilcox <matthew@...>, Shaohua Li <shaohua.li@...>, lkml <linux-kernel@...>, linux-pci <linux-pci@...>, Andrew Morton <akpm@...>
Date: Wednesday, September 26, 2007 - 8:40 pm

True. The window is smaller tho if the upper bridge decode hasn't been
disabled. I suppose I'll have to find a way to "pin" those devices and
generate the BAR info from the firmware data.

Ben.

-

To: Benjamin Herrenschmidt <benh@...>
Cc: Robert Hancock <hancockr@...>, Ivan Kokshaysky <ink@...>, Greg KH <gregkh@...>, Shaohua Li <shaohua.li@...>, lkml <linux-kernel@...>, linux-pci <linux-pci@...>, Andrew Morton <akpm@...>
Date: Wednesday, September 26, 2007 - 10:14 pm

The upper bridge decode only gets disabled while we size the upper
bridge's BARs. Then we reenable it.

--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
-

Previous thread: [RFC] QoS power Management enabling patch set by Mark Gross on Wednesday, September 26, 2007 - 6:37 pm. (23 messages)

Next thread: 2.6.23-rc8: Known regressions from 2.6.22 by Rafael J. Wysocki on Wednesday, September 26, 2007 - 7:27 pm. (7 messages)