Home » Mailing list archives » linux-kernel » 2007 » September » 26

[PATCH] usb serial: Kill another case we pass NULL and shouldn't

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Alan Cox <alan@...>
To: <greg@...>, <akpm@...>, <linux-kernel@...>
Subject: [PATCH] usb serial: Kill another case we pass NULL and shouldn't
Date: Wednesday, September 26, 2007 - 6:12 pm

Signed-off-by: Alan Cox <alan@redhat.com>

diff -u --new-file --exclude-from /usr/src/exclude --recursive linux.vanilla-2.6.23rc8-mm1/drivers/usb/serial/console.c linux-2.6.23rc8-mm1/drivers/usb/serial/console.c
--- linux.vanilla-2.6.23rc8-mm1/drivers/usb/serial/console.c	2007-09-26 16:41:47.000000000 +0100
+++ linux-2.6.23rc8-mm1/drivers/usb/serial/console.c	2007-09-18 16:30:08.000000000 +0100
@@ -164,6 +164,7 @@
 	}
 
 	if (serial->type->set_termios) {
+		struct ktermios dummy;
 		/* build up a fake tty structure so that the open call has something
 		 * to look at to get the cflag value */
 		tty = kzalloc(sizeof(*tty), GFP_KERNEL);
@@ -177,12 +178,13 @@
 			kfree (tty);
 			return -ENOMEM;
 		}
+		memset(&dummy, 0, sizeof(struct ktermios));
 		termios->c_cflag = cflag;
 		tty->termios = termios;
 		port->tty = tty;
 
 		/* set up the initial termios settings */
-		serial->type->set_termios(port, NULL);
+		serial->type->set_termios(port, &dummy);
 		port->tty = NULL;
 		kfree (termios);
 		kfree (tty);
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] usb serial: Kill another case we pass NULL and shoul..., Alan Cox, (Wed Sep 26, 6:12 pm)