Home » Mailing list archives » linux-kernel » 2007 » September » 26

[PATCH] usb_serial: Stop passing NULL to functions that expect data

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Alan Cox <alan@...>
To: <akpm@...>, <linux-kernel@...>, <greg@...>
Subject: [PATCH] usb_serial: Stop passing NULL to functions that expect data
Date: Wednesday, September 26, 2007 - 6:08 pm

Earlier patches have removed the checking for old v new differences from
the USB drivers so we can now pass in a valid blank old termios so that
we don't to fill the drivers with magic hacks for console support

Signed-off-by: Alan Cox <alan@redhat.com>

diff -u --new-file --exclude-from /usr/src/exclude --recursive linux.vanilla-2.6.23rc8-mm1/drivers/serial/serial_core.c linux-2.6.23rc8-mm1/drivers/serial/serial_core.c
--- linux.vanilla-2.6.23rc8-mm1/drivers/serial/serial_core.c	2007-09-26 16:46:54.000000000 +0100
+++ linux-2.6.23rc8-mm1/drivers/serial/serial_core.c	2007-09-18 16:28:20.000000000 +0100
@@ -1885,6 +1885,7 @@
 		 int baud, int parity, int bits, int flow)
 {
 	struct ktermios termios;
+	static struct ktermios dummy;
 	int i;
 
 	/*
@@ -1930,7 +1931,7 @@
 	 */
 	port->mctrl |= TIOCM_DTR;
 
-	port->ops->set_termios(port, &termios, NULL);
+	port->ops->set_termios(port, &termios, &dummy);
 	co->cflag = termios.c_cflag;
 
 	return 0;
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] usb_serial: Stop passing NULL to functions that expe..., Alan Cox, (Wed Sep 26, 6:08 pm)
Re: [PATCH] usb_serial: Stop passing NULL to functions that ..., Andrew Morton, (Wed Sep 26, 6:52 pm)
Re: [PATCH] usb_serial: Stop passing NULL to functions that ..., Alan Cox, (Wed Sep 26, 7:01 pm)