login
Header Space

 
 

[PATCH 8/8] taskstats: avoid breaking binary compatibility between taskstats v6 and before

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andrew Morton <akpm@...>, Linux Kernel Mailing List <linux-kernel@...>
Cc: Guillaume Chazarain <guichaz@...>, Michael Neuling <mikey@...>, Balbir Singh <balbir@...>, Jay Lan <jlan@...>, Jonathan Lim <jlim@...>, Oleg Nesterov <oleg@...>
Date: Wednesday, September 26, 2007 - 1:08 pm

Place fields added in v6 at the end of the struct.

Signed-off-by: Guillaume Chazarain <guichaz@yahoo.fr>
Cc: Michael Neuling <mikey@neuling.org>
Cc: Balbir Singh <balbir@in.ibm.com>
Cc: Jay Lan <jlan@engr.sgi.com>
Cc: Jonathan Lim <jlim@sgi.com>
Cc: Oleg Nesterov <oleg@tv-sign.ru>
---

 include/linux/taskstats.h |   18 +++++++++++-------
 1 files changed, 11 insertions(+), 7 deletions(-)


diff --git a/include/linux/taskstats.h b/include/linux/taskstats.h
index 92bfd1c..dc6850c 100644
--- a/include/linux/taskstats.h
+++ b/include/linux/taskstats.h
@@ -85,12 +85,9 @@ struct taskstats {
 	 * On some architectures, value will adjust for cpu time stolen
 	 * from the kernel in involuntary waits due to virtualization.
 	 * Value is cumulative, in nanoseconds, without a corresponding count
-	 * and wraps around to zero silently on overflow.  The
-	 * _scaled_ version accounts for cpus which can scale the
-	 * number of instructions executed each cycle.
+	 * and wraps around to zero silently on overflow.
 	 */
 	__u64	cpu_run_real_total;
-	__u64	cpu_scaled_run_real_total;
 
 	/* cpu "virtual" running time
 	 * Uses time intervals seen by the kernel i.e. no adjustment
@@ -146,9 +143,6 @@ struct taskstats {
 	__u64	read_syscalls;		/* read syscalls */
 	__u64	write_syscalls;		/* write syscalls */
 
-	/* time accounting for SMT machines */
-	__u64	ac_utimescaled;		/* utime scaled on frequency etc */
-	__u64	ac_stimescaled;		/* stime scaled on frequency etc */
 	/* Extended accounting fields end */
 
 #define TASKSTATS_HAS_IO_ACCOUNTING
@@ -159,6 +153,16 @@ struct taskstats {
 
 	__u64  nvcsw;			/* voluntary_ctxt_switches */
 	__u64  nivcsw;			/* nonvoluntary_ctxt_switches */
+
+	/*
+	 * Same as cpu_run_real_total but accounts for cpus which can scale the
+	 * number of instructions executed each cycle.
+	 */
+	__u64	cpu_scaled_run_real_total;
+
+	/* time accounting for SMT machines */
+	__u64	ac_utimescaled;		/* utime scaled on frequency etc */
+	__u64	ac_stimescaled;		/* stime scaled on frequency etc */
 };
 
 
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 1/8] taskstats: fix indentation of long argument lists, Guillaume Chazarain, (Wed Sep 26, 1:08 pm)
Re: [PATCH 1/8] taskstats: fix indentation of long argument ..., Guillaume Chazarain, (Thu Sep 27, 4:39 am)
Re: [PATCH 1/8] taskstats: fix indentation of long argument ..., Guillaume Chazarain, (Wed Sep 26, 1:12 pm)
[PATCH 8/8] taskstats: avoid breaking binary compatibility b..., Guillaume Chazarain, (Wed Sep 26, 1:08 pm)
[PATCH 7/8] taskstats: fix stats-&gt;ac_exitcode to work on ..., Guillaume Chazarain, (Wed Sep 26, 1:08 pm)
[PATCH 6/8] taskstats: tell fill_threadgroup_stats() if it r..., Guillaume Chazarain, (Wed Sep 26, 1:08 pm)
[PATCH 4/8] taskstats: separate PID/TGID stats producers to ..., Guillaume Chazarain, (Wed Sep 26, 1:08 pm)
[PATCH 5/8] taskstats: factor out version and context switch..., Guillaume Chazarain, (Wed Sep 26, 1:08 pm)
[PATCH 3/8] taskstats: split the extended accounting fields, Guillaume Chazarain, (Wed Sep 26, 1:08 pm)
[PATCH 2/8] taskstats: split the basic accounting fields, Guillaume Chazarain, (Wed Sep 26, 1:08 pm)
speck-geostationary