Home » Mailing list archives » linux-kernel » 2007 » September » 26

Re: [PATCH] ahci: enable GHC.AE bit before set GHC.HR

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Alan Cox <alan@...>
To: Jeff Garzik <jeff@...>
Cc: Peer Chen <peerchen@...>, linux-kernel <linux-kernel@...>, akpm <akpm@...>, linux-ide <linux-ide@...>
Subject: Re: [PATCH] ahci: enable GHC.AE bit before set GHC.HR
Date: Wednesday, September 26, 2007 - 10:30 am

> > NAK - mmio is an iomap so writel and readl are the wrong things to use

You could just flip the relevant function to use ioread while you are
tidying it up, instead of spreading new bugs into the code.

Alan
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] ahci: enable GHC.AE bit before set GHC.HR, Peer Chen, (Fri Sep 21, 1:28 am)
Re: [PATCH] ahci: enable GHC.AE bit before set GHC.HR, Jeff Garzik, (Wed Sep 26, 12:03 am)
Re: [PATCH] ahci: enable GHC.AE bit before set GHC.HR, Alan Cox, (Wed Sep 26, 7:23 am)
Re: [PATCH] ahci: enable GHC.AE bit before set GHC.HR, Jeff Garzik, (Wed Sep 26, 7:41 am)
Re: [PATCH] ahci: enable GHC.AE bit before set GHC.HR, Alan Cox, (Wed Sep 26, 10:30 am)
Re: [PATCH] ahci: enable GHC.AE bit before set GHC.HR, Jeff Garzik, (Wed Sep 26, 10:33 am)
Re: [PATCH] ahci: enable GHC.AE bit before set GHC.HR, Alan Cox, (Wed Sep 26, 12:10 pm)
Re: [PATCH] ahci: enable GHC.AE bit before set GHC.HR, Jeff Garzik, (Wed Sep 26, 12:20 pm)
Re: [PATCH] ahci: enable GHC.AE bit before set GHC.HR, Jens Axboe, (Fri Sep 21, 6:31 am)
Re: [PATCH] ahci: enable GHC.AE bit before set GHC.HR, Alan Cox, (Fri Sep 21, 7:27 am)
Re: [PATCH] ahci: enable GHC.AE bit before set GHC.HR, Jens Axboe, (Fri Sep 21, 7:34 am)
Re: [PATCH] ahci: enable GHC.AE bit before set GHC.HR, Andrew Morton, (Fri Sep 21, 6:29 am)