Re: [PATCH 05/25] Unionfs: cast page->index loff_t before shifting | KernelTrap

Re: [PATCH 05/25] Unionfs: cast page->index loff_t before shifting

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Erez Zadok <ezk@...>

To: Christoph Hellwig <hch@...>

Cc: Erez Zadok <ezk@...>, <akpm@...>, <linux-kernel@...>, <linux-fsdevel@...>, <viro@...>

Subject: Re: [PATCH 05/25] Unionfs: cast page->index loff_t before shifting

Date: Wednesday, September 26, 2007 - 9:44 am

In message <20070926083121.GA8421@infradead.org>, Christoph Hellwig writes:
quoted text> On Tue, Sep 25, 2007 at 11:09:44PM -0400, Erez Zadok wrote:
> > Fixes bugs in number promotion/demotion computation, as per
> > <http://lkml.org/lkml/2007/9/20/17>
> 
> It's better to use te page_offset helper as that avoids any confusion
> on where to cast.

Excellent.  Will do.

Erez.
-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[GIT PULL -mm] 00/25 Unionfs updates/cleanups/fixes, Erez Zadok, (Tue Sep 25, 11:09 pm)

[PATCH 18/25] Unionfs: add un/likely conditionals on super ops, Erez Zadok, (Tue Sep 25, 11:09 pm)

[PATCH 25/25] Unionfs: use poison.h for safe poison pointers, Erez Zadok, (Tue Sep 25, 11:10 pm)

[PATCH 01/25] Unionfs: Simplify unionfs_get_nlinks, Erez Zadok, (Tue Sep 25, 11:09 pm)

[PATCH 04/25] Unionfs: cache-coherency fixes, Erez Zadok, (Tue Sep 25, 11:09 pm)

[PATCH 02/25] Unionfs: Remove unused #defines, Erez Zadok, (Tue Sep 25, 11:09 pm)

[PATCH 16/25] Unionfs: add un/likely conditionals on inode ops, Erez Zadok, (Tue Sep 25, 11:09 pm)

[PATCH 09/25] Unionfs: add un/likely conditionals on common ..., Erez Zadok, (Tue Sep 25, 11:09 pm)

[PATCH 11/25] Unionfs: add un/likely conditionals on debug ops, Erez Zadok, (Tue Sep 25, 11:09 pm)

Re: [PATCH 11/25] Unionfs: add un/likely conditionals on deb..., roel, (Wed Sep 26, 5:34 pm)

[PATCH 10/25] Unionfs: add un/likely conditionals on copyup ..., Erez Zadok, (Tue Sep 25, 11:09 pm)

Re: [PATCH 10/25] Unionfs: add un/likely conditionals on cop..., Kok, Auke, (Wed Sep 26, 12:32 am)

Re: [PATCH 10/25] Unionfs: add un/likely conditionals on cop..., Erez Zadok, (Wed Sep 26, 9:40 am)

Re: [PATCH 10/25] Unionfs: add un/likely conditionals on cop..., Adrian Bunk, (Wed Sep 26, 2:34 pm)

Re: [PATCH 10/25] Unionfs: add un/likely conditionals on cop..., Kyle Moffett, (Wed Sep 26, 11:23 am)

Re: [PATCH 10/25] Unionfs: add un/likely conditionals on cop..., Erez Zadok, (Wed Sep 26, 11:43 am)

Re: [PATCH 10/25] Unionfs: add un/likely conditionals on cop..., Jan Engelhardt, (Wed Sep 26, 12:47 pm)

Re: [PATCH 10/25] Unionfs: add un/likely conditionals on cop..., Erez Zadok, (Wed Sep 26, 12:51 pm)

[PATCH 12/25] Unionfs: add un/likely conditionals on dentry ..., Erez Zadok, (Tue Sep 25, 11:09 pm)

[PATCH 20/25] Unionfs: add un/likely conditionals on rename ..., Erez Zadok, (Tue Sep 25, 11:09 pm)

[PATCH 13/25] Unionfs: add un/likely conditionals on dir ops, Erez Zadok, (Tue Sep 25, 11:09 pm)

Re: [PATCH 13/25] Unionfs: add un/likely conditionals on dir..., roel, (Wed Sep 26, 5:40 pm)

Re: [PATCH 13/25] Unionfs: add un/likely conditionals on dir..., Erez Zadok, (Thu Sep 27, 10:28 am)

[PATCH 17/25] Unionfs: add un/likely conditionals on lookup ..., Erez Zadok, (Tue Sep 25, 11:09 pm)

[PATCH 15/25] Unionfs: add un/likely conditionals on fileops, Erez Zadok, (Tue Sep 25, 11:09 pm)

[PATCH 23/25] Unionfs: add un/likely conditionals on unlink ..., Erez Zadok, (Tue Sep 25, 11:10 pm)

[PATCH 06/25] Unionfs: minor coding style updates, Erez Zadok, (Tue Sep 25, 11:09 pm)

[PATCH 22/25] Unionfs: add un/likely conditionals on common ..., Erez Zadok, (Tue Sep 25, 11:10 pm)

[PATCH 07/25] Unionfs: add lower nameidata debugging support, Erez Zadok, (Tue Sep 25, 11:09 pm)

[PATCH 08/25] Unionfs: lower nameidata support for nfsv4, Erez Zadok, (Tue Sep 25, 11:09 pm)

[PATCH 19/25] Unionfs: add un/likely conditionals on mmap ops, Erez Zadok, (Tue Sep 25, 11:09 pm)

[PATCH 21/25] Unionfs: add un/likely conditionals on readdir..., Erez Zadok, (Tue Sep 25, 11:10 pm)

[PATCH 03/25] Unionfs: display informational messages only i..., Erez Zadok, (Tue Sep 25, 11:09 pm)

Re: [PATCH 03/25] Unionfs: display informational messages on..., Jan Engelhardt, (Wed Sep 26, 4:36 am)

Re: [PATCH 03/25] Unionfs: display informational messages on..., Erez Zadok, (Wed Sep 26, 10:01 am)

Re: [PATCH 03/25] Unionfs: display informational messages on..., Jan Engelhardt, (Wed Sep 26, 11:24 am)

Re: [PATCH 03/25] Unionfs: display informational messages on..., Erez Zadok, (Wed Sep 26, 11:28 am)

[PATCH 14/25] Unionfs: add un/likely conditionals on headers, Erez Zadok, (Tue Sep 25, 11:09 pm)

[PATCH 24/25] Unionfs: add un/likely conditionals on xattr ops, Erez Zadok, (Tue Sep 25, 11:10 pm)

[PATCH 05/25] Unionfs: cast page->index loff_t before shifting, Erez Zadok, (Tue Sep 25, 11:09 pm)

Re: [PATCH 05/25] Unionfs: cast page->index loff_t before..., Christoph Hellwig, (Wed Sep 26, 4:31 am)

Re: [PATCH 05/25] Unionfs: cast page->index loff_t before..., Erez Zadok, (Wed Sep 26, 9:44 am)

Navigation

Popular discussions


linux-kernel:
Tarkan Erimer	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg KH	[GIT PATCH] driver core patches against 2.6.24
David Newall	Re: Slow DOWN, please!!!
Peter Zijlstra	[PATCH 00/23] per device dirty throttling -v8
linux-netdev:
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
David Miller	[GIT]: Networking
Natalie Protasevich	[BUG] New Kernel Bugs
openbsd-misc:

git:

Colocation donated by:

Who's online

There are currently 1 user and 603 guests online.

Online users

belgranos87

Syndicate