Home » Mailing list archives » linux-kernel » 2007 » September » 25

[PATCH] cdrom_open() forgets to unlock on -EROFS failure exits

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Al Viro <viro@...>
To: <torvalds@...>
Cc: <linux-kernel@...>, <axboe@...>
Subject: [PATCH] cdrom_open() forgets to unlock on -EROFS failure exits
Date: Tuesday, September 25, 2007 - 8:54 pm

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
 drivers/cdrom/cdrom.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
index 67ee3d4..7924571 100644
--- a/drivers/cdrom/cdrom.c
+++ b/drivers/cdrom/cdrom.c
@@ -1032,6 +1032,10 @@ int cdrom_open(struct cdrom_device_info *cdi, struct inode *ip, struct file *fp)
 	check_disk_change(ip->i_bdev);
 	return 0;
 err_release:
+	if (CDROM_CAN(CDC_LOCK) && cdi->options & CDO_LOCK) {
+		cdi->ops->lock_door(cdi, 0);
+		cdinfo(CD_OPEN, "door unlocked.\n");
+	}
 	cdi->ops->release(cdi);
 err:
 	cdi->use_count--;
-- 
1.5.3.GIT


-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] cdrom_open() forgets to unlock on -EROFS failure exits, Al Viro, (Tue Sep 25, 8:54 pm)
Re: [PATCH] cdrom_open() forgets to unlock on -EROFS failure..., Jens Axboe, (Wed Sep 26, 2:19 am)