Re: 2.6.23-rc8-mm1

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andrew Morton <akpm@...>, <apw@...>
Cc: lkml <linux-kernel@...>
Date: Tuesday, September 25, 2007 - 6:05 pm

Hi Andy,

One the patch you created in -mm is causing compile warning.
Here is the fix. Please verify.

Thanks,
Badari

arch/powerpc/mm/init_64.c: In function `vmemmap_populated':
arch/powerpc/mm/init_64.c:211: warning: passing arg 1 of `vmemmap_section_start' makes pointer from integer without a cast

vmemmap_section_start() gets called with an argument which is unsigned long.

Signed-off-by: Badari Pulavarty <pbadari@us.ibm.com>

Index: linux-2.6.23-rc8/arch/powerpc/mm/init_64.c
===================================================================
--- linux-2.6.23-rc8.orig/arch/powerpc/mm/init_64.c	2007-09-25 09:18:13.000000000 -0700
+++ linux-2.6.23-rc8/arch/powerpc/mm/init_64.c	2007-09-25 14:50:44.000000000 -0700
@@ -189,10 +189,9 @@ void pgtable_cache_init(void)
  * do this by hand as the proffered address may not be correctly aligned.
  * Subtraction of non-aligned pointers produces undefined results.
  */
-unsigned long __meminit vmemmap_section_start(struct page *page)
+unsigned long __meminit vmemmap_section_start(unsigned long page)
 {
-	unsigned long offset = ((unsigned long)page) -
-						((unsigned long)(vmemmap));
+	unsigned long offset = page - ((unsigned long)(vmemmap));
 
 	/* Return the pfn of the start of the section. */
 	return (offset / sizeof(struct page)) & PAGE_SECTION_MASK;


-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.23-rc8-mm1, Andrew Morton, (Tue Sep 25, 4:46 am)
black screen after kill X [Was: 2.6.23-rc8-mm1], Jiri Slaby, (Wed Sep 26, 3:51 am)
Re: 2.6.23-rc8-mm1 : wgt634u.c, trem, (Tue Sep 25, 6:23 pm)
Re: 2.6.23-rc8-mm1, Badari Pulavarty, (Tue Sep 25, 6:05 pm)
Re: 2.6.23-rc8-mm1, Andy Whitcroft, (Wed Sep 26, 8:28 am)
Re: 2.6.23-rc8-mm1: drivers/kvm/ioapic.o build failure, Mariusz Kozlowski, (Tue Sep 25, 4:56 pm)
Re: 2.6.23-rc8-mm1 - powerpc memory hotplug link failure, Kamalesh Babulal, (Tue Sep 25, 4:00 pm)
Re: 2.6.23-rc8-mm1 - powerpc memory hotplug link failure, KAMEZAWA Hiroyuki, (Tue Sep 25, 9:32 pm)
Re: 2.6.23-rc8-mm1 - powerpc memory hotplug link failure, KAMEZAWA Hiroyuki, (Tue Sep 25, 9:48 pm)
Re: 2.6.23-rc8-mm1 - powerpc memory hotplug link failure, Kamalesh Babulal, (Wed Sep 26, 4:19 am)
Re: 2.6.23-rc8-mm1 - powerpc memory hotplug link failure, Badari Pulavarty, (Tue Sep 25, 6:01 pm)
Re: 2.6.23-rc8-mm1 - powerpc memory hotplug link failure, Kamalesh Babulal, (Wed Sep 26, 4:18 am)
Re: 2.6.23-rc8-mm1, Randy Dunlap, (Tue Sep 25, 1:26 pm)
[PATCH 1/1] Unionfs: move poison #define into poison.h, Josef 'Jeff' Sipek, (Tue Sep 25, 1:45 pm)
Re: [PATCH 1/1] Unionfs: move poison #define into poison.h, Josef 'Jeff' Sipek, (Tue Sep 25, 9:02 pm)
Re: 2.6.23-rc8-mm1, Josef Sipek, (Tue Sep 25, 1:39 pm)
2.6.23-rc8-mm1: unscrew UFS, Alexey Dobriyan, (Tue Sep 25, 3:02 pm)
2.6.23-rc8-mm1 -- powerpc link failure, Andy Whitcroft, (Tue Sep 25, 9:46 am)
Re: 2.6.23-rc8-mm1 -- powerpc link failure, Jiri Kosina, (Tue Sep 25, 11:23 am)
Re: 2.6.23-rc8-mm1 -- powerpc link failure, Andy Whitcroft, (Thu Sep 27, 8:03 am)
Re: 2.6.23-rc8-mm1 -- powerpc link failure, Jiri Kosina, (Thu Sep 27, 8:13 am)
Re: 2.6.23-rc8-mm1 -- powerpc link failure, Andrew Morton, (Thu Sep 27, 6:13 pm)
Re: 2.6.23-rc8-mm1 -- powerpc link failure, Jiri Kosina, (Thu Sep 27, 6:17 pm)
Re: 2.6.23-rc8-mm1 -- powerpc link failure, Andrew Morton, (Thu Sep 27, 1:13 pm)
Re: 2.6.23-rc8-mm1 -- powerpc link failure, Sam Ravnborg, (Thu Sep 27, 3:31 pm)
Re: 2.6.23-rc8-mm1 - drivers/net/ibm_newemac/mal - broken, Kamalesh Babulal, (Tue Sep 25, 8:53 am)
Re: 2.6.23-rc8-mm1 - drivers/net/ibm_newemac/mal - broken, Andrew Morton, (Tue Sep 25, 12:16 pm)
Re: 2.6.23-rc8-mm1, Kamalesh Babulal, (Tue Sep 25, 6:39 am)
Re: 2.6.23-rc8-mm1, Andrew Morton, (Tue Sep 25, 11:46 am)