Re: Linux 2.6.22.8, pata_ali issue

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Greg KH <gregkh@...>
Cc: Oliver Pinter <oliver.pntr@...>, <linux-kernel@...>, Andrew Morton <akpm@...>, <torvalds@...>, <stable@...>
Date: Tuesday, September 25, 2007 - 1:03 pm

From my point, sorry for thread hijacking, but I did not have
the upper node anymore.

So, here is something that I think should go into the next 2.6.22.
A proper fix is already in 2.6.23-git-du-jour.

/home/build/rt.jengelh.10.2-i386/var/tmp/kernel-source-2.6.22.7-build
/usr/src/linux-2.6.22.7-13.1/drivers/ata/pata_ali.c:
In function ■ali_init_chipset■:

/home/build/rt.jengelh.10.2-i386/var/tmp/kernel-source-2.6.22.7-build
/usr/src/linux-2.6.22.7-13.1/drivers/ata/pata_ali.c:466:
warning: ■rev■ is used uninitialized in this function

Yes, it is indeed used uninitialized, and that is dangerous,
given that I do have a chipset that uses pata_ali.ko and
currently runs a 'broken' kernel...it has not exploded yet, though.

I could not backport and create a patch because struct pci_dev
does not have the ->revision field in 2.6.22 yet. Ideas?
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Linux 2.6.22.8, Greg Kroah-Hartman, (Tue Sep 25, 2:21 am)
Re: Linux 2.6.22.8, Oliver Pinter, (Tue Sep 25, 12:09 pm)
Re: Linux 2.6.22.8, Greg KH, (Tue Sep 25, 12:14 pm)
Re: Linux 2.6.22.8, pata_ali issue, Jan Engelhardt, (Tue Sep 25, 1:03 pm)
Re: Linux 2.6.22.8, pata_ali issue, Greg KH, (Tue Sep 25, 1:35 pm)
Re: Linux 2.6.22.8, pata_ali issue, Jan Engelhardt, (Tue Sep 25, 3:38 pm)
Re: Linux 2.6.22.8, Greg Kroah-Hartman, (Tue Sep 25, 2:22 am)