Re: Chroot bug

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Miloslav Semler <majkls@...>
Cc: Jan Engelhardt <jengelh@...>, <serge@...>, <davidsen@...>, <philipp@...>, <7eggert@...>, <alan@...>, <linux-kernel@...>
Date: Tuesday, September 25, 2007 - 12:53 pm

Quoting Miloslav Semler (majkls@prepere.com):

Yes, to understand why that doesn't work it helps to understand why
pivot_root *does* work.  Pivot_root takes the new_root, which must be
a mount, and detaches it from it's mountpoint.  So it's not that we
try to intercept a chdir(root_dir/..), but rather we remove root_dir
from it's parent dir so that root_dir/.. must always return root_dir.

I'm sorry but I really don't see where hacking chroot to try and
detect and prevent chroot escapes is going to be acceptable to
anyone so long as pivot_root does the trick anyway.  If you want
portable, then write a little linux-only safe_chroot() library call
which does unshare();pivot_root() on linux and just chroot on a
system that does try to stop chroot escapes.

Besides as others have alluded to, if you have root privs, you can
always mknod /dev/hda1, mount that under /mnt, and then chroot or
pivot_root to there.

The containers work will, in fact, be intended to be a *safe*
jail.  That'll happen through pivot_root, capability masking,
perhaps device namespaces, etc.  But a secure container is still
a ways off.

-serge
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: sys_chroot+sys_fchdir Fix, Bodo Eggert, (Thu Sep 20, 7:13 am)
Re: sys_chroot+sys_fchdir Fix, Philipp Marek, (Thu Sep 20, 7:59 am)
Re: sys_chroot+sys_fchdir Fix, David Newall, (Thu Sep 20, 12:06 pm)
Re: sys_chroot+sys_fchdir Fix, Philipp Marek, (Thu Sep 20, 12:17 pm)
Re: sys_chroot+sys_fchdir Fix, David Newall, (Thu Sep 20, 2:02 pm)
Re: sys_chroot+sys_fchdir Fix, Bill Davidsen, (Thu Sep 20, 4:53 pm)
Re: sys_chroot+sys_fchdir Fix, David Newall, (Fri Sep 21, 4:29 am)
Re: sys_chroot+sys_fchdir Fix, Serge E. Hallyn, (Mon Sep 24, 5:32 pm)
Re: sys_chroot+sys_fchdir Fix, David Newall, (Mon Sep 24, 6:04 pm)
Re: sys_chroot+sys_fchdir Fix, Serge E. Hallyn, (Mon Sep 24, 7:02 pm)
Re: sys_chroot+sys_fchdir Fix, Serge E. Hallyn, (Mon Sep 24, 7:00 pm)
Re: sys_chroot+sys_fchdir Fix, David Newall, (Tue Sep 25, 3:45 am)
Re: sys_chroot+sys_fchdir Fix, Serge E. Hallyn, (Tue Sep 25, 7:49 am)
Re: sys_chroot+sys_fchdir Fix, David Newall, (Tue Sep 25, 9:58 am)
Chroot bug (was: sys_chroot+sys_fchdir Fix), David Newall, (Tue Sep 25, 11:10 am)
Re: Chroot bug (was: sys_chroot+sys_fchdir Fix), Bodo Eggert, (Wed Sep 26, 3:23 pm)
Re: Chroot bug (was: sys_chroot+sys_fchdir Fix), Adrian Bunk, (Tue Sep 25, 11:32 am)
Re: Chroot bug, Miloslav Semler, (Tue Sep 25, 11:43 am)
Re: Chroot bug, Adrian Bunk, (Tue Sep 25, 12:02 pm)
Re: Chroot bug (was: sys_chroot+sys_fchdir Fix), Alan Cox, (Tue Sep 25, 11:30 am)
Re: Chroot bug, David Newall, (Tue Sep 25, 11:35 am)
Re: Chroot bug, Arjan van de Ven, (Tue Sep 25, 12:33 pm)
Re: Chroot bug, Alan Cox, (Tue Sep 25, 11:48 am)
Re: Chroot bug, David Newall, (Tue Sep 25, 7:50 pm)
Re: Chroot bug, Adrian Bunk, (Tue Sep 25, 8:55 pm)
Re: Chroot bug, Kyle Moffett, (Wed Sep 26, 1:21 am)
Re: Chroot bug, David Newall, (Wed Sep 26, 6:27 am)
Re: Chroot bug, Kyle Moffett, (Wed Sep 26, 8:54 am)
Re: Chroot bug, Miloslav Semler, (Wed Sep 26, 9:11 am)
Re: Chroot bug, Kyle Moffett, (Wed Sep 26, 10:02 am)
Re: Chroot bug, Miloslav Semler, (Wed Sep 26, 11:01 am)
Re: Chroot bug, Jiri Kosina, (Thu Sep 27, 9:49 am)
Re: Chroot bug, Al Viro, (Wed Sep 26, 9:42 am)
Re: Chroot bug, Miloslav Semler, (Wed Sep 26, 10:51 am)
Re: Chroot bug, Olivier Galibert, (Wed Sep 26, 6:45 am)
Re: Chroot bug, David Newall, (Wed Sep 26, 7:13 am)
Re: Chroot bug, Olivier Galibert, (Wed Sep 26, 11:02 am)
Re: Chroot bug, linux-os (Dick Johnson), (Wed Sep 26, 9:18 am)
Re: Chroot bug, Willy Tarreau, (Wed Sep 26, 1:25 am)
Re: Chroot bug, Alan Cox, (Tue Sep 25, 8:18 pm)
Re: Chroot bug, David Newall, (Wed Sep 26, 6:24 am)
Re: Chroot bug, Alan Cox, (Wed Sep 26, 6:47 am)
Re: Chroot bug, David Newall, (Wed Sep 26, 7:06 am)
Re: Chroot bug, Bongani Hlope, (Wed Sep 26, 9:13 am)
Re: Chroot bug, Alan Cox, (Wed Sep 26, 7:20 am)
Re: Chroot bug, Jan Engelhardt, (Tue Sep 25, 11:47 am)
Re: Chroot bug (was: sys_chroot+sys_fchdir Fix), Jan Engelhardt, (Tue Sep 25, 11:20 am)
Re: Chroot bug, Miloslav Semler, (Tue Sep 25, 11:39 am)
Re: Chroot bug, David Newall, (Tue Sep 25, 11:41 am)
Re: Chroot bug, Jan Engelhardt, (Tue Sep 25, 11:48 am)
Re: Chroot bug, David Newall, (Tue Sep 25, 4:51 pm)
Re: Chroot bug, Miloslav Semler, (Tue Sep 25, 12:19 pm)
Re: Chroot bug, Serge E. Hallyn, (Tue Sep 25, 12:53 pm)
Re: Chroot bug, Jan Engelhardt, (Tue Sep 25, 12:52 pm)
Re: Chroot bug, Miloslav Semler, (Tue Sep 25, 1:00 pm)
Re: Chroot bug, Jan Engelhardt, (Tue Sep 25, 1:05 pm)
Re: Chroot bug, Al Viro, (Tue Sep 25, 1:09 pm)
Re: Chroot bug, Miloslav Semler, (Tue Sep 25, 1:19 pm)
Re: Chroot bug, Miloslav Semler, (Tue Sep 25, 1:09 pm)
Re: sys_chroot+sys_fchdir Fix, majkls, (Thu Sep 20, 8:52 am)