[PATCH 3/3] Fix other possible sources of latency issues

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Srivatsa Vaddagiri
Date: Tuesday, September 25, 2007 - 9:37 am

There is a possibility that because of task of a group moving from one
cpu to another, it may gain more cpu time that desired. See 
http://marc.info/?l=linux-kernel&m=119073197730334 for details.

This is an attempt to fix that problem. Basically it simulates dequeue
of higher level entities as if they are going to sleep. Similarly it
simulate wakeup of higher level entities as if they are waking up from
sleep.

Signed-off-by : Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>

---
 kernel/sched_fair.c |    2 ++
 1 files changed, 2 insertions(+)

Index: current/kernel/sched_fair.c
===================================================================
--- current.orig/kernel/sched_fair.c
+++ current/kernel/sched_fair.c
@@ -715,6 +715,7 @@ static void enqueue_task_fair(struct rq 
 			break;
 		cfs_rq = cfs_rq_of(se);
 		enqueue_entity(cfs_rq, se, wakeup);
+		wakeup = 1;
 	}
 }
 
@@ -734,6 +735,7 @@ static void dequeue_task_fair(struct rq 
 		/* Don't dequeue parent if it has other entities besides us */
 		if (cfs_rq->load.weight)
 			break;
+		sleep = 1;
 	}
 }
 
-- 
Regards,
vatsa
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[git] CFS-devel, latest code, Ingo Molnar, (Tue Sep 25, 7:44 am)
Re: [git] CFS-devel, latest code, Srivatsa Vaddagiri, (Tue Sep 25, 9:04 am)
Re: [git] CFS-devel, latest code, Srivatsa Vaddagiri, (Tue Sep 25, 9:08 am)
[PATCH 0/3] More group scheduler related fixes, Srivatsa Vaddagiri, (Tue Sep 25, 9:25 am)
[PATCH 1/3] Fix coding style, Srivatsa Vaddagiri, (Tue Sep 25, 9:28 am)
[PATCH 2/3] Fix size bloat for !CONFIG_FAIR_GROUP_SCHED, Srivatsa Vaddagiri, (Tue Sep 25, 9:33 am)
[PATCH 3/3] Fix other possible sources of latency issues, Srivatsa Vaddagiri, (Tue Sep 25, 9:37 am)
Re: [PATCH 0/3] More group scheduler related fixes, Ingo Molnar, (Tue Sep 25, 11:32 am)
Re: [PATCH 1/3] Fix coding style, Ingo Oeser, (Tue Sep 25, 12:16 pm)
Re: [PATCH 1/3] Fix coding style, Kyle Moffett, (Tue Sep 25, 1:47 pm)
Re: [PATCH 1/3] Fix coding style, Dhaval Giani, (Tue Sep 25, 7:03 pm)