[PATCH 1/3] Fix coding style

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ingo Molnar <mingo@...>
Cc: <linux-kernel@...>, Peter Zijlstra <a.p.zijlstra@...>, Mike Galbraith <efault@...>, Dhaval Giani <dhaval@...>, Dmitry Adamushko <dmitry.adamushko@...>, Andrew Morton <akpm@...>, <randy.dunlap@...>
Date: Tuesday, September 25, 2007 - 12:28 pm

Fix coding style issues reported by Randy Dunlap and others

Signed-off-by : Dhaval Giani <dhaval@linux.vnet.ibm.com>
Signed-off-by : Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>

---
 init/Kconfig         |   14 +++++++-------
 kernel/sched_debug.c |    8 ++------
 2 files changed, 9 insertions(+), 13 deletions(-)

Index: current/init/Kconfig
===================================================================
--- current.orig/init/Kconfig
+++ current/init/Kconfig
@@ -282,11 +282,11 @@ config CPUSETS
 	  Say N if unsure.
 
 config FAIR_GROUP_SCHED
-	bool "Fair group cpu scheduler"
+	bool "Fair group CPU scheduler"
 	default y
 	depends on EXPERIMENTAL
 	help
-	  This feature lets cpu scheduler recognize task groups and control cpu
+	  This feature lets CPU scheduler recognize task groups and control CPU
 	  bandwidth allocation to such task groups.
 
 choice
@@ -294,11 +294,11 @@ choice
 	prompt "Basis for grouping tasks"
 	default FAIR_USER_SCHED
 
-	config FAIR_USER_SCHED
-		bool "user id"
-		help
-		  This option will choose userid as the basis for grouping
-		  tasks, thus providing equal cpu bandwidth to each user.
+config FAIR_USER_SCHED
+	bool "user id"
+	help
+	  This option will choose userid as the basis for grouping
+	  tasks, thus providing equal CPU bandwidth to each user.
 
 endchoice
 
Index: current/kernel/sched_debug.c
===================================================================
--- current.orig/kernel/sched_debug.c
+++ current/kernel/sched_debug.c
@@ -239,11 +239,7 @@ static int
 root_user_share_read_proc(char *page, char **start, off_t off, int count,
 				 int *eof, void *data)
 {
-	int len;
-
-	len = sprintf(page, "%d\n", init_task_grp_load);
-
-	return len;
+	return sprintf(page, "%d\n", init_task_grp_load);
 }
 
 static int
@@ -297,7 +293,7 @@ static int __init init_sched_debug_procf
 	pe->proc_fops = &sched_debug_fops;
 
 #ifdef CONFIG_FAIR_USER_SCHED
-	pe = create_proc_entry("root_user_share", 0644, NULL);
+	pe = create_proc_entry("root_user_cpu_share", 0644, NULL);
 	if (!pe)
 		return -ENOMEM;
 


-- 
Regards,
vatsa
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[git] CFS-devel, latest code, Ingo Molnar, (Tue Sep 25, 10:44 am)
[PATCH 0/3] More group scheduler related fixes, Srivatsa Vaddagiri, (Tue Sep 25, 12:25 pm)
Re: [PATCH 0/3] More group scheduler related fixes, Ingo Molnar, (Tue Sep 25, 2:32 pm)
[PATCH 3/3] Fix other possible sources of latency issues, Srivatsa Vaddagiri, (Tue Sep 25, 12:37 pm)
[PATCH 2/3] Fix size bloat for !CONFIG_FAIR_GROUP_SCHED, Srivatsa Vaddagiri, (Tue Sep 25, 12:33 pm)
[PATCH 1/3] Fix coding style, Srivatsa Vaddagiri, (Tue Sep 25, 12:28 pm)
Re: [PATCH 1/3] Fix coding style, Ingo Oeser, (Tue Sep 25, 3:16 pm)
Re: [PATCH 1/3] Fix coding style, Dhaval Giani, (Tue Sep 25, 10:03 pm)
Re: [PATCH 1/3] Fix coding style, Kyle Moffett, (Tue Sep 25, 4:47 pm)
Re: [git] CFS-devel, latest code, Srivatsa Vaddagiri, (Tue Sep 25, 12:04 pm)
Re: [git] CFS-devel, latest code, Srivatsa Vaddagiri, (Tue Sep 25, 12:08 pm)