Home » Mailing list archives » linux-kernel » 2007 » September » 24

Re: [PATCH 1/1] x86: Convert cpuinfo_x86 array to a per_cpu array v3

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Dave Jones <davej@...>
To: roel <12o3l@...>
Cc: <travis@...>, Andrew Morton <akpm@...>, Andi Kleen <ak@...>, Christoph Lameter <clameter@...>, Jack Steiner <steiner@...>, <linux-mm@...>, <linux-kernel@...>
Subject: Re: [PATCH 1/1] x86: Convert cpuinfo_x86 array to a per_cpu array v3
Date: Monday, September 24, 2007 - 7:24 pm

<excessive quoting trimmed, please don't quote 40K of text
 to add a single line reply>

On Tue, Sep 25, 2007 at 12:01:56AM +0200, roel wrote:

 > > --- a/arch/i386/kernel/cpu/cpufreq/powernow-k6.c
 > > +++ b/arch/i386/kernel/cpu/cpufreq/powernow-k6.c
 > > @@ -215,7 +215,7 @@ static struct cpufreq_driver powernow_k6
 > >   */
 > >  static int __init powernow_k6_init(void)
 > >  {
 > > -	struct cpuinfo_x86      *c = cpu_data;
 > > +	struct cpuinfo_x86 *c = &cpu_data(0);
 > >  
 > >  	if ((c->x86_vendor != X86_VENDOR_AMD) || (c->x86 != 5) ||
 > >  		((c->x86_model != 12) && (c->x86_model != 13)))
 > 
 > while we're at it, we could change this to
 > 
 >   	if (!(c->x86_vendor == X86_VENDOR_AMD && c->x86 == 5 &&
 >   		(c->x86_model == 12 || c->x86_model == 13)))

For what purpose?  There's nothing wrong with the code as it stands,
and inverting the tests means we'd have to move a bunch of
code inside the if arm instead of just returning -ENODEV.

	Dave

-- 
http://www.codemonkey.org.uk
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 1/1] x86: Convert cpuinfo_x86 array to a per_cpu arra..., , (Mon Sep 24, 5:08 pm)
Re: [PATCH 1/1] x86: Convert cpuinfo_x86 array to a per_cpu ..., roel, (Mon Sep 24, 6:01 pm)
Re: [PATCH 1/1] x86: Convert cpuinfo_x86 array to a per_cpu ..., Dave Jones, (Mon Sep 24, 7:24 pm)
Re: [PATCH 1/1] x86: Convert cpuinfo_x86 array to a per_cpu ..., roel, (Mon Sep 24, 8:20 pm)
Re: [PATCH 1/1] x86: Convert cpuinfo_x86 array to a per_cpu ..., Dave Jones, (Mon Sep 24, 8:31 pm)