On Tue, 25 Sep 2007 01:12:32 +0200
roel <12o3l@tiscali.nl> wrote:

quoted text
> >  #define ata_id_cdb_intr(id)	(((id)[0] & 0x60) == 0x20)
> > +#define ata_id_has_hipm(id)	\
> > +	( (((id)[76] != 0x0000) && ((id)[76] != 0xffff)) && \
> > +	  ((id)[76] & (1 << 9)) )
> 		^
> 		|
> are you sure this
> should be 76?

Yes.

quoted text
> 
> we can also change the first statement a bit:
> 	(!(((id)[76] == 0x0000) || ((id)[76] == 0xffff)) && \
> 
> 
> > +#define ata_id_has_dipm(id)	\
> > +	( (((id)[76] != 0x0000) && ((id)[76] != 0xffff)) && \
> 
> and:
> 	(!(((id)[76] == 0x0000) || ((id)[76] == 0xffff)) && \

I feel this is equivalent functionality and not as readable.
-
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/