Re: [PATCH/RFC] samples/: move kprobes sources to samples

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Randy Dunlap <randy.dunlap@...>
Cc: lkml <linux-kernel@...>, <prasanna@...>, <ananth@...>, <anil.s.keshavamurthy@...>, <hch@...>, <mathieu.desnoyers@...>, akpm <akpm@...>, <sam@...>, <davem@...>
Date: Monday, September 24, 2007 - 6:24 pm

I could only point to three nitpicks 

Randy Dunlap wrote:

or do:
	ret = register_jprobe(&my_jprobe);
	if (ret < 0) {


or without brackets


or:
	ret = register_kretprobe(&my_kretprobe);
	if ( ret < 0 ) {


-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH/RFC] samples/: move kprobes sources to samples, Randy Dunlap, (Mon Sep 24, 5:58 pm)
Re: [PATCH/RFC] samples/: move kprobes sources to samples, Ananth N Mavinakayanahalli..., (Tue Sep 25, 4:43 am)
Re: [PATCH/RFC] samples/: move kprobes sources to samples, Christoph Hellwig, (Tue Sep 25, 4:57 am)
Re: [PATCH/RFC] samples/: move kprobes sources to samples, Ananth N Mavinakayanahalli..., (Tue Sep 25, 6:00 am)
Re: [PATCH/RFC] samples/: move kprobes sources to samples, roel, (Mon Sep 24, 6:24 pm)
Re: [PATCH/RFC] samples/: move kprobes sources to samples, Mathieu Desnoyers, (Mon Sep 24, 6:21 pm)
Re: [PATCH/RFC] samples/: move kprobes sources to samples, Mathieu Desnoyers, (Mon Sep 24, 6:45 pm)