Home » Mailing list archives » linux-kernel » 2007 » September » 24

Re: [PATCH] Patches for tiny 386 kernels, again. Linux kernel 2.6.22.7

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Dave Jones <davej@...>
To: Jonathan Campbell <jon@...>
Cc: <linux-kernel@...>
Subject: Re: [PATCH] Patches for tiny 386 kernels, again. Linux kernel 2.6.22.7
Date: Monday, September 24, 2007 - 3:09 pm

On Mon, Sep 24, 2007 at 01:51:17AM -0700, Jonathan Campbell wrote:


 > +#if defined(__i386__) && defined(CONFIG_DMI)
 >  	dmi_check_system(acpi_dmi_table);
 >  #endif
 >  
 > +#ifdef CONFIG_DMI
 >  	dmi_scan_machine();
 > +#endif
 >  
 > +#ifdef CONFIG_DMI
 >  	/* Check and install the TSC clocksource */
 >  	dmi_check_system(bad_tsc_dmi_table);
 > +#endif
 >  
 > +#ifdef CONFIG_DMI
 >  	dmi_check_system(acpi_osl_dmi_table);
 > +#endif
 
Instead of adding all these ifdefs, we could just define
add something along the lines of..

#ifndef CONFIG_DMI
#define dmi_check_system do {} while (0)
#endif

in some header, which hides the uglies away from the code
whilst having the same net effect.

	Dave

-- 
http://www.codemonkey.org.uk
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] Patches for tiny 386 kernels, again. Linux kernel 2...., Jonathan Campbell, (Mon Sep 24, 4:51 am)
Re: [PATCH] Patches for tiny 386 kernels, again. Linux kerne..., Dave Jones, (Mon Sep 24, 3:09 pm)
Re: [PATCH] Patches for tiny 386 kernels, again. Linux kerne..., Jan Engelhardt, (Tue Sep 25, 3:28 am)
Re: [PATCH] Patches for tiny 386 kernels, again. Linux kerne..., Andrey Panin, (Tue Sep 25, 12:45 am)
Re: [PATCH] Patches for tiny 386 kernels, again. Linux kerne..., Randy Dunlap, (Mon Sep 24, 1:49 pm)
Re: [PATCH] Patches for tiny 386 kernels, again. Linux kerne..., Bill Davidsen, (Fri Sep 28, 5:24 pm)
Re: [PATCH] Patches for tiny 386 kernels, again. Linux kerne..., Lennart Sorensen, (Mon Oct 1, 9:44 am)
Re: [PATCH] Patches for tiny 386 kernels, again. Linux kerne..., Bill Davidsen, (Mon Oct 1, 10:28 am)
Re: [PATCH] Patches for tiny 386 kernels, again. Linux kerne..., Willy Tarreau, (Tue Oct 2, 12:48 am)
Re: [PATCH] Patches for tiny 386 kernels, again. Linux kerne..., Randy Dunlap, (Fri Sep 28, 5:56 pm)
Re: [PATCH] Patches for tiny 386 kernels, again. Linux kerne..., Jonathan Campbell, (Wed Sep 26, 2:42 pm)
Re: [PATCH] Patches for tiny 386 kernels, again. Linux kerne..., Randy Dunlap, (Wed Sep 26, 7:20 pm)
Re: [PATCH] Patches for tiny 386 kernels, again. Linux kerne..., Jonathan Campbell, (Wed Sep 26, 7:44 pm)
Re: [PATCH] Patches for tiny 386 kernels, again. Linux kerne..., Randy Dunlap, (Wed Sep 26, 6:06 pm)