[patch 0/7] Linux Kernel Markers (redux)

Previous thread: [01/50] V4L: ivtv: fix VIDIOC_S_FBUF: new OSD values were never set by Greg KH on Monday, September 24, 2007 - 12:19 pm. (59 messages)

Next thread: bug in fsck or ext2/ext3? by Antoine Martin on Monday, September 24, 2007 - 12:56 pm. (5 messages)
To: <akpm@...>, <linux-kernel@...>
Cc: Christoph Hellwig <hch@...>
Date: Monday, September 24, 2007 - 12:49 pm

Hi Andrew,

Following Christoph Hellwig's suggestion, aiming at a Linux Kernel Markers
inclusion for 2.6.24, I made a simplified version of the Linux Kernel Markers.
There are no more dependencies on any other patchset.

The modification only involved turning the immediate values into static
variables and adapting the documentation accordingly. It will have a little more
data cache impact when disabled than the version based on the immediate values,
but it is far less complex.

Since things have not moved much in the markers area recently (most of the
concerns were about the immediate values), I expect it to be ready for 2.6.24.

It applies to 2.6.23-rc7-mm1

Patches apply in this order:

seq_file_sorted.patch
module.c-sort-module-list.patch
kconfig-instrumentation.patch
linux-kernel-markers-architecture-independent-code.patch
linux-kernel-markers-instrumentation-menu.patch
linux-kernel-markers-documentation.patch
linux-kernel-markers-port-blktrace-to-markers.patch

Mathieu

--
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
-

To: Mathieu Desnoyers <mathieu.desnoyers@...>
Cc: <akpm@...>, <linux-kernel@...>, Christoph Hellwig <hch@...>
Date: Monday, September 24, 2007 - 2:11 pm

I've done a quick review and except for my usual nitpicking it looks
very good to me. I'll try my sputrace code with this version and will
report on how it works.

I'd really love to see markers in 2.6.24. The impact to core code of
the actual markers is minimal with some more struct fields in functions
in the module code, although we'll want Mathieu's fix for the modules
list aswell which is a little more invasive. But I think we want that
one anyway.

I'd say we probably don't want the blktrace conversion that late in the
game, though - but we can queue that once together with the optimizations
from Mathieu's earlier patches in -mm.

-

To: Christoph Hellwig <hch@...>, <akpm@...>, <linux-kernel@...>
Date: Monday, September 24, 2007 - 3:04 pm

Well, since I just moved the marker iterators down in my patchset, I can
move down the module list fix altogether and keep it for later. It will

I provided blktrace as a first user of the markers, but I agree that it
may be a little late for merging. I can keep it for later too.

Mathieu

--
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
-

To: Mathieu Desnoyers <mathieu.desnoyers@...>
Cc: Christoph Hellwig <hch@...>, <akpm@...>, <linux-kernel@...>
Date: Monday, September 24, 2007 - 3:07 pm

I we manage to get Dave's trace patches and your markers in I'll make
sure to get a sputrace version using them in as a demo for both.

-

To: Christoph Hellwig <hch@...>, <akpm@...>, <linux-kernel@...>
Date: Monday, September 24, 2007 - 3:24 pm

Great!

So the state of the patches for next post:

kconfig-instrumentation.patch
linux-kernel-markers.patch

(yeah, only 2 patches!) :)

I'm only waiting for you guys to settle about documentation/samples
before I can repost.

Mathieu

--
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
-

Previous thread: [01/50] V4L: ivtv: fix VIDIOC_S_FBUF: new OSD values were never set by Greg KH on Monday, September 24, 2007 - 12:19 pm. (59 messages)

Next thread: bug in fsck or ext2/ext3? by Antoine Martin on Monday, September 24, 2007 - 12:56 pm. (5 messages)