Home » Mailing list archives » linux-kernel » 2007 » September » 23

Re: [PATCH 3/3] cxacru: Cleanup code by removing "ret = ret;" assignments

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Simon Arlott <simon@...>
To: Linux Kernel Mailing List <linux-kernel@...>
Cc: Greg Kroah-Hartman <gregkh@...>
Subject: Re: [PATCH 3/3] cxacru: Cleanup code by removing "ret = ret;" assignments
Date: Sunday, September 23, 2007 - 11:36 am

Cleanup code by removing "ret = ret;" assignments.

Signed-Off-By: Simon Arlott <simon@fire.lp0.eu>
---
 drivers/usb/atm/cxacru.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/atm/cxacru.c b/drivers/usb/atm/cxacru.c
index 35308a8..bb3169c 100644
--- a/drivers/usb/atm/cxacru.c
+++ b/drivers/usb/atm/cxacru.c
@@ -496,7 +496,6 @@ static int cxacru_cm(struct cxacru_data *instance, enum cxacru_cm_request cm,
 	if (ret < 0) {
 		usb_err(instance->usbatm, "submit of read urb for cm %#x failed (%d)\n",
 			cm, ret);
-		ret = ret;
 		goto fail;
 	}
 
@@ -514,21 +513,18 @@ static int cxacru_cm(struct cxacru_data *instance, enum cxacru_cm_request cm,
 	if (ret < 0) {
 		usb_err(instance->usbatm, "submit of write urb for cm %#x failed (%d)\n",
 			cm, ret);
-		ret = ret;
 		goto fail;
 	}
 
 	ret = cxacru_start_wait_urb(instance->snd_urb, &instance->snd_done, NULL);
 	if (ret < 0) {
 		usb_err(instance->usbatm, "send of cm %#x failed (%d)\n", cm, ret);
-		ret = ret;
 		goto fail;
 	}
 
 	ret = cxacru_start_wait_urb(instance->rcv_urb, &instance->rcv_done, &actlen);
 	if (ret < 0) {
 		usb_err(instance->usbatm, "receive of cm %#x failed (%d)\n", cm, ret);
-		ret = ret;
 		goto fail;
 	}
 	if (actlen % CMD_PACKET_SIZE || !actlen) {
-- 
1.5.0.1

-- 
Simon Arlott
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 1/2] cxacru: Use appropriate logging for errors, Simon Arlott, (Sun Sep 23, 11:32 am)
Re: [PATCH 1/2] cxacru: Use appropriate logging for errors, Duncan Sands, (Sun Sep 23, 12:17 pm)
[PATCH 1/2 (v2)] cxacru: Use appropriate logging for errors, Simon Arlott, (Sun Sep 23, 2:44 pm)
Re: [PATCH 1/2 (v2)] cxacru: Use appropriate logging for err..., Duncan Sands, (Sun Sep 23, 3:26 pm)
Re: [PATCH 3/3] cxacru: Cleanup code by removing "ret = ret;..., Simon Arlott, (Sun Sep 23, 11:36 am)
Re: [PATCH 3/3] cxacru: Cleanup code by removing "ret = ret;..., Duncan Sands, (Sun Sep 23, 12:20 pm)
Re: [PATCH 3/3] cxacru: Cleanup code by removing "ret = ret;..., Simon Arlott, (Sun Sep 23, 2:36 pm)
Re: [PATCH 3/3] cxacru: Cleanup code by removing "ret = ret;..., Greg KH, (Mon Sep 24, 2:32 pm)
[PATCH] cxacru: Use appropriate logging for errors, Simon Arlott, (Tue Sep 25, 3:20 pm)
[PATCH 2/3] cxacru: Reduce initialisation delay, Simon Arlott, (Sun Sep 23, 11:34 am)
Re: [PATCH 2/3] cxacru: Reduce initialisation delay, Duncan Sands, (Sun Sep 23, 12:23 pm)
Re: [PATCH 2/3] cxacru: Reduce initialisation delay, Simon Arlott, (Sun Sep 23, 2:33 pm)