Home » Mailing list archives » linux-kernel » 2007 » September » 21

[PATCH] [15/50] x86_64: Return EINVAL for unknown address in change_page_attr

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Andi Kleen
Subject: [PATCH] [15/50] x86_64: Return EINVAL for unknown address in change_page_attr
Date: Friday, September 21, 2007 - 3:32 pm

Matches what i386 does and makes more sense.

Signed-off-by: Andi Kleen <ak@suse.de>

---
 arch/x86_64/mm/pageattr.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Index: linux/arch/x86_64/mm/pageattr.c
===================================================================
--- linux.orig/arch/x86_64/mm/pageattr.c
+++ linux/arch/x86_64/mm/pageattr.c
@@ -151,7 +151,9 @@ __change_page_attr(unsigned long address
 	pgprot_t ref_prot2;
 
 	kpte = lookup_address(address);
-	if (!kpte) return 0;
+	if (!kpte)
+		return -EINVAL;
+
 	kpte_page = virt_to_page(((unsigned long)kpte) & PAGE_MASK);
 	BUG_ON(PageCompound(kpte_page));
 	BUG_ON(PageLRU(kpte_page));
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] [0/50] x86 2.6.24 patches review II, Andi Kleen, (Fri Sep 21, 3:31 pm)
[PATCH] [1/50] x86_64: store core id bits in cpuinfo_x8, Andi Kleen, (Fri Sep 21, 3:31 pm)
[PATCH] [2/50] x86_64: use core id bits for apicid_to_node ..., Andi Kleen, (Fri Sep 21, 3:31 pm)
[PATCH] [3/50] x86_64: remove never used apic_mapped, Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [4/50] x86: add cpu codenames for Kconfig.cpu, Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [5/50] i386: change order in Kconfig.cpu, Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [6/50] i386: clean up oops/bug reports, Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [7/50] x86: expand /proc/interrupts to include mis ..., Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [8/50] x86_64: remove x86_cpu_to_log_apicid, Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [9/50] i386: validate against ACPI motherboard res ..., Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [10/50] x86_64: install unstripped copies of compa ..., Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [11/50] x86_64: Install unstripped copy of 64bit v ..., Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [12/50] x86_64: Untable __init references between ..., Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [13/50] x86: Fix and reenable CLFLUSH support in c ..., Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [14/50] x86: Minor code-style cleanups to change_p ..., Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [15/50] x86_64: Return EINVAL for unknown address ..., Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [16/50] x86: Use macros to modify the PG_arch_1 pa ..., Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [17/50] x86_64: remove STR() macros, Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [18/50] x86_64: Save registers in saved_context du ..., Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [19/50] Experimental: detect if SVM is disabled by ..., Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [20/50] x86_64: Fix some broken white space in arc ..., Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [21/50] i386: Misc cpuinit annotations, Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [22/50] i386: Misc cpuinit annotations, Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [23/50] x86_64: Implement missing x86_64 function ..., Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [24/50] x86_64: Eliminate result signage problem i ..., Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [25/50] x86_64: Add parenthesis to IRQ vector macros, Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [26/50] i386: export i386 smp_call_function_mask() ..., Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [27/50] x86_64: Remove duplicated vsyscall nsec update, Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [28/50] i386: remove stub early_printk.c, Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [29/50] x86: honor _PAGE_PSE bit on page walks, Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [30/50] x86_64: remove some dead code, Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [31/50] x86_64: honor notify_die() returning NOTIF ..., Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [32/50] x86: Show last exception from/to register ..., Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [33/50] x86: rename .i assembler includes to .h, Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [34/50] i386: Fix argument signedness warnings, Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [35/50] i386: Do cpuid_device_create() in CPU_UP_P ..., Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [36/50] x86: Use raw locks during oopses, Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [37/50] x86_64: Clean up mce= argument parsing sli ..., Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [38/50] x86_64: fix off-by-one in find_next_zero_s ..., Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [39/50] i386: fix 4 bit apicid assumption of mach- ..., Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [40/50] i386: Fix section mismatch, Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [41/50] i386: fix section mismatch warning in intel.c, Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [42/50] i386: constify wd_ops, Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [43/50] x86: multi-byte single instruction NOPs, Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [44/50] i386: Introduce &quot;used_vectors&quot; bitmap whic ..., Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [45/50] x86_64: configure HPET_EMULATE_RTC automat ..., Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [46/50] x86: also show non-zero IRQ counts for vec ..., Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [47/50] i386: avoid temporarily inconsistent pte-s, Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [48/50] x86_64: return correct error code from chi ..., Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [49/50] x86_64: Initialize 64bit registers for a.o ..., Andi Kleen, (Fri Sep 21, 3:32 pm)
[PATCH] [50/50] x86_64: Remove fpu io port resource, Andi Kleen, (Fri Sep 21, 3:32 pm)
Re: [PATCH] [6/50] i386: clean up oops/bug reports, Chuck Ebbert, (Fri Sep 21, 3:41 pm)
Re: [PATCH] [4/50] x86: add cpu codenames for Kconfig.cpu, Dave Jones, (Fri Sep 21, 3:45 pm)
Re: [PATCH] [50/50] x86_64: Remove fpu io port resource, Jeff Garzik, (Fri Sep 21, 4:00 pm)
Re: [PATCH] [4/50] x86: add cpu codenames for Kconfig.cpu, Alan Cox, (Fri Sep 21, 4:52 pm)
Killing printk calls for size (Re: [PATCH] [6/50] i386: cl ..., Oleg Verych, (Fri Sep 21, 7:51 pm)
possible corrections in the docs (Re: [PATCH] [7/50] x86: ..., Oleg Verych, (Fri Sep 21, 8:35 pm)
Re: possible corrections in the docs (Re: [PATCH] [7/50] x ..., Joe Korty, (Fri Sep 21, 8:52 pm)
Re: [PATCH] [34/50] i386: Fix argument signedness warnings, Satyam Sharma, (Fri Sep 21, 10:06 pm)
Re: [patches] [PATCH] [12/50] x86_64: Untable __init refer ..., Yinghai Lu, (Fri Sep 21, 10:37 pm)
Re: [PATCH] [13/50] x86: Fix and reenable CLFLUSH support ..., Oleg Verych, (Fri Sep 21, 10:47 pm)
Re: [PATCH] [9/50] i386: validate against ACPI motherboard ..., Yinghai Lu, (Fri Sep 21, 11:49 pm)
Re: [PATCH] [9/50] i386: validate against ACPI motherboard ..., Yinghai Lu, (Fri Sep 21, 11:56 pm)
Re: [PATCH] [4/50] x86: add cpu codenames for Kconfig.cpu, Sam Ravnborg, (Fri Sep 21, 11:57 pm)
Re: [PATCH] [19/50] Experimental: detect if SVM is disable ..., Sam Ravnborg, (Fri Sep 21, 11:59 pm)
Re: [PATCH] [19/50] Experimental: detect if SVM is disable ..., Joerg Roedel, (Sat Sep 22, 2:17 am)
Re: [PATCH] [4/50] x86: add cpu codenames for Kconfig.cpu, Jan Engelhardt, (Sat Sep 22, 2:46 am)
Re: [PATCH] [6/50] i386: clean up oops/bug reports, Jan Engelhardt, (Sat Sep 22, 2:47 am)
Re: [PATCH] [34/50] i386: Fix argument signedness warnings, Jan Engelhardt, (Sat Sep 22, 3:01 am)
Re: [PATCH] [4/50] x86: add cpu codenames for Kconfig.cpu, Dave Jones, (Sat Sep 22, 7:23 am)
Re: [PATCH] [9/50] i386: validate against ACPI motherboard ..., Robert Hancock, (Sat Sep 22, 9:28 am)
Re: [PATCH] [4/50] x86: add cpu codenames for Kconfig.cpu, Randy Dunlap, (Sat Sep 22, 10:40 am)
Re: [PATCH] [34/50] i386: Fix argument signedness warnings, Randy Dunlap, (Sat Sep 22, 10:42 am)
Re: [PATCH] [4/50] x86: add cpu codenames for Kconfig.cpu, Thomas Gleixner, (Sat Sep 22, 10:50 am)
Re: [PATCH] [9/50] i386: validate against ACPI motherboard ..., Thomas Gleixner, (Sat Sep 22, 11:01 am)
Re: [PATCH] [9/50] i386: validate against ACPI motherboard ..., Robert Hancock, (Sat Sep 22, 11:42 am)
Re: [PATCH] [19/50] Experimental: detect if SVM is disable ..., Thomas Gleixner, (Sat Sep 22, 12:05 pm)
Re: [PATCH] [20/50] x86_64: Fix some broken white space in ..., Thomas Gleixner, (Sat Sep 22, 12:17 pm)
Re: [PATCH] [31/50] x86_64: honor notify_die() returning N ..., Thomas Gleixner, (Sat Sep 22, 12:23 pm)
Re: [PATCH] [35/50] i386: Do cpuid_device_create() in CPU_ ..., Thomas Gleixner, (Sat Sep 22, 12:33 pm)
Re: [PATCH] [9/50] i386: validate against ACPI motherboard ..., Yinghai Lu, (Sat Sep 22, 1:40 pm)
Re: [PATCH] [9/50] i386: validate against ACPI motherboard ..., Yinghai Lu, (Sat Sep 22, 1:47 pm)
Re: [PATCH] [9/50] i386: validate against ACPI motherboard ..., H. Peter Anvin, (Sat Sep 22, 1:56 pm)
Re: [PATCH] [9/50] i386: validate against ACPI motherboard ..., Robert Hancock, (Sat Sep 22, 2:27 pm)
Re: [PATCH] [9/50] i386: validate against ACPI motherboard ..., Yinghai Lu, (Sat Sep 22, 6:20 pm)
Re: [PATCH] [9/50] i386: validate against ACPI motherboard ..., Yinghai Lu, (Sat Sep 22, 6:34 pm)
Re: [PATCH] [20/50] x86_64: Fix some broken white space in ..., Oleg Verych, (Sat Sep 22, 6:47 pm)
Re: [PATCH] [35/50] i386: Do cpuid_device_create() in CPU_ ..., Akinobu Mita, (Sat Sep 22, 6:52 pm)
Re: [PATCH] [35/50] i386: Do cpuid_device_create() in CPU_ ..., Thomas Gleixner, (Sun Sep 23, 12:52 am)
Re: [patches] [PATCH] [13/50] x86: Fix and reenable CLFLUS ..., Jan Beulich, (Mon Sep 24, 1:23 am)
Re: [patches] [PATCH] [15/50] x86_64: Return EINVAL for un ..., Jan Beulich, (Mon Sep 24, 1:32 am)
Re: [PATCH] [4/50] x86: add cpu codenames for Kconfig.cpu, Andi Kleen, (Sun Sep 30, 3:09 am)
Re: [patches] [PATCH] [13/50] x86: Fix and reenable CLFLUS ..., Andi Kleen, (Mon Oct 1, 3:38 am)
Re: [PATCH] [50/50] x86_64: Remove fpu io port resource, Andi Kleen, (Mon Oct 1, 3:40 am)
Re: [PATCH] [13/50] x86: Fix and reenable CLFLUSH support ..., Andi Kleen, (Mon Oct 1, 3:59 am)
Re: [PATCH] [4/50] x86: add cpu codenames for Kconfig.cpu, Andi Kleen, (Mon Oct 1, 4:17 am)
Re: [PATCH] [50/50] x86_64: Remove fpu io port resource, Jeff Garzik, (Mon Oct 1, 4:30 am)
Re: [PATCH] [50/50] x86_64: Remove fpu io port resource, Andi Kleen, (Mon Oct 1, 4:48 am)
Re: [PATCH] [50/50] x86_64: Remove fpu io port resource, Jeff Garzik, (Mon Oct 1, 6:33 am)
Re: [PATCH] [50/50] x86_64: Remove fpu io port resource, Mark Lord, (Mon Oct 1, 7:16 am)
Re: [PATCH] [19/50] Experimental: detect if SVM is disable ..., Andi Kleen, (Mon Oct 1, 9:47 am)
Re: [PATCH] [19/50] Experimental: detect if SVM is disable ..., Joerg Roedel, (Mon Oct 1, 1:12 pm)
Re: [patches] [PATCH] [19/50] Experimental: detect if SVM ..., Andi Kleen, (Mon Oct 1, 2:45 pm)
Re: [patches] [PATCH] [19/50] Experimental: detect if SVM ..., Joerg Roedel, (Mon Oct 1, 3:13 pm)
Re: [PATCH] [50/50] x86_64: Remove fpu io port resource, Alan Cox, (Tue Oct 2, 7:37 am)