Re: [patch 3/5] VFS: pass open file to ->xattr()

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <adilger@...>
Cc: <miklos@...>, <hch@...>, <trond.myklebust@...>, <akpm@...>, <linux-kernel@...>, <linux-fsdevel@...>
Date: Friday, September 21, 2007 - 5:15 pm

> > What I'm saying is that read and write are _no_more_ related to the

Ah yes, but f_pos is handled entirely within the VFS.  The filesystem
has nothing to do with f_pos, and the read/write methods are passed
the offset explicitly.

So with that the read/write calls (for regular files at least) really
are not that different from fstat.


You won't get different data either (again for regular files).  Yet
passing file operations down to the filesystem implementation makes
sense even for regular files, even if for most filesystems we could
get away with a totally stateless read/write model (as some other OS's
apparently do).

What I'm arguing, is that if we pass the open file for read/write to
the filesystem for regular files, it makes _equally_ as much sense to
pass the open file for getattr/setattr/xattr operations.

Miklos
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[patch 3/5] VFS: pass open file to -&gt;xattr(), Miklos Szeredi, (Fri Sep 21, 8:23 am)
Re: [patch 3/5] VFS: pass open file to -&gt;xattr(), Andreas Dilger, (Fri Sep 21, 2:39 pm)
Re: [patch 3/5] VFS: pass open file to -&gt;xattr(), Christoph Hellwig, (Fri Sep 21, 8:43 am)
Re: [patch 3/5] VFS: pass open file to -&gt;xattr(), Miklos Szeredi, (Fri Sep 21, 9:00 am)
Re: [patch 3/5] VFS: pass open file to -&gt;xattr(), Christoph Hellwig, (Fri Sep 21, 9:06 am)
Re: [patch 3/5] VFS: pass open file to -&gt;xattr(), Miklos Szeredi, (Fri Sep 21, 9:16 am)
Re: [patch 3/5] VFS: pass open file to -&gt;xattr(), Trond Myklebust, (Fri Sep 21, 10:32 am)
Re: [patch 3/5] VFS: pass open file to -&gt;xattr(), Miklos Szeredi, (Fri Sep 21, 10:43 am)
Re: [patch 3/5] VFS: pass open file to -&gt;xattr(), Christoph Hellwig, (Fri Sep 21, 10:34 am)
Re: [patch 3/5] VFS: pass open file to -&gt;xattr(), Miklos Szeredi, (Fri Sep 21, 10:59 am)
Re: [patch 3/5] VFS: pass open file to -&gt;xattr(), Andreas Dilger, (Fri Sep 21, 2:44 pm)
Re: [patch 3/5] VFS: pass open file to ->xattr(), Miklos Szeredi, (Fri Sep 21, 5:15 pm)