Re: x86_64: potential critical issue with quicklists and page table pages

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Christoph Lameter
Date: Friday, September 21, 2007 - 12:56 pm

On Fri, 21 Sep 2007, Linus Torvalds wrote:


The quicklists have a long history and this bug has therefore also been in 
IA64 for a long time and it also likely exists on sparc64, sh and sh64. We 
need the patch that I posted to fix the other platforms. And with this fix 
there would be nothing amiss on x86_64 either.

---
 include/linux/quicklist.h |    8 --------
 1 file changed, 8 deletions(-)

Index: linux-2.6/include/linux/quicklist.h
===================================================================
--- linux-2.6.orig/include/linux/quicklist.h	2007-09-21 11:46:44.000000000 -0700
+++ linux-2.6/include/linux/quicklist.h	2007-09-21 11:55:01.000000000 -0700
@@ -56,14 +56,6 @@ static inline void __quicklist_free(int 
 	struct page *page)
 {
 	struct quicklist *q;
-	int nid = page_to_nid(page);
-
-	if (unlikely(nid != numa_node_id())) {
-		if (dtor)
-			dtor(p);
-		__free_page(page);
-		return;
-	}
 
 	q = &get_cpu_var(quicklist)[nr];
 	*(void **)p = q->page;
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
x86_64: potential critical issue with quicklists and page ..., Siddha, Suresh B, (Fri Sep 21, 11:07 am)
Re: x86_64: potential critical issue with quicklists and p ..., Christoph Lameter, (Fri Sep 21, 11:48 am)
Re: x86_64: potential critical issue with quicklists and p ..., Christoph Lameter, (Fri Sep 21, 11:50 am)
Re: x86_64: potential critical issue with quicklists and p ..., Christoph Lameter, (Fri Sep 21, 12:07 pm)
Re: x86_64: potential critical issue with quicklists and p ..., Christoph Lameter, (Fri Sep 21, 12:26 pm)
Re: x86_64: potential critical issue with quicklists and p ..., Christoph Lameter, (Fri Sep 21, 12:56 pm)
RE: x86_64: potential critical issue with quicklists and p ..., Christoph Lameter, (Fri Sep 21, 1:15 pm)
Re: x86_64: potential critical issue with quicklists and p ..., Benjamin Herrenschmidt, (Mon Sep 24, 2:27 pm)
Re: x86_64: potential critical issue with quicklists and p ..., Christoph Lameter, (Mon Sep 24, 2:42 pm)
Re: x86_64: potential critical issue with quicklists and p ..., Benjamin Herrenschmidt, (Mon Sep 24, 5:09 pm)