Re: x86_64: potential critical issue with quicklists and page table pages

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Linus Torvalds <torvalds@...>
Cc: Siddha, Suresh B <suresh.b.siddha@...>, <akpm@...>, <ak@...>, <linux-kernel@...>, <tony.luck@...>, <asit.k.mallick@...>
Date: Friday, September 21, 2007 - 3:56 pm

On Fri, 21 Sep 2007, Linus Torvalds wrote:


The quicklists have a long history and this bug has therefore also been in 
IA64 for a long time and it also likely exists on sparc64, sh and sh64. We 
need the patch that I posted to fix the other platforms. And with this fix 
there would be nothing amiss on x86_64 either.

---
 include/linux/quicklist.h |    8 --------
 1 file changed, 8 deletions(-)

Index: linux-2.6/include/linux/quicklist.h
===================================================================
--- linux-2.6.orig/include/linux/quicklist.h	2007-09-21 11:46:44.000000000 -0700
+++ linux-2.6/include/linux/quicklist.h	2007-09-21 11:55:01.000000000 -0700
@@ -56,14 +56,6 @@ static inline void __quicklist_free(int 
 	struct page *page)
 {
 	struct quicklist *q;
-	int nid = page_to_nid(page);
-
-	if (unlikely(nid != numa_node_id())) {
-		if (dtor)
-			dtor(p);
-		__free_page(page);
-		return;
-	}
 
 	q = &get_cpu_var(quicklist)[nr];
 	*(void **)p = q->page;
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: x86_64: potential critical issue with quicklists and pag..., Christoph Lameter, (Fri Sep 21, 2:48 pm)
Re: x86_64: potential critical issue with quicklists and pag..., Christoph Lameter, (Fri Sep 21, 2:50 pm)
Re: x86_64: potential critical issue with quicklists and pag..., Christoph Lameter, (Fri Sep 21, 3:07 pm)
Re: x86_64: potential critical issue with quicklists and pag..., Benjamin Herrenschmidt, (Mon Sep 24, 5:27 pm)
Re: x86_64: potential critical issue with quicklists and pag..., Christoph Lameter, (Mon Sep 24, 5:42 pm)
Re: x86_64: potential critical issue with quicklists and pag..., Benjamin Herrenschmidt, (Mon Sep 24, 8:09 pm)
Re: x86_64: potential critical issue with quicklists and pag..., Christoph Lameter, (Fri Sep 21, 3:26 pm)
Re: x86_64: potential critical issue with quicklists and pag..., Christoph Lameter, (Fri Sep 21, 3:56 pm)
RE: x86_64: potential critical issue with quicklists and pag..., Christoph Lameter, (Fri Sep 21, 4:15 pm)