Re: x86_64: potential critical issue with quicklists and page table pages

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Christoph Lameter <clameter@...>
Cc: Siddha, Suresh B <suresh.b.siddha@...>, <akpm@...>, <ak@...>, <linux-kernel@...>, <tony.luck@...>, <asit.k.mallick@...>
Date: Friday, September 21, 2007 - 3:44 pm

On Fri, 21 Sep 2007, Linus Torvalds wrote:

Side note: this would obviously require that the interfaces to the 
"quicklists" would have to be changed, and you'd have an actual head 
pointer rather than using explicitly numbered per-cpu variables, but that 
seems to be a good idea in itself.

Another option is to just not use quicklists AT ALL, but just have a 
simple list of pages that is purely internal to mmu_gather, and just teach 
pgd/pmd/pud_alloc about that list. That actually sounds like the most 
straightforward and least confusing approach. The quicklists code is 
pretty damn ugly in its mixing of "struct page" and the virtual address.

		Linus
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: x86_64: potential critical issue with quicklists and pag..., Christoph Lameter, (Fri Sep 21, 2:48 pm)
Re: x86_64: potential critical issue with quicklists and pag..., Christoph Lameter, (Fri Sep 21, 2:50 pm)
Re: x86_64: potential critical issue with quicklists and pag..., Christoph Lameter, (Fri Sep 21, 3:07 pm)
Re: x86_64: potential critical issue with quicklists and pag..., Benjamin Herrenschmidt, (Mon Sep 24, 5:27 pm)
Re: x86_64: potential critical issue with quicklists and pag..., Christoph Lameter, (Mon Sep 24, 5:42 pm)
Re: x86_64: potential critical issue with quicklists and pag..., Benjamin Herrenschmidt, (Mon Sep 24, 8:09 pm)
Re: x86_64: potential critical issue with quicklists and pag..., Christoph Lameter, (Fri Sep 21, 3:26 pm)
Re: x86_64: potential critical issue with quicklists and pag..., Christoph Lameter, (Fri Sep 21, 3:56 pm)
RE: x86_64: potential critical issue with quicklists and pag..., Christoph Lameter, (Fri Sep 21, 4:15 pm)
Re: x86_64: potential critical issue with quicklists and pag..., Linus Torvalds, (Fri Sep 21, 3:44 pm)