Redundent/missing code in dik_show_trace (arch/alpha/kernel/traps.c)

Previous thread: read_ahead_kb defaults to 0 on 2.6.9-55.0.6ELsmp by Chet Nichols III on Friday, September 21, 2007 - 3:01 pm. (1 message)

Next thread: ptep_test_and_clear_young() i386 vs. x86_64 by Slava Abramov on Friday, September 21, 2007 - 3:14 pm. (2 messages)
To: <linux-kernel@...>
Date: Friday, September 21, 2007 - 3:07 pm

Hello all,

As the title suggest.
"i" is declared as 0 and never assigned a new value.
Down the code there's an if (i>40) and a certain dangling piece of code.
I assume that I should have gotten a string length (?) from somewhere?

Am I missing something?

- Gilboa

---
static void
dik_show_trace(unsigned long *sp)
{
long i = 0;
printk("Trace:\n");
while (0x1ff8 & (unsigned long) sp) {
extern char _stext[], _etext[];
unsigned long tmp = *sp;
sp++;
if (tmp < (unsigned long) &_stext)
continue;
if (tmp >= (unsigned long) &_etext)
continue;
printk("[<%lx>]", tmp);
print_symbol(" %s", tmp);
printk("\n");
if (i > 40) {
printk(" ...");
break;
}
}
printk("\n");
}

-

Previous thread: read_ahead_kb defaults to 0 on 2.6.9-55.0.6ELsmp by Chet Nichols III on Friday, September 21, 2007 - 3:01 pm. (1 message)

Next thread: ptep_test_and_clear_young() i386 vs. x86_64 by Slava Abramov on Friday, September 21, 2007 - 3:14 pm. (2 messages)