Re: x86_64: potential critical issue with quicklists and page table pages

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Christoph Lameter <clameter@...>

Cc: Siddha, Suresh B <suresh.b.siddha@...>, <akpm@...>, <ak@...>, <linux-kernel@...>, <tony.luck@...>, <asit.k.mallick@...>

Subject: Re: x86_64: potential critical issue with quicklists and page table pages

Date: Friday, September 21, 2007 - 3:05 pm

On Fri, 21 Sep 2007, Linus Torvalds wrote:
quoted text> 
> On Fri, 21 Sep 2007, Christoph Lameter wrote:
> > 
> > The quicklists collect pages while we gather pages for TLB flushing. 
> > These pages must be kept until the actual TLB flush has occurred. The 
> > optimization of releasing off node pages early is therefore not valid.
> 
> That should be the "mmu_gather" structure, not the quicklists.

Oh, and I see what's wrong: you not only switched "free_page()" to 
"quicklist_free()", you *also* switched "tlb_remove_page()" to 
"quicklist_free()".

Ok, that commit is totally and utterly broken. Will revert.

		Linus
-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

x86_64: potential critical issue with quicklists and page ta..., Siddha, Suresh B, (Fri Sep 21, 2:07 pm)

Re: x86_64: potential critical issue with quicklists and pag..., Christoph Lameter, (Fri Sep 21, 2:48 pm)

Re: x86_64: potential critical issue with quicklists and pag..., Linus Torvalds, (Fri Sep 21, 2:48 pm)

Re: x86_64: potential critical issue with quicklists and pag..., Christoph Lameter, (Fri Sep 21, 2:50 pm)

Re: x86_64: potential critical issue with quicklists and pag..., Linus Torvalds, (Fri Sep 21, 2:55 pm)

Re: x86_64: potential critical issue with quicklists and pag..., Linus Torvalds, (Fri Sep 21, 3:05 pm)

Re: x86_64: potential critical issue with quicklists and pag..., Christoph Lameter, (Fri Sep 21, 3:07 pm)

Re: x86_64: potential critical issue with quicklists and pag..., Linus Torvalds, (Fri Sep 21, 3:21 pm)

Re: x86_64: potential critical issue with quicklists and pag..., Benjamin Herrenschmidt, (Mon Sep 24, 5:27 pm)

Re: x86_64: potential critical issue with quicklists and pag..., Christoph Lameter, (Mon Sep 24, 5:42 pm)

Re: x86_64: potential critical issue with quicklists and pag..., Benjamin Herrenschmidt, (Mon Sep 24, 8:09 pm)

Re: x86_64: potential critical issue with quicklists and pag..., Christoph Lameter, (Fri Sep 21, 3:26 pm)

Re: x86_64: potential critical issue with quicklists and pag..., Linus Torvalds, (Fri Sep 21, 3:40 pm)

Re: x86_64: potential critical issue with quicklists and pag..., Christoph Lameter, (Fri Sep 21, 3:56 pm)

RE: x86_64: potential critical issue with quicklists and pag..., Luck, Tony, (Fri Sep 21, 3:59 pm)

RE: x86_64: potential critical issue with quicklists and pag..., Christoph Lameter, (Fri Sep 21, 4:15 pm)

Re: x86_64: potential critical issue with quicklists and pag..., Linus Torvalds, (Fri Sep 21, 3:44 pm)

Re: x86_64: potential critical issue with quicklists and pag..., Andi Kleen, (Fri Sep 21, 2:18 pm)

Navigation

Popular discussions


linux-kernel:
Greg Kroah-Hartman	[PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO
Tarkan Erimer	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Amit K. Arora	[RFC] Heads up on sys_fallocate()
Bart Van Assche	Integration of SCST in the mainstream Linux kernel
git:

linux-netdev:
David Miller	[GIT]: Networking
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
David Miller	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Frans Pop	svc: failed to register lockdv1 RPC service (errno 97).
openbsd-misc:

Colocation donated by:

Online users

elinga30

Syndicate