Re: x86_64: potential critical issue with quicklists and page table pages

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Siddha, Suresh B <suresh.b.siddha@...>
Cc: <torvalds@...>, <akpm@...>, <ak@...>, <linux-kernel@...>, <tony.luck@...>, <asit.k.mallick@...>
Date: Friday, September 21, 2007 - 2:48 pm

On Fri, 21 Sep 2007, Siddha, Suresh B wrote:


Hmmm... Yes could be.


Cannot get to this page:

Not Found

The requested URL /hypermail/linux/kernel/0205.2/1254.htm was not found on 
this server.



We can remove this piece alone since it was an optimization.

---
 include/linux/quicklist.h |    7 -------
 1 file changed, 7 deletions(-)

Index: linux-2.6/include/linux/quicklist.h
===================================================================
--- linux-2.6.orig/include/linux/quicklist.h	2007-09-21 11:46:44.000000000 -0700
+++ linux-2.6/include/linux/quicklist.h	2007-09-21 11:47:01.000000000 -0700
@@ -58,13 +58,6 @@ static inline void __quicklist_free(int 
 	struct quicklist *q;
 	int nid = page_to_nid(page);
 
-	if (unlikely(nid != numa_node_id())) {
-		if (dtor)
-			dtor(p);
-		__free_page(page);
-		return;
-	}
-
 	q = &get_cpu_var(quicklist)[nr];
 	*(void **)p = q->page;
 	q->page = p;
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: x86_64: potential critical issue with quicklists and pag..., Christoph Lameter, (Fri Sep 21, 2:48 pm)
Re: x86_64: potential critical issue with quicklists and pag..., Christoph Lameter, (Fri Sep 21, 2:50 pm)
Re: x86_64: potential critical issue with quicklists and pag..., Christoph Lameter, (Fri Sep 21, 3:07 pm)
Re: x86_64: potential critical issue with quicklists and pag..., Benjamin Herrenschmidt, (Mon Sep 24, 5:27 pm)
Re: x86_64: potential critical issue with quicklists and pag..., Christoph Lameter, (Mon Sep 24, 5:42 pm)
Re: x86_64: potential critical issue with quicklists and pag..., Benjamin Herrenschmidt, (Mon Sep 24, 8:09 pm)
Re: x86_64: potential critical issue with quicklists and pag..., Christoph Lameter, (Fri Sep 21, 3:26 pm)
Re: x86_64: potential critical issue with quicklists and pag..., Christoph Lameter, (Fri Sep 21, 3:56 pm)
RE: x86_64: potential critical issue with quicklists and pag..., Christoph Lameter, (Fri Sep 21, 4:15 pm)