linux-kernel mailing list

FromSubjectsort iconDate
KAMEZAWA Hiroyuki
[RFC][PATCH] make mis-configured cpu hotplug safer
When we want to hot-add a new cpu, it should be on cpu_possible_map. On some archs, we have to specify additional_cpus= boot option. (x86_64, ia64, s390 seems to need this. others ?) If a user enable a cpu which is not counted as possible_cpu, the system will panic. This patch disables to register cpu control if cpu is not in possible_map. Works as expected on ia64/cpu-hotplug-by-ACPI case. Consideration: handling this issue in cpu_up() is an another way. Signed-off-by: KAMEZAWA Hiroyuki ...
Sep 20, 11:54 pm 2007
Casey Dahlin
[Fwd: [BUG:] forcedeth: MCP55 not allowing DHCP]
Apparently I posted this in the middle of an unrelated thread by mistake. If this is the third message you are getting in regard to this issue, sorry :( Just trying to get it in the right place. -------- Original Message -------- Subject: [BUG:] forcedeth: MCP55 not allowing DHCP Date: Tue, 11 Sep 2007 18:05:15 -0400 From: Casey Dahlin <cjdahlin@ncsu.edu> To: Linux Kernel <linux-kernel@vger.kernel.org> I have an Asus Striker Extreme motherboard with two built in MCP55 Gi...
Sep 20, 11:47 pm 2007
lepton
[PATCH RESEND] 2.6.22.6 networking [ipv4]: fix wrong destina...
Hi, This is a resend of this patch with more details. I'd like it can be accepted this time. The problem: In icmp_reply and ip_send_reply function, we now use rt->rt_src as destination to send out packets. For packets received in loopback device, this is wrong sometimes. Here is an example (NOTE: eth0 address is set to 10.10.10.1/24): #tcpdump -n -i lo icmp & [1] 3155 ... # hping3 --icmp --spoof 10.10.10.3 10.10.10.1 ... 09:53:49.508449 IP 10.10.10.3 > ...
Sep 20, 10:23 pm 2007
Joseph Fannin
[PATCH] make mv643xx_eth.c build again
The changeset to "Make NAPI polling independent of struct net_device objects" forgot to change a function prototype in mv643xx_eth.c, and also introduced a typo that caused the driver not to build. Signed-off-by: Joseph Fannin <jfannin@gmail.com> --- This is build-tested only. diff -ru linux-2.6.23-rc6-mm1.orig/drivers/net/mv643xx_eth.c linux-2.6.23-rc6-mm1/drivers/net/mv643xx_eth.c --- linux-2.6.23-rc6-mm1.orig/drivers/net/mv643xx_eth.c 2007-09-20 18:17:41.000000000 -0400 +++ linux-...
Sep 20, 10:04 pm 2007
Joseph Fannin
Re: 2.6.23-rc6-mm1
Both these patches have built and booted for me. I will send a patch for the following error separately, in what will hopefully be canonical patch submission format, in case that's of any use. -- Joseph Fannin jfannin@gmail.com -
Sep 20, 10:04 pm 2007
Dan Williams
[PATCH 2.6.23-rc7 0/3] async_tx and md-accel fixes for 2.6.23
Fix a couple bugs and provide documentation for the async_tx api. Neil, please 'ack' patch #3. git://lost.foo-projects.org/~dwillia2/git/iop async-tx-fixes-for-linus Dan Williams (3): async_tx: usage documentation and developer notes async_tx: fix dma_wait_for_async_tx raid5: fix ops_complete_biofill Documentation/crypto/async-tx-api.txt | 217 +++++++++++++++++++++++++++++++++ crypto/async_tx/async_tx.c | 12 ++- drivers/md/raid5.c | 90 ++...
Sep 20, 9:27 pm 2007
Dan Williams
[PATCH 2.6.23-rc7 3/3] raid5: fix ops_complete_biofill
ops_complete_biofill tried to avoid calling handle_stripe since all the state necessary to return read completions is available. However the process of determining whether more read requests are pending requires locking the stripe (to block add_stripe_bio from updating dev->toead). ops_complete_biofill can run in tasklet context, so rather than upgrading all the stripe locks from spin_lock to spin_lock_bh this patch just moves read completion handling back into handle_stripe. Found-by: Yuri Tik...
Sep 20, 9:27 pm 2007
Dan Williams
[PATCH 2.6.23-rc7 2/3] async_tx: fix dma_wait_for_async_tx
Fix dma_wait_for_async_tx to not loop forever in the case where a dependency chain is longer than two entries. This condition will not happen with current in-kernel drivers, but fix it for future drivers. Found-by: Saeed Bishara <saeed.bishara@gmail.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com> --- crypto/async_tx/async_tx.c | 12 ++++++++++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/crypto/async_tx/async_tx.c b/crypto/async_tx/async_tx.c in...
Sep 20, 9:27 pm 2007
Dan Williams
[PATCH 2.6.23-rc7 1/3] async_tx: usage documentation and dev...
Signed-off-by: Dan Williams <dan.j.williams@intel.com> --- Documentation/crypto/async-tx-api.txt | 217 +++++++++++++++++++++++++++++++++ 1 files changed, 217 insertions(+), 0 deletions(-) diff --git a/Documentation/crypto/async-tx-api.txt b/Documentation/crypto/async-tx-api.txt new file mode 100644 index 0000000..48d685a --- /dev/null +++ b/Documentation/crypto/async-tx-api.txt @@ -0,0 +1,217 @@ + Asynchronous Transfers/Transforms API + +1 INTRODUCTION + +2 GENEALOGY + +3 USAG...
Sep 20, 9:27 pm 2007
Randy Dunlap
Re: [PATCH 2.6.23-rc7 1/3] async_tx: usage documentation and...
Hi Dan, Looks pretty good and informative. Thanks. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -
Sep 20, 11:46 pm 2007
Chakri n
NFS on loopback locks up entire system(2.6.23-rc6)?
Hi, I am testing NFS on loopback locks up entire system with 2.6.23-rc6 kernel. I have mounted a local ext3 partition using loopback NFS (version 3) and started my test program. The test program forks 20 threads allocates 10MB for each thread, writes & reads a file on the loopback NFS mount. After running for about 5 min, I cannot even login to the machine. Commands like ps etc, hang in a live session. The machine is a DELL 1950 with 4Gig of RAM, so there is plenty of RAM & CPU to play...
Sep 20, 8:22 pm 2007
Trond Myklebust
Re: NFS on loopback locks up entire system(2.6.23-rc6)?
This is pretty much expected: the NFS server is trying to allocate memory. The VM then tries to satisfy that demand by freeing up resources from the NFS client by telling the client to write out cached pages. The client again is in a congested state in which it is waiting on the NFS server to finish writing out what it already sent. Quod Erat Deadlocked... This is why 'mount --bind' is a good idea, and 'mount -t nfs localhost:' is generally a bad one... Cheers Trond -
Sep 20, 8:43 pm 2007
Chakri n
Re: NFS on loopback locks up entire system(2.6.23-rc6)?
Thanks Trond, for clarifying this for me. I have seen similar behavior when a remote NFS server is not available. Many processes wait end up waiting in nfs_release_page. So, what will happen if the remote server is not available, nfs_release_page cannot free the memory since it waits on rpc request to complete, which never completes and processes wait in there for ever? And unfortunately in my case, I cannot use "mount --bind". I want to use the same file system from two different nodes, and I w...
Sep 20, 11:12 pm 2007
Alejandro Grady Sep 20, 1:07 pm 2007
Cliff Wickman
[PATCH][VER 4] mspec: handle shrinking virtual memory areas
Stress testing revealed the need for (yet more) revision. sorry. This is a revision of Andrew's mspec-handle-shrinking-virtual-memory-areas.patch Version 4: clear/release fetchop pages only when vma_data is no longer shared The vma_data structure may be shared by vma's from multiple tasks, with no way of knowing which areas are shared or not shared, so release/clear pages only when the refcount (of vma's) goes to zero. Diffed against 2.6.23-rc7 Signed-off-by: Cliff Wickman <cpw@sgi.com...
Sep 20, 8:00 pm 2007
Newsletter Sep 20, 4:35 pm 2007
Lee Schermerhorn
[PATCH 2.6.23-rc6-mm1] - Panic in blk_rq_map_sg() from CCISS...
PATCH 2.6.23-rc6-mm1 - Panic in blk_rq_map_sg() from CCISS driver New scatter/gather list chaining [sg_next()] treats 'page' member of struct scatterlist with low bit set [0x01] as a chain pointer to another struct scatterlist [array]. The CCISS driver request function passes an uninitialized, temporary, on-stack scatterlist array to blk_rq_map_sq(). sg_next() interprets random data on the stack as a chain pointer and eventually tries to de-reference an invalid pointer, resulting in: [<fff...
Sep 20, 5:37 pm 2007
travis
[PATCH 1/1] x86: Convert cpuinfo_x86 array to a per_cpu arra...
v2: rebasing on 2.6.23-rc6-mm1 (This resulted in one change removed and one change added.) cpu_data is currently an array defined using NR_CPUS. This means that we overallocate since we will rarely really use maximum configured cpus. When NR_CPU count is raised to 4096 the size of cpu_data becomes 3,145,728 bytes. These changes were adopted from the sparc64 (and ia64) code. An additional field was added to cpuinfo_x86 to be a non-ambiguous cpu index. This corresponds to the index into a cpum...
Sep 20, 5:30 pm 2007
travis
[PATCH 0/1] x86: Reduce Memory Usage for large CPU count sys...
v2: rebasing on 2.6.23-rc6-mm1 Analyzing various data structures when NR_CPU count is raised to 4096 shows the following arrays over 128k. If the maximum number of cpus are not installed (about 99.99% of the time), then a large percentage of this memory is wasted. -- 151289856 CALNDATA irq_desc 135530496 RMDATATA irq_cfg 3145728 CALNDATA cpu_data 2101248 BSS irq_lists 2097152 RMDATATA cpu_sibling_map 2097152 RMDATATA cpu_core_map 1575936 BSS irq_2_pi...
Sep 20, 5:30 pm 2007
Darrick J. Wong
[PATCH] mptbase: Reset ioc initiator during PCI resume
It appears that the LSI SAS 1064E chip needs to be reset after a suspend/resume cycle before the driver attempts further communications with the chip. Without this patch, resuming the chip results in this error message being printed repeatedly and no more disk I/O. mptbase: ioc0: ERROR - Invalid IOC facts reply, msgLength=0 offsetof=6! So far it seems to fix suspend/resume on all the MPT Fusion cards I have (SAS and U320 SCSI) but since I don't know the internals of that chip I can't say for sur...
Sep 20, 5:10 pm 2007
Matthew Wilcox
Don't cross the (tty) streams
Connect two machines with a serial cable. On the victim: willy@rowlf:~$ cat </dev/ttyS1 Now, let's find out which ttyS on the other machine is connected ... willy@teeth:~$ echo foo >/dev/ttyS1 -bash: echo: write error: Input/output error Oops, that's not a serial port. No output on rowlf, as expected. OK, carrying on ... willy@teeth:~$ echo bar >/dev/ttyS0 And yet on rowlf, we now see: foo bar Looks like there's an error path that doesn't throw away data on -EIO. T...
Sep 20, 5:02 pm 2007
Andreas Schwab
Re: Don't cross the (tty) streams
Read the thread starting here: <http://lists.gnu.org/archive/html/bug-bash/2007-09/msg00020.html>. Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -
Sep 20, 5:29 pm 2007
Matthew Wilcox
Re: Don't cross the (tty) streams
Thanks, Andreas. I tested it with /bin/echo instead of the built-in echo and the problem disappeared. Both machines were running bash 3.1.17(1)-release. "Not all bugs are kernel bugs" x10. -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -
Sep 20, 11:08 pm 2007
travis
[PATCH 1/1] x86: Convert cpuinfo_x86 array to a per_cpu array
cpu_data is currently an array defined using NR_CPUS. This means that we overallocate since we will rarely really use maximum configured cpus. When NR_CPU count is raised to 4096 the size of cpu_data becomes 3,145,728 bytes. These changes were adopted from the sparc64 (and ia64) code. An additional field was added to cpuinfo_x86 to be a non-ambiguous cpu index. This corresponds to the index into a cpumask_t as well as the per_cpu index. It's used in various places like show_cpuinfo(). cpu_da...
Sep 20, 4:49 pm 2007
Mike Travis
Re: [PATCH 1/1] x86: Convert cpuinfo_x86 array to a per_cpu ...
I just noticed that 2.6.23-rc6-mm1 is now available. I will rebase this patch on that version as there are some significant differences. -
Sep 20, 4:47 pm 2007
travis
[PATCH 0/1] x86: Reduce Memory Usage for large CPU count sys...
Analyzing various data structures when NR_CPU count is raised to 4096 shows the following arrays over 128k. If the maximum number of cpus are not installed (about 99.99% of the time), then a large percentage of this memory is wasted. -- 151289856 CALNDATA irq_desc 135530496 RMDATATA irq_cfg 3145728 CALNDATA cpu_data 2101248 BSS irq_lists 2097152 RMDATATA cpu_sibling_map 2097152 RMDATATA cpu_core_map 1575936 BSS irq_2_pin 1050624 BSS irq_timer...
Sep 20, 4:49 pm 2007
Cliff Wickman
[PATCH][VER 4] mspec: handle shrinking virtual memory areas
Stress testing revealed the need for more revision. This is a revision of Andrew's mspec-handle-shrinking-virtual-memory-areas.patch Version 4: clear/release fetchop pages only when vma_data is no longer shared Version 3: single thread the clearing of vma_data maddr[] Version 2: refcount maintained as atomic_t (as before the version 1 patch) The shrinking of a virtual memory area that is mmap(2)'d to a memory special file (device drivers/char/mspec.c) can cause a panic. If the mapped size o...
Sep 20, 4:33 pm 2007
Andrew Morton
Re: [PATCH][VER 4] mspec: handle shrinking virtual memory ar...
On Thu, 20 Sep 2007 15:33:34 -0500 Boy am I getting tired of this patch :( Version #3943 was just merged into mainline, so can you please prepare a diff against Linus's tree for #3944? Ta. -
Sep 20, 5:17 pm 2007
Jeff Garzik
[git patches] libata fixes
Fixes from Alan, PCI IDs from ATI/AMD. Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream-linus to receive the following updates: drivers/ata/ahci.c | 10 ++++++---- drivers/ata/libata-core.c | 4 ++++ drivers/ata/libata-sff.c | 5 ++++- 3 files changed, 14 insertions(+), 5 deletions(-) Alan Cox (2): libata: Update the blacklist with a few more devices libata-sff: Fix documentation henry ...
Sep 20, 4:15 pm 2007
Dave Hansen
[resend PATCH 03/25] give may_open() a local 'mnt' variable
First of all, this makes the structure jumping look a little bit cleaner. So, this stands alone as a tiny cleanup. But, we also need 'mnt' by itself a few more times later in this series, so this isn't _just_ a cleanup. Signed-off-by: Dave Hansen <haveblue@us.ibm.com> --- lxc-dave/fs/namei.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff -puN fs/namei.c~give-may_open-a-local-mnt-variable fs/namei.c --- lxc/fs/namei.c~give-may_open-a-local-mnt-variable 2007-09-20 1...
Sep 20, 4:03 pm 2007
Dave Hansen
[PATCH 00/25] Read-only bind mounts
This is against 2.6.23-rc6. Compared to 2.6.23-rc6-mm1, there are a few (trivial) merge conflicts with the audit git tree, and one slightly more complicated one with ext2-reservations.patch. Changes from last post: - added several kerneldoc comments for exported functions - broke out the 'mnt' variable patch - removed WARN_ON() in ioctl patch The first four patches here are very simple cleanups, and can go in ahead of the rest of the patches. If you are reviewing this, the things that need ...
Sep 20, 3:52 pm 2007
Dave Hansen
[PATCH 24/25] r/o bind mounts: track number of mount writers
If we can't pull just this patch in for now, it would be great to get everything leading up to here pulled in. I've re-implemented this several ways, and it has never caused the preceeding patches to change at all. -- This is the real meat of the entire series. It actually implements the tracking of the number of writers to a mount. However, it causes scalability problems because there can be hundreds of cpus doing open()/close() on files on the same mnt at the same time. Even an atomic_t ...
Sep 20, 3:53 pm 2007
Dave Hansen
[PATCH 25/25] honor r/w changes at do_remount() time
Originally from: Herbert Poetzl <herbert@13thfloor.at> This is the core of the read-only bind mount patch set. Note that this does _not_ add a "ro" option directly to the bind mount operation. If you require such a mount, you must first do the bind, then follow it up with a 'mount -o remount,ro' operation. Signed-off-by: Dave Hansen <haveblue@us.ibm.com> --- lxc-dave/fs/namespace.c | 46 ++++++++++++++++++++++++++++++++++------- lxc-dave/include/linux/mount.h | ...
Sep 20, 3:53 pm 2007
Dave Hansen
[PATCH 23/25] do_rmdir(): elevate write count
Elevate the write count during the vfs_rmdir() call. Signed-off-by: Dave Hansen <haveblue@us.ibm.com> Acked-by: Christoph Hellwig <hch@infradead.org> --- lxc-dave/fs/namei.c | 5 +++++ 1 file changed, 5 insertions(+) diff -puN fs/namei.c~do-rmdir-elevate-write-count fs/namei.c --- lxc/fs/namei.c~do-rmdir-elevate-write-count 2007-09-20 12:16:22.000000000 -0700 +++ lxc-dave/fs/namei.c 2007-09-20 12:16:22.000000000 -0700 @@ -2148,7 +2148,12 @@ static long do_rmdir(int dfd, cons...
Sep 20, 3:53 pm 2007
Dave Hansen
[PATCH 22/25] elevate mnt writers for vfs_unlink() callers
Acked-by: Christoph Hellwig <hch@infradead.org> Signed-off-by: Dave Hansen <haveblue@us.ibm.com> --- lxc-dave/fs/namei.c | 4 ++++ lxc-dave/ipc/mqueue.c | 5 ++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff -puN fs/namei.c~elevate-mnt-writers-for-vfs-unlink-callers fs/namei.c --- lxc/fs/namei.c~elevate-mnt-writers-for-vfs-unlink-callers 2007-09-20 12:16:21.000000000 -0700 +++ lxc-dave/fs/namei.c 2007-09-20 12:16:21.000000000 -0700 @@ -2228,7 +2228,11 @@ static...
Sep 20, 3:53 pm 2007
Dave Hansen
[PATCH 21/25] sys_mknodat(): elevate write count for vfs_mkn...
This takes care of all of the direct callers of vfs_mknod(). Since a few of these cases also handle normal file creation as well, this also covers some calls to vfs_create(). So that we don't have to make three mnt_want/drop_write() calls inside of the switch statement, we move some of its logic outside of the switch. Acked-by: Christoph Hellwig <hch@infradead.org> Signed-off-by: Dave Hansen <haveblue@us.ibm.com> --- lxc-dave/fs/namei.c | 32 +++++++++++++++++++++-----...
Sep 20, 3:53 pm 2007
Dave Hansen
[PATCH 13/25] elevate mount count for extended attributes
This basically audits the callers of xattr_permission(), which calls permission() and can perform writes to the filesystem. This conflicts with the current (~2.6.23-rc7) audit git tree in -mm. wiggle'ing the patch merges it. Acked-by: Christoph Hellwig <hch@infradead.org> Signed-off-by: Dave Hansen <haveblue@us.ibm.com> --- lxc-dave/fs/nfsd/nfs4proc.c | 7 ++++++- lxc-dave/fs/xattr.c | 16 ++++++++++++++-- 2 files changed, 20 insertions(+), 3 deletions(-) diff...
Sep 20, 3:53 pm 2007
Dave Hansen
[PATCH 06/25] elevate write count open()'d files
This is the first really tricky patch in the series. It elevates the writer count on a mount each time a non-special file is opened for write. This is not completely apparent in the patch because the two if() conditions in may_open() above the mnt_want_write() call are, combined, equivalent to special_file(). There is also an elevated count around the vfs_create() call in open_namei(). The count needs to be kept elevated all the way into the may_open() call. Otherwise, when the write is d...
Sep 20, 3:52 pm 2007
Dave Hansen
[PATCH 20/25] elevate write count for do_sys_utime() and tou...
Acked-by: Christoph Hellwig <hch@infradead.org> Signed-off-by: Dave Hansen <haveblue@us.ibm.com> --- lxc-dave/fs/inode.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff -puN fs/inode.c~elevate-write-count-for-do-sys-utime-and-touch-atime fs/inode.c --- lxc/fs/inode.c~elevate-write-count-for-do-sys-utime-and-touch-atime 2007-09-20 12:16:20.000000000 -0700 +++ lxc-dave/fs/inode.c 2007-09-20 12:16:20.000000000 -0700 @@ -1176,22 +1176,23 @@ void to...
Sep 20, 3:53 pm 2007
Dave Hansen
[PATCH 19/25] elevate write count for do_utimes()
Acked-by: Christoph Hellwig <hch@infradead.org> Signed-off-by: Dave Hansen <haveblue@us.ibm.com> --- lxc-dave/fs/utimes.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff -puN fs/utimes.c~elevate-write-count-for-do-utimes fs/utimes.c --- lxc/fs/utimes.c~elevate-write-count-for-do-utimes 2007-09-20 12:16:20.000000000 -0700 +++ lxc-dave/fs/utimes.c 2007-09-20 12:16:20.000000000 -0700 @@ -2,6 +2,7 @@ #include <linux/file.h> #include <linux/f...
Sep 20, 3:53 pm 2007
Dave Hansen
[PATCH 18/25] elevate writer count for do_sys_truncate()
Acked-by: Christoph Hellwig <hch@infradead.org> Signed-off-by: Dave Hansen <haveblue@us.ibm.com> --- lxc-dave/fs/open.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff -puN fs/open.c~elevate-writer-count-for-do-sys-truncate fs/open.c --- lxc/fs/open.c~elevate-writer-count-for-do-sys-truncate 2007-09-20 12:16:19.000000000 -0700 +++ lxc-dave/fs/open.c 2007-09-20 12:16:19.000000000 -0700 @@ -244,21 +244,21 @@ static long do_sys_truncate(const char _ i...
Sep 20, 3:53 pm 2007
Dave Hansen
[PATCH 14/25] elevate write count for file_update_time()
Signed-off-by: Dave Hansen <haveblue@us.ibm.com> Acked-by: Christoph Hellwig <hch@infradead.org> --- lxc-dave/fs/inode.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff -puN fs/inode.c~elevate-write-count-for-file_update_time fs/inode.c --- lxc/fs/inode.c~elevate-write-count-for-file_update_time 2007-09-20 12:16:16.000000000 -0700 +++ lxc-dave/fs/inode.c 2007-09-20 12:16:16.000000000 -0700 @@ -1232,10 +1232,19 @@ void file_update_time(struct file *file...
Sep 20, 3:53 pm 2007
Dave Hansen
[PATCH 17/25] nfs: check mnt instead of superblock directly
If we depend on the inodes for writeability, we will not catch the r/o mounts when implemented. This patches uses __mnt_want_write(). It does not guarantee that the mount will stay writeable after the check. But, this is OK for one of the checks because it is just for a printk(). The other two are probably unnecessary and duplicate existing checks in the VFS. This won't make them better checks than before, but it will make them detect r/o mounts. Acked-by: Christoph Hellwig <hch@infra...
Sep 20, 3:53 pm 2007
Dave Hansen
[PATCH 02/25] rearrange may_open() to be r/o friendly
may_open() calls vfs_permission() before it does checks for IS_RDONLY(inode). It checks _again_ inside of vfs_permission(). The check inside of vfs_permission() is going away eventually. With the mnt_want/drop_write() functions, all of the r/o checks (except for this one) are consistently done before calling permission(). Because of this, I'd like to use permission() to hold a debugging check to make sure that the mnt_want/drop_write() calls are actually being made. So, to do this: 1. remov...
Sep 20, 3:52 pm 2007
Dave Hansen
[PATCH 16/25] elevate write count over calls to vfs_rename()
This also uses the little helper in the NFS code to make an if() a little bit less ugly. We introduced the helper at the beginning of the series. Signed-off-by: Dave Hansen <haveblue@us.ibm.com> Acked-by: Christoph Hellwig <hch@infradead.org> --- lxc-dave/fs/namei.c | 4 ++++ lxc-dave/fs/nfsd/vfs.c | 15 +++++++++++---- 2 files changed, 15 insertions(+), 4 deletions(-) diff -puN fs/namei.c~elevate-write-count-over-calls-to-vfs-rename fs/namei.c --- lxc/fs/namei.c~elev...
Sep 20, 3:53 pm 2007
Dave Hansen
[PATCH 15/25] unix_find_other() elevate write count for touc...
Signed-off-by: Dave Hansen <haveblue@us.ibm.com> Acked-by: Christoph Hellwig <hch@infradead.org> --- lxc-dave/net/unix/af_unix.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff -puN net/unix/af_unix.c~unix-find-other-elevate-write-count-for-touch-atime net/unix/af_unix.c --- lxc/net/unix/af_unix.c~unix-find-other-elevate-write-count-for-touch-atime 2007-09-20 12:16:17.000000000 -0700 +++ lxc-dave/net/unix/af_unix.c 2007-09-20 12:16:17.000000000 -070...
Sep 20, 3:53 pm 2007
Dave Hansen
[PATCH 10/25] elevate mnt writers for callers of vfs_mkdir()
Pretty self-explanatory. Fits in with the rest of the series. Signed-off-by: Dave Hansen <haveblue@us.ibm.com> Acked-by: Christoph Hellwig <hch@infradead.org> --- lxc-dave/fs/namei.c | 5 +++++ lxc-dave/fs/nfsd/nfs4recover.c | 4 ++++ 2 files changed, 9 insertions(+) diff -puN fs/namei.c~elevate-mnt-writers-for-callers-of-vfs-mkdir fs/namei.c --- lxc/fs/namei.c~elevate-mnt-writers-for-callers-of-vfs-mkdir 2007-09-20 12:16:14.000000000 -0700 +++ lxc-dave/fs/nam...
Sep 20, 3:53 pm 2007
Dave Hansen
[PATCH 07/25] r/o bind mounts: elevate write count for some ...
Some ioctl()s can cause writes to the filesystem. Take these, and make them use mnt_want/drop_write() instead. We need to pass the filp one layer deeper in XFS, but somebody _just_ pulled it out in February because nobody was using it, so I don't feel guilty for adding it back. Signed-off-by: Dave Hansen <haveblue@us.ibm.com> Acked-by: Christoph Hellwig <hch@infradead.org> --- lxc-dave/fs/ext2/ioctl.c | 46 +++++++++----- lxc-dave/fs/ext3/ioctl.c | ...
Sep 20, 3:52 pm 2007
Dave Hansen
[PATCH 08/25] elevate writer count for chown and friends
chown/chmod,etc... don't call permission in the same way that the normal "open for write" calls do. They still write to the filesystem, so bump the write count during these operations. This conflicts with the current (~2.6.23-rc7) audit git tree in -mm. wiggle'ing the patch merges it. Signed-off-by: Dave Hansen <haveblue@us.ibm.com> Acked-by: Christoph Hellwig <hch@infradead.org> --- lxc-dave/fs/open.c | 39 ++++++++++++++++++++++++++++++--------- 1 file changed, 30 inser...
Sep 20, 3:52 pm 2007
Dave Hansen
[PATCH 12/25] elevate write count for link and symlink calls
Acked-by: Christoph Hellwig <hch@infradead.org> Signed-off-by: Dave Hansen <haveblue@us.ibm.com> --- lxc-dave/fs/namei.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff -puN fs/namei.c~elevate-write-count-for-link-and-symlink-calls fs/namei.c --- lxc/fs/namei.c~elevate-write-count-for-link-and-symlink-calls 2007-09-20 12:16:15.000000000 -0700 +++ lxc-dave/fs/namei.c 2007-09-20 12:16:15.000000000 -0700 @@ -2299,7 +2299,12 @@ asmlinkage long sys_symlinkat(const char if...
Sep 20, 3:53 pm 2007
previous daytodaynext day
September 19, 2007September 20, 2007September 21, 2007