Re: [PATCH 4/4] sysfs: make suicidal nodes just do it directly

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Tejun Heo <htejun@...>

To: Cornelia Huck <cornelia.huck@...>

Cc: <ebiederm@...>, <greg@...>, <stern@...>, <kay.sievers@...>, <linux-kernel@...>, <rusty@...>

Subject: Re: [PATCH 4/4] sysfs: make suicidal nodes just do it directly

Date: Thursday, September 20, 2007 - 5:43 am

Cornelia Huck wrote:
quoted text> On Thu, 20 Sep 2007 16:26:15 +0900,
> Tejun Heo <htejun@gmail.com> wrote:
> 
>> Sysfs now allows direct suicide.  Make suicidial sysfs nodes to use
>> it and remove now unncessary callback mechanism.
>>
>> Signed-off-by: Tejun Heo <htejun@gmail.com>
>> ---
>>  drivers/base/core.c         |   33 ----------------------
>>  drivers/s390/cio/ccwgroup.c |   25 +++-------------
>>  drivers/scsi/scsi_sysfs.c   |   13 +--------
>>  fs/sysfs/file.c             |   63 -------------------------------------------
>>  include/linux/device.h      |    6 ----
>>  include/linux/sysfs.h       |    9 ------
>>  6 files changed, 6 insertions(+), 143 deletions(-)
>>
> 
> Just browsing through this (I'll review and do some tests later), but
> you missed drivers/s390/cio/device.c::ccw_device_remove_disconnected().
> 
> Following (not event compile tested) patch (which is basically a revert
> of 59a8a6e227cf0bc42e5be741ebfea97c222ab9ef) should take care of it.
> 
> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>

Thanks for spotting this.  After converting ccwgroup, I thought that was
it for s390.

-- 
tejun
-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCHSET 2/4] sysfs: allow suicide, Tejun Heo, (Thu Sep 20, 3:26 am)

Re: [PATCHSET 2/4] sysfs: allow suicide, Greg KH, (Tue Sep 25, 6:02 pm)

[PATCH 4/4] sysfs: make suicidal nodes just do it directly, Tejun Heo, (Thu Sep 20, 3:26 am)

Re: [PATCH 4/4] sysfs: make suicidal nodes just do it directly, Cornelia Huck, (Fri Sep 28, 9:54 am)

Re: [PATCH 4/4] sysfs: make suicidal nodes just do it directly, Tejun Heo, (Fri Sep 28, 10:27 am)

Re: [PATCH 4/4] sysfs: make suicidal nodes just do it directly, Cornelia Huck, (Thu Sep 20, 5:24 am)

Re: [PATCH 4/4] sysfs: make suicidal nodes just do it directly, Tejun Heo, (Thu Sep 20, 5:43 am)

[PATCH 3/4] sysfs: care-free suicide for sysfs files, Tejun Heo, (Thu Sep 20, 3:26 am)

[PATCH 1/4] module: implement module_inhibit_unload(), Tejun Heo, (Thu Sep 20, 3:26 am)

Re: [PATCH 1/4] module: implement module_inhibit_unload() , Jonathan Corbet, (Mon Sep 24, 6:00 pm)

Re: [PATCH 1/4] module: implement module_inhibit_unload(), Tejun Heo, (Mon Sep 24, 7:18 pm)

Re: [PATCH 1/4] module: implement module_inhibit_unload(), Alan Stern, (Tue Sep 25, 10:24 am)

Re: [PATCH 1/4] module: implement module_inhibit_unload(), Tejun Heo, (Tue Sep 25, 10:30 am)

Re: [PATCH 1/4] module: implement module_inhibit_unload(), Alan Stern, (Tue Sep 25, 11:09 am)

Re: [PATCH 1/4] module: implement module_inhibit_unload(), Tejun Heo, (Tue Sep 25, 7:15 pm)

Re: [PATCH 1/4] module: implement module_inhibit_unload(), Alan Stern, (Wed Sep 26, 10:39 am)

Re: [PATCH 1/4] module: implement module_inhibit_unload(), Rusty Russell, (Tue Sep 25, 7:41 pm)

Re: [PATCH 1/4] module: implement module_inhibit_unload(), Tejun Heo, (Tue Sep 25, 9:42 pm)

Re: [PATCH 1/4] module: implement module_inhibit_unload(), Rusty Russell, (Mon Sep 24, 7:42 pm)

Re: [PATCH 1/4] module: implement module_inhibit_unload(), Tejun Heo, (Mon Sep 24, 9:40 pm)

Re: [PATCH 1/4] module: implement module_inhibit_unload(), Rusty Russell, (Mon Sep 24, 10:12 pm)

Re: [PATCH 1/4] module: implement module_inhibit_unload(), Tejun Heo, (Mon Sep 24, 10:39 pm)

Re: [PATCH 1/4] module: implement module_inhibit_unload(), Rusty Russell, (Mon Sep 24, 11:21 pm)

Re: [PATCH 1/4] module: implement module_inhibit_unload(), Tejun Heo, (Mon Sep 24, 11:36 pm)

Re: [PATCH 1/4] module: implement module_inhibit_unload(), Rusty Russell, (Tue Sep 25, 12:38 am)

Re: [PATCH 1/4] module: implement module_inhibit_unload(), Tejun Heo, (Tue Sep 25, 4:25 am)

Re: [PATCH 1/4] module: implement module_inhibit_unload(), Tejun Heo, (Tue Sep 25, 4:36 am)

Re: [PATCH 1/4] module: implement module_inhibit_unload(), Rusty Russell, (Tue Sep 25, 4:50 am)

Re: [PATCH 1/4] module: implement module_inhibit_unload(), Tejun Heo, (Tue Sep 25, 10:05 am)

Re: [PATCH 1/4] module: implement module_inhibit_unload(), Cornelia Huck, (Tue Sep 25, 4:01 am)

[PATCH 2/4] sysfs: make the sysfs_addrm_cxt->removed list FIFO, Tejun Heo, (Thu Sep 20, 3:26 am)

Navigation

Popular discussions


linux-kernel:
david	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg Kroah-Hartman	[PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO
Justin C. Sherrill	Mailing list archive
Ingo Molnar	[patch 08/13] syslets: x86, add move_user_context() method
git:

linux-netdev:
Steven Rostedt	Re: -rt scheduling: wakeup bug?
David Miller	[GIT]: Networking
Jarek Poplawski	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
openbsd-misc:

Colocation donated by:

Online users

Syndicate