linux-kernel mailing list

FromSubjectsort iconDate
Shahbaz Khan
Get source and destination info
Hi, I am trying to figure out what part in the kernel code is the point from where I can get source and destination ip-address, port, security labels (selinux etc) from a packet before I export it to application space for my needs. Any hints? Shaz. -
Sep 2, 7:18 pm 2007
Casey Schaufler
Re: Get source and destination info
Look into the netlabel and xfrm code. In Smack it gets dealt with in smack_lsm.c, but Smack only uses netlabel. SELinux spreads the handling into a number of files, including hooks.c, netlabel.c, xfrm.c, and ss/services.c. Casey Schaufler casey@schaufler-ca.com -
Sep 2, 7:30 pm 2007
Jeff Garzik
Re: [PATCH -mm] DC395x SCSI driver: Shut up uninitialized va...
What's important is not support lifetime, but whether or not the warning persists through version 4.1.2, 4.1.3, etc. We don't want to add markers for compiler quirks that come and go. The current markers tend to exist for a class of problems that gcc fundamentally has a tough time "seeing." Different optimizer behaviors from compiler version to compiler version are just noise[1]. Jeff [1] sometimes quite literally, in the case of compiler warnings. -
Sep 2, 4:43 pm 2007
Jesper Juhl
Re: [-mm patchset] War on warnings
Hehe, I often do it that way myself, but just edit the subject of each mail and manually put in the [PATCH XX/YY] bit. It is just that sometimes mails get lost, so it's very nice to know how many patches to expect in a series :) -- Jesper Juhl <jesper.juhl@gmail.com> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html -
Sep 2, 4:30 pm 2007
Jesper Juhl
Re: [PATCH -mm] sisusbvga: Fix bug and build warnings
Hmm, I often use pine and ^R myself without trouble - haven't upgraded to alpine yet, but something certainly is wrong. I see the badness in your mail both in the gmail web interface and kmail. So I guess it is caused on your end. -- Jesper Juhl <jesper.juhl@gmail.com> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html -
Sep 2, 4:23 pm 2007
Alistair John Strachan
Re: [PATCH -mm] sisusbvga: Fix bug and build warnings
The encoding is set to ISO-2022-JP, this is probably breaking things. -- Cheers, Alistair. 137/1 Warrender Park Road, Edinburgh, UK. -
Sep 2, 5:18 pm 2007
Satyam Sharma
Re: [PATCH -mm] sisusbvga: Fix bug and build warnings
> > > > > "Failed to find interface
Sep 2, 5:38 pm 2007
Satyam Sharma
Re: [PATCH -mm] sisusbvga: Fix bug and build warnings
OK, I've got it figured out now. What happened is this -- alpine has this nifty feature that (if not explicitly set) it will automatically adjust the content-type encoding of outgoing mails depending upon the kind of text it sees written in the mail. Now when I normally post (eg. the first mail in this set), it naturally goes out as US-ASCII. What was special about the other mails was that each contained GCC's error/warning output. And if you've noticed it produces that totally pointless special...
Sep 2, 6:27 pm 2007
Andrew
Re: Hang in 2.6.23-rc5
Confirmed, same scenario here. Here's my config (x86_64), hope it helps. I will bring up a netconsole and try and catch it the next time it happens. andrew@ziggy ~ $ cat /usr/src/linux/.config # # Automatically generated make config: don't edit # Linux kernel version: 2.6.23-rc5 # Sun Sep 2 18:00:11 2007 # CONFIG_X86_64=y CONFIG_64BIT=y CONFIG_X86=y CONFIG_GENERIC_TIME=y CONFIG_GENERIC_TIME_VSYSCALL=y CONFIG_GENERIC_CMOS_UPDATE=y CONFIG_ZONE_DMA32=y CONFIG_LOCKDEP_SUPPORT=y CONFIG_STAC...
Sep 2, 4:21 pm 2007
Sergei Shtylyov
[PATCH 2/4] hpt366: MWDMA filter for SATA cards
The Marvell bridge chips used on HighPoint SATA cards do not seem to support the MWDMA modes (at least that caould be seen in their so-called drivers :-), so the driver needs to account for this -- to achieve this: - add mdma_filter() method from the original patch by Bartlomiej Zolnierkewicz with his consent, also adding the method callout to ide_rate_filter(); - installed the method for all chips to only return empty mask if a SATA drive is detected onHPT372{AN]/374 chips... Signed-off-by...
Sep 2, 4:19 pm 2007
Sergei Shtylyov
Re: [PATCH 2/4] hpt366: MWDMA filter for SATA cards
Hello, I wrote: The patch was 4/4 of course. :-< Errr... and version shuold Aug 02 -- thought I've fixed that. :-/ MBR, Sergei -
Sep 2, 4:25 pm 2007
Satyam Sharma
[-mm patchset] War on warnings
I decided to ruin my Sunday with an utterly pointless activity -- waging war on -mm build warnings. Some of the code I touched belonged to grotty, unused, dying drivers, but still, the end result was that I can now only see 5 warnings remaining on my typical .config (those have to do with pci_{find,enable}_device deprecation and __must_check on sysfs_create_{file,link} so I'll just leave 'em for now). Some were unused variable warnings, some uninitialized (few of those real bugs, but most not), s...
Sep 2, 4:02 pm 2007
Satyam Sharma
[PATCH -mm] i386 cpuid_count: Fix argument signedness warnings
These build warnings: In file included from include/asm/thread_info.h:16, from include/linux/thread_info.h:21, from include/linux/preempt.h:9, from include/linux/spinlock.h:49, from include/linux/vmalloc.h:4, from arch/i386/boot/compressed/misc.c:14: include/asm/processor.h: In function $B!F(Jcpuid_count$B!G(J: include/asm/processor.h:615: warning: pointer targets in passing argument 1 of $B!F(Jnative_cpuid$B!G(J differ in signedness include/asm/processor.h:615: warning: pointer targets...
Sep 2, 4:24 pm 2007
Satyam Sharma
[PATCH -mm] DC395x SCSI driver: Shut up uninitialized variab...
drivers/scsi/dc395x.c: In function $B!F(Jdc395x_init_one$B!G(J: drivers/scsi/dc395x.c:4272: warning: $B!F(Jptr$B!G(J may be used uninitialized in this function has been verified to be a bogus warning. Let's shut it up. Signed-off-by: Satyam Sharma <satyam@infradead.org> --- drivers/scsi/dc395x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-2.6.23-rc4-mm1/drivers/scsi/dc395x.c~fix 2007-09-02 20:57:51.000000000 +0530 +++ linux-2.6.23-rc4-mm1/drivers/scs...
Sep 2, 4:23 pm 2007
Jeff Garzik
Re: [PATCH -mm] DC395x SCSI driver: Shut up uninitialized va...
For things like this, we need to see (perhaps a separate email in the same thread) your build details: config, arch, compiler version, etc. This warning does not appear on x86 or x86-64 here, with the current version of gcc. And I'm not so sure we want to be adding these markers for older versions of the compiler, or for what is ultimately a temporary [situation | configuration] in the grand scheme of things. I paid careful attention to my recent set of uninitialized_var() markers (now u...
Sep 2, 4:23 pm 2007
Satyam Sharma
Re: [PATCH -mm] DC395x SCSI driver: Shut up uninitialized va...
I'll post the info as a reply to the first mail in this series. I have fairly recent gcc (4.1.1) and I don't see us dropping support for it in Well, uninitialized_var() is definitely more greppable than "= 0" which code all over does all the time :-) Anyway, the point is that the warnings are bogus anyway (hence maintainers Cc:'ed so that they can confirm if I arrived at the conclusion correctly) /and/ that uninitialized_var() stands out sorely, so I don't see bugs getting "hidden" at all -- ...
Sep 2, 4:49 pm 2007
Satyam Sharma
[PATCH -mm] drivers/md/: Shut up uninitialized variable warn...
drivers/md/dm-exception-store.c: In function $B!F(Jpersistent_read_metadata$B!G(J: drivers/md/dm-exception-store.c:452: warning: $B!F(Jnew_snapshot$B!G(J may be used uninitialized in this function drivers/md/dm-ioctl.c: In function $B!F(Jctl_ioctl$B!G(J: drivers/md/dm-ioctl.c:1407: warning: $B!F(Jparam$B!G(J may be used uninitialized in this function [ For these, I'd like to especially add -- shame on you, gcc! ] drivers/md/dm-table.c: In function $B!F(Jdm_get_device$B!G(J: ...
Sep 2, 4:22 pm 2007
Jeff Garzik
Re: [PATCH -mm] drivers/md/: Shut up uninitialized variable ...
same comment as with the last uninit'd var patch: these markers should be used sparingly. Try it on multiple compiler versions, see if it's a new behavior. Quite realistically, you might actually be finding gcc bugs, implying the proper path is to file a gcc bug report (and they are _very_ diligent about handling these, its impressive) rather than to patch the Linux kernel. Overall, for any uninitialized_var() patch, we need more info on platform/compiler version/analysis methods/etc. ...
Sep 2, 4:34 pm 2007
Satyam Sharma
Re: [PATCH -mm] drivers/md/: Shut up uninitialized variable ...
Definitely -- a lot of these patches are purely a result of gcc's shoddy My experience (regarding gcc's diligence in dealing with bug reports) has been otherwise :-) Anyway, I once had a _very_ similar discussion with Andrew (regarding some other gcc bug) previously, and the (completely correct) point he made was that: firstly, there's no guarantee they'll get this sorted out asap, and even if they did, we'll still not be dropping support for older gcc versions anyway ...
Sep 2, 4:57 pm 2007
Satyam Sharma
[PATCH -mm] es18xx: Shut up uninitialized var build warning
sound/isa/es18xx.c: In function $B!F(Jsnd_es18xx_isa_probe$B!G(J: sound/isa/es18xx.c:2251: warning: $B!F(Jerr$B!G(J may be used uninitialized in this function gcc is a sad, sad compiler. This warning is bogus so let's shut it up. Signed-off-by: Satyam Sharma <satyam@infradead.org> --- sound/isa/es18xx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- linux-2.6.23-rc4-mm1/sound/isa/es18xx.c~fix 2007-09-02 21:16:54.000000000 +0530 +++ linux-2.6.23-rc4-mm1/soun...
Sep 2, 4:21 pm 2007
Rene Herman
Re: [PATCH -mm] es18xx: Shut up uninitialized var build warn...
Same situation, same comment (and same charset :-( ) as the sb16 one. Rene. -
Sep 2, 6:14 pm 2007
Satyam Sharma
[PATCH -mm] mpt fusion: Shut up uninitialized variable warni...
drivers/message/fusion/mptctl.c: In function $B!F(Jmptctl_mpt_command$B!G(J: drivers/message/fusion/mptctl.c:1764: warning: $B!F(JbufIn.len$B!G(J may be used uninitialized in this function drivers/message/fusion/mptctl.c:1765: warning: $B!F(JbufOut.len$B!G(J may be used uninitialized in this function come because gcc gets confused by some "goto" statements in above function. The warnings have been verified to be bogus, however, the function does initialize these later (after the offendi...
Sep 2, 4:20 pm 2007
Satyam Sharma
[PATCH -mm] I2O: Fix "defined but not used" build warnings
drivers/message/i2o/exec-osm.c:539: warning: $B!F(Ji2o_exec_lct_notify$B!G(J defined but not used comes when CONFIG_I2O_LCT_NOTIFY_ON_CHANGES=n, because its only callsite is #ifdef'ed as such. So let's #ifdef the function definition also. Also move the definition to before the callsite, to get rid of forward prototype. Signed-off-by: Satyam Sharma <satyam@infradead.org> --- I have no clue who owns this subsystem, and recent git history is all over the place. drivers/message/i2...
Sep 2, 4:18 pm 2007
Satyam Sharma
[PATCH -mm] drivers/mmc/core/bus.c: Fix unused var warning
drivers/mmc/core/bus.c: In function $B!F(Jmmc_bus_uevent$B!G(J: drivers/mmc/core/bus.c:77: warning: unused variable $B!F(Jlength$B!G(J drivers/mmc/core/bus.c:77: warning: unused variable $B!F(Ji$B!G(J Signed-off-by: Satyam Sharma <satyam@infradead.org> --- drivers/mmc/core/bus.c | 1 - 1 file changed, 1 deletion(-) --- linux-2.6.23-rc4-mm1/drivers/mmc/core/bus.c~fix 2007-09-02 19:18:05.000000000 +0530 +++ linux-2.6.23-rc4-mm1/drivers/mmc/core/bus.c 2007-09-02 19:18:08...
Sep 2, 4:16 pm 2007
Satyam Sharma
[PATCH -mm] sb16: Shut up uninitialized var build warning
sound/isa/sb16/sb16.c: In function $B!F(Jsnd_sb16_isa_probe$B!G(J: sound/isa/sb16/sb16.c:559: warning: $B!F(Jerr$B!G(J may be used uninitialized in this function is a bogus warning, so let's shut it up. Signed-off-by: Satyam Sharma <satyam@infradead.org> --- sound/isa/sb/sb16.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- linux-2.6.23-rc4-mm1/sound/isa/sb/sb16.c~fix 2007-09-02 21:41:51.000000000 +0530 +++ linux-2.6.23-rc4-mm1/sound/isa/sb/sb16.c 2007-09-0...
Sep 2, 4:15 pm 2007
Rene Herman
Re: [PATCH -mm] sb16: Shut up uninitialized var build warning
Blah. Your message has: Content-Type: TEXT/PLAIN; charset=iso-2022-jp This apparently is caused by a combination of GCC using groovy UTF tickmarks in its error messages when in a UTF locale and alpine believing it to be a great idea to automatically try for the "simplest" character set it can encode the content in. No idea why that means that iso-2022-jp is picked, but it is. While I could actually read the message this time you should see what iso-2022-jp does to my font. It's scary. ...
Sep 2, 6:06 pm 2007
Satyam Sharma
Re: [PATCH -mm] sb16: Shut up uninitialized var build warning
> > sound/isa/sb16/sb16.c: In function
Sep 2, 6:34 pm 2007
Satyam Sharma
[PATCH -mm] IPS SCSI driver: Check return of scsi_add_host()
drivers/scsi/ips.c: In function $B!F(Jips_register_scsi$B!G(J: drivers/scsi/ips.c:6869: warning: ignoring return value of $B!F(Jscsi_add_host$B!G(J, declared with attribute warn_unused_result scsi_add_host() is __must_check, so let's check it's return and cleanup appropriately on errors. Signed-off-by: Satyam Sharma <satyam@infradead.org> --- drivers/scsi/ips.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) --- linux-2.6.23-rc4-mm1/drivers/scsi/ips.c~fix 2...
Sep 2, 4:13 pm 2007
Jeff Garzik
Re: [PATCH -mm] IPS SCSI driver: Check return of scsi_add_ho...
ACK, as long as you add a comment to this code and the request_irq() failure code: the oldha/old irq is not restored upon failure, in this function. That is a pre-existing bug, and not your fault, but your patch "continues in the same buggy tradition" :) We should at least note the FIXME at each error handling code branch. Ideally you or somebody should do a detailed analysis to a) (preferably) get rid of the silly oldha/ double-irq-request weirdness and make it look like other drivers,...
Sep 2, 4:32 pm 2007
Satyam Sharma
Re: [PATCH -mm] IPS SCSI driver: Check return of scsi_add_ho...
> > drivers/scsi/ips.c: In function
Sep 2, 6:39 pm 2007
Jesper Juhl
Re: [PATCH -mm] IPS SCSI driver: Check return of scsi_add_ho...
[snip] This should end with a newline "\n" but I'm seeing "¥n" ... /Jesper -
Sep 2, 4:03 pm 2007
Satyam Sharma
[PATCH -mm] drivers/usb/serial/bus.c: Fix incompatible point...
drivers/usb/serial/bus.c: In function $B!F(Jusb_serial_bus_deregister$B!G(J: drivers/usb/serial/bus.c:185: warning: passing argument 1 of $B!F(Jfree_dynids$B!G(J from incompatible pointer type Above build warning comes when CONFIG_HOTPLUG=n because argument of free_dynids() in serial/bus.c is a struct usb_serial_driver, not a struct usb_driver. This is not a runtime bug, because the function is an empty stub and never dereferences the passed pointer anyway. Signed-off-by: Satyam Sharma ...
Sep 2, 4:12 pm 2007
Satyam Sharma
[PATCH -mm] net/wireless/sysfs.c: Shut up build warning
net/wireless/sysfs.c:108: warning: $B!F(Jwiphy_uevent$B!G(J defined but not used when CONFIG_HOTPLUG=n is because the only usage site of this function is #ifdef'ed as such, so let's #ifdef the definition also. Signed-off-by: Satyam Sharma <satyam@infradead.org> --- net/wireless/sysfs.c | 2 ++ 1 file changed, 2 insertions(+) --- linux-2.6.23-rc4-mm1/net/wireless/sysfs.c~fix 2007-09-02 20:06:11.000000000 +0530 +++ linux-2.6.23-rc4-mm1/net/wireless/sysfs.c 2007-09-02 20:07:01...
Sep 2, 4:11 pm 2007
Johannes Berg
Re: [PATCH -mm] net/wireless/sysfs.c: Shut up build warning
Looks good to me. The new style seems to be to do #ifdef SOMETHING code #else #define wiphy_uevent NULL #endif and then using it unconditionally, but I'm fine with both.
Sep 2, 4:24 pm 2007
Satyam Sharma
[PATCH -mm] sunrpc svc: Shut up bogus uninitialized variable...
net/sunrpc/svc.c: In function $B!F(J__svc_create_thread$B!G(J: net/sunrpc/svc.c:550: warning: $B!F(Joldmask.bits[0u]$B!G(J may be used uninitialized in this function is a bogus warning, but gcc isn't smart enough to see why. We cannot just reorganize the code in the function, because we want the set_cpus_allowed() restore to happen only after the kernel_thread() is forked. Alas, we have to use cpus_clear() to initialize oldmask instead to keep gcc happy. Also add some comments to describ...
Sep 2, 4:09 pm 2007
Satyam Sharma
[PATCH -mm] sisusbvga: Fix bug and build warnings
drivers/usb/misc/sisusbvga/sisusb.c: In function $B!F(Jusb_sisusb_init$B!G(J: drivers/usb/misc/sisusbvga/sisusb.c:3321: warning: unused variable $B!F(Jsisusb$B!G(J drivers/usb/misc/sisusbvga/sisusb.c:3320: warning: unused variable $B!F(Jretval$B!G(J are trivially solved by getting rid of the unused variables. drivers/usb/misc/sisusbvga/sisusb.c: In function $B!F(Jsisusb_open$B!G(J: drivers/usb/misc/sisusbvga/sisusb.c:2444: warning: $B!F(Jsisusb$B!G(J is used uninitialized in t...
Sep 2, 4:07 pm 2007
Jesper Juhl
Re: [PATCH -mm] sisusbvga: Fix bug and build warnings
Odd how in your patch the line ends with "¥n" but if I look in my local copy of the source tree I see "\n". -- Jesper Juhl <jesper.juhl@gmail.com> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html -
Sep 2, 4:11 pm 2007
Satyam Sharma
Re: [PATCH -mm] sisusbvga: Fix bug and build warnings
Hi Jesper, > > - dev_err(&sisusb->sisusb_dev->dev, "Failed to find interface
Sep 2, 4:32 pm 2007
Jesper Juhl
Re: [-mm patchset] War on warnings
Great work Satyam. Personally I hate all the build warnings we get and, just like you, once in a while go on a warning killing spree. It's just so much easier to spot the real problems when the build doesn't spew a ton of pointless warnings. Thank you for doing this, I hope some of your patches get merged. Btw; it would be easier to see if one has got all the patches if you numbered your patch series with the usual "[PATCH XX/YY]". -- Jesper Juhl <jesper.juhl@gmail.com> Don't top-...
Sep 2, 4:04 pm 2007
Satyam Sharma
Re: [-mm patchset] War on warnings
Hey, thanks ;-) There are 13 in all, I just felt lazy and simply used ^R from alpine in-reply-to the first mail one-after-another instead of scripting it ... -
Sep 2, 4:39 pm 2007
Sergei Shtylyov
[PATCH 3/4] ide: make ide_rate_filter() also respect PIO and...
Make ide_rate_filter() also respect PIO/SWDMA/MWDMA mode masks. While at it, make the udma_filter() method calls take precedence over using the mode masks. Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> --- Alas, the previous version of the patch wasn't even worth signing it off -- the code had to be much trickier. The patch against the current Linus' tree and unfortunately I was able to only compile test it since that tree gives MODPOST warning and dies early on bootup. I'm hopi...
Sep 2, 3:44 pm 2007
Sergei Shtylyov
[PATCH 3/4] ide: make ide_rate_filter() also respect PIO and...
Make ide_rate_filter() also respect PIO/SWDMA/MWDMA mode masks. While at it, make the udma_filter() method calls take precedence over using the mode masks. --- This version doesn't use explicit UltraDMA masks, so converting them to the ATA_UDMA* is left for another, global patch. This patch against the current Linus' tree and unfortunately I was able to only compile test it since that tree gives MODPOST warning and dies early on bootup. drivers/ide/ide-dma.c | 7 +++-- drivers/ide/ide-lib....
Sep 2, 3:06 pm 2007
Sergei Shtylyov
Re: [PATCH 3/4] ide: make ide_rate_filter() also respect PIO...
This is still so. I'll try to test it whenever I have enought time... MBR, Sergei -
Sep 2, 3:11 pm 2007
Florian Lohoff
BUG: scheduling while atomic: ifconfig/0x00000002/4170
Hi, with current git i got this when "ifconfig eth1" down. eth1 had a mac address which looked really like an eth1394 ethernet although the module was not loaded. Something is really broken in 2.6.23-currentgit. I always g= et the sysfs rename issues which are discussed to be an udev issue. Then i see a eth1394 mac address on an interface which typically shouldn exist (udev should rename the wireless to eth1) and when issueing an ifconfig eth1 down i get a=20 BUG: scheduling while atomic: ifco...
Sep 2, 2:44 pm 2007
Michal Piotrowski
Re: BUG: scheduling while atomic: ifconfig/0x00000002/4170
Hi, [Adding netdev and wireless to CC] Regards, Michal -- LOG http://www.stardust.webpages.pl/log/ -
Sep 2, 7:59 pm 2007
daryll q
Hang in 2.6.23-rc5
Upgraded my kernel from 2.6.23-rc2 to 2.6.23-rc5. System hangs (caps lock and scroll lock leds are both flashing). It *randomly* happens but most of the time during after login to KDE. I have not investigated it yet because I have not tried doing it before. Also the system is really not responding so I can't do much.. Just hope it blue screen so I can send the error code easily :) Just CC me bec I'm not subscribed. Regards, _______________________________...
Sep 2, 2:42 pm 2007
charles gagalac
Re: Hang in 2.6.23-rc5
i experienced hangs, with the flashing caps and scroll locks as you've described, in a few of my later pulls prior to rc5. i couldn't reproduce the hangs and my logs didn't show evidence of a problem. my system under rc5, so far, hasn't hung on me. charles -
Sep 2, 3:05 pm 2007
Alessandro Suardi
Re: Hang in 2.6.23-rc5
Oh, I thought I was the only one. I also had a single hang+flashing Caps & Scroll Lock with -rc5, but haven't had one since. I had VMWare Player modules loaded at the time though, and I recently rebuilt them with the any-any-patch-113 (earlier versions would not build with very recent kernels). -rc4-git2 and -git3 never hung even with VMWare modules loaded. So I disabled the autoload of VMWare stuff. The problem has not reproduced so far. My system is a Dell D610, running updated Fe...
Sep 2, 4:38 pm 2007
Richard Mittendorfer
Re: Hang in 2.6.23-rc5
[...] Hmm, just occured here, no chance to capture anything. Happend under some system and network load (distcc/nfs) (latest atheros/madwifi tainted however, but never had troubles). Not had much uptime with pre-5 -rc's. Anything I can help to debug this? config & dmesg & lspci: http://www.mittendorfer.com/rm/temp/info-2.6.23-rc5.txt sl, ritch -
Sep 2, 6:05 pm 2007
Jesper Juhl
Re: Hang in 2.6.23-rc5
First of all, try this patch : --- a/net/ipv4/tcp_input.c +++ b/net/ipv4/tcp_input.c @@ -560,7 +560,7 @@ static u32 tcp_rto_min(struct sock *sk)         struct dst_entry *dst = __sk_dst_get(sk);         u32 rto_min = TCP_RTO_MIN;   -       if (dst_metric_locked(dst, RTAX_RTO_MIN)) +       if (dst && dst_metric_locked(dst, RTAX_RTO_MIN))                 rto_min = dst->metrics[RTAX_RTO_MIN-1];         return rto_min;  } If t...
Sep 2, 6:14 pm 2007
previous daytodaynext day
September 1, 2007September 2, 2007September 3, 2007