Home » Mailing list archives » linux-kernel » 2007 » September » 2

[PATCH -mm] IPS SCSI driver: Check return of scsi_add_host()

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Satyam Sharma <satyam@...>
To: Linux Kernel Mailing List <linux-kernel@...>
Cc: James Bottomley <james.bottomley@...>, <aacraid@...>, <linux-scsi@...>
Subject: [PATCH -mm] IPS SCSI driver: Check return of scsi_add_host()
Date: Sunday, September 2, 2007 - 4:13 pm

drivers/scsi/ips.c: In function $B!F(Jips_register_scsi$B!G(J:
drivers/scsi/ips.c:6869:
warning: ignoring return value of $B!F(Jscsi_add_host$B!G(J, declared with attribute warn_unused_result

scsi_add_host() is __must_check, so let's check it's return and cleanup
appropriately on errors.

Signed-off-by: Satyam Sharma <satyam@infradead.org>

---

 drivers/scsi/ips.c |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

--- linux-2.6.23-rc4-mm1/drivers/scsi/ips.c~fix	2007-09-02 20:21:27.000000000 +0530
+++ linux-2.6.23-rc4-mm1/drivers/scsi/ips.c	2007-09-02 20:25:58.000000000 +0530
@@ -6866,7 +6866,12 @@ ips_register_scsi(int index)
 	sh->max_channel = ha->nbus - 1;
 	sh->can_queue = ha->max_cmds - 1;
 
-	scsi_add_host(sh, NULL);
+	if (scsi_add_host(sh, NULL)) {
+		IPS_PRINTK(KERN_WARNING, ha->pcidev, "Unable to add SCSI host\n");
+		free_irq(ha->irq, ha);
+		scsi_host_put(sh);
+		return -1;
+	}
 	scsi_scan_host(sh);
 
 	return 0;
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[-mm patchset] War on warnings, Satyam Sharma, (Sun Sep 2, 4:02 pm)
[PATCH -mm] i386 cpuid_count: Fix argument signedness warnings, Satyam Sharma, (Sun Sep 2, 4:24 pm)
[PATCH -mm] DC395x SCSI driver: Shut up uninitialized variab..., Satyam Sharma, (Sun Sep 2, 4:23 pm)
Re: [PATCH -mm] DC395x SCSI driver: Shut up uninitialized va..., Jeff Garzik, (Sun Sep 2, 4:23 pm)
Re: [PATCH -mm] DC395x SCSI driver: Shut up uninitialized va..., Satyam Sharma, (Sun Sep 2, 4:49 pm)
[PATCH -mm] drivers/md/: Shut up uninitialized variable warn..., Satyam Sharma, (Sun Sep 2, 4:22 pm)
Re: [PATCH -mm] drivers/md/: Shut up uninitialized variable ..., Jeff Garzik, (Sun Sep 2, 4:34 pm)
Re: [PATCH -mm] drivers/md/: Shut up uninitialized variable ..., Satyam Sharma, (Sun Sep 2, 4:57 pm)
[PATCH -mm] es18xx: Shut up uninitialized var build warning, Satyam Sharma, (Sun Sep 2, 4:21 pm)
Re: [PATCH -mm] es18xx: Shut up uninitialized var build warn..., Rene Herman, (Sun Sep 2, 6:14 pm)
[PATCH -mm] mpt fusion: Shut up uninitialized variable warni..., Satyam Sharma, (Sun Sep 2, 4:20 pm)
[PATCH -mm] I2O: Fix "defined but not used" build warnings, Satyam Sharma, (Sun Sep 2, 4:18 pm)
[PATCH -mm] drivers/mmc/core/bus.c: Fix unused var warning, Satyam Sharma, (Sun Sep 2, 4:16 pm)
Re: [PATCH -mm] drivers/mmc/core/bus.c: Fix unused var warning, Pierre Ossman, (Mon Sep 3, 5:04 am)
[PATCH -mm] sb16: Shut up uninitialized var build warning, Satyam Sharma, (Sun Sep 2, 4:15 pm)
Re: [PATCH -mm] sb16: Shut up uninitialized var build warning, Rene Herman, (Sun Sep 2, 6:06 pm)
Re: [PATCH -mm] sb16: Shut up uninitialized var build warning, Denys Vlasenko, (Thu Sep 20, 1:52 pm)
Re: [PATCH -mm] sb16: Shut up uninitialized var build warning, Rene Herman, (Sat Sep 22, 12:20 am)
Re: [PATCH -mm] sb16: Shut up uninitialized var build warning, Satyam Sharma, (Sun Sep 2, 6:34 pm)
[PATCH -mm] IPS SCSI driver: Check return of scsi_add_host(), Satyam Sharma, (Sun Sep 2, 4:13 pm)
Re: [PATCH -mm] IPS SCSI driver: Check return of scsi_add_ho..., Jeff Garzik, (Sun Sep 2, 4:32 pm)
Re: [PATCH -mm] IPS SCSI driver: Check return of scsi_add_ho..., Satyam Sharma, (Sun Sep 2, 6:39 pm)
Re: [PATCH -mm] IPS SCSI driver: Check return of scsi_add_ho..., Jesper Juhl, (Sun Sep 2, 4:03 pm)
[PATCH -mm] drivers/usb/serial/bus.c: Fix incompatible point..., Satyam Sharma, (Sun Sep 2, 4:12 pm)
[PATCH -mm] net/wireless/sysfs.c: Shut up build warning, Satyam Sharma, (Sun Sep 2, 4:11 pm)
Re: [PATCH -mm] net/wireless/sysfs.c: Shut up build warning, Johannes Berg, (Sun Sep 2, 4:24 pm)
[PATCH -mm] sunrpc svc: Shut up bogus uninitialized variable..., Satyam Sharma, (Sun Sep 2, 4:09 pm)
[PATCH -mm] sisusbvga: Fix bug and build warnings, Satyam Sharma, (Sun Sep 2, 4:07 pm)
patch usb-sisusbvga-fix-bug-and-build-warnings.patch added t..., , (Sun Sep 9, 5:32 pm)
Re: [PATCH -mm] sisusbvga: Fix bug and build warnings, Jesper Juhl, (Sun Sep 2, 4:11 pm)
Re: [PATCH -mm] sisusbvga: Fix bug and build warnings, Satyam Sharma, (Sun Sep 2, 4:32 pm)
Re: [-mm patchset] War on warnings, Jesper Juhl, (Sun Sep 2, 4:04 pm)
Re: [-mm patchset] War on warnings, Satyam Sharma, (Sun Sep 2, 4:39 pm)