Re: [PATCH -mm] IPS SCSI driver: Check return of scsi_add_host() | KernelTrap

Re: [PATCH -mm] IPS SCSI driver: Check return of scsi_add_host()

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Jesper Juhl <jesper.juhl@...>

To: Satyam Sharma <satyam@...>

Cc: Linux Kernel Mailing List <linux-kernel@...>, James Bottomley <james.bottomley@...>, <aacraid@...>, <linux-scsi@...>

Subject: Re: [PATCH -mm] IPS SCSI driver: Check return of scsi_add_host()

Date: Sunday, September 2, 2007 - 4:03 pm

On Sunday 02 September 2007 22:13:49 Satyam Sharma wrote:
quoted text> 
> drivers/scsi/ips.c: In function ‘ips_register_scsi’:
> drivers/scsi/ips.c:6869:
> warning: ignoring return value of ‘scsi_add_host’, declared with attribute warn_unused_result
> 
> scsi_add_host() is __must_check, so let's check it's return and cleanup
> appropriately on errors.
> 
> Signed-off-by: Satyam Sharma <satyam@infradead.org>
> 
[snip]

Something seems to be wrong either at your end or mine
quoted text> +		IPS_PRINTK(KERN_WARNING, ha->pcidev, "Unable to add SCSI host¥n");

This should end with a newline  "\n"  but I'm seeing "¥n" ...


/Jesper

-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[-mm patchset] War on warnings, Satyam Sharma, (Sun Sep 2, 4:02 pm)

[PATCH -mm] i386 cpuid_count: Fix argument signedness warnings, Satyam Sharma, (Sun Sep 2, 4:24 pm)

[PATCH -mm] DC395x SCSI driver: Shut up uninitialized variab..., Satyam Sharma, (Sun Sep 2, 4:23 pm)

Re: [PATCH -mm] DC395x SCSI driver: Shut up uninitialized va..., Jeff Garzik, (Sun Sep 2, 4:23 pm)

Re: [PATCH -mm] DC395x SCSI driver: Shut up uninitialized va..., Satyam Sharma, (Sun Sep 2, 4:49 pm)

[PATCH -mm] drivers/md/: Shut up uninitialized variable warn..., Satyam Sharma, (Sun Sep 2, 4:22 pm)

Re: [PATCH -mm] drivers/md/: Shut up uninitialized variable ..., Jeff Garzik, (Sun Sep 2, 4:34 pm)

Re: [PATCH -mm] drivers/md/: Shut up uninitialized variable ..., Satyam Sharma, (Sun Sep 2, 4:57 pm)

[PATCH -mm] es18xx: Shut up uninitialized var build warning, Satyam Sharma, (Sun Sep 2, 4:21 pm)

Re: [PATCH -mm] es18xx: Shut up uninitialized var build warn..., Rene Herman, (Sun Sep 2, 6:14 pm)

[PATCH -mm] mpt fusion: Shut up uninitialized variable warni..., Satyam Sharma, (Sun Sep 2, 4:20 pm)

[PATCH -mm] I2O: Fix "defined but not used" build warnings, Satyam Sharma, (Sun Sep 2, 4:18 pm)

[PATCH -mm] drivers/mmc/core/bus.c: Fix unused var warning, Satyam Sharma, (Sun Sep 2, 4:16 pm)

Re: [PATCH -mm] drivers/mmc/core/bus.c: Fix unused var warning, Pierre Ossman, (Mon Sep 3, 5:04 am)

[PATCH -mm] sb16: Shut up uninitialized var build warning, Satyam Sharma, (Sun Sep 2, 4:15 pm)

Re: [PATCH -mm] sb16: Shut up uninitialized var build warning, Rene Herman, (Sun Sep 2, 6:06 pm)

Re: [PATCH -mm] sb16: Shut up uninitialized var build warning, Denys Vlasenko, (Thu Sep 20, 1:52 pm)

Re: [PATCH -mm] sb16: Shut up uninitialized var build warning, Rene Herman, (Sat Sep 22, 12:20 am)

Re: [PATCH -mm] sb16: Shut up uninitialized var build warning, Satyam Sharma, (Sun Sep 2, 6:34 pm)

[PATCH -mm] IPS SCSI driver: Check return of scsi_add_host(), Satyam Sharma, (Sun Sep 2, 4:13 pm)

Re: [PATCH -mm] IPS SCSI driver: Check return of scsi_add_ho..., Jeff Garzik, (Sun Sep 2, 4:32 pm)

Re: [PATCH -mm] IPS SCSI driver: Check return of scsi_add_ho..., Satyam Sharma, (Sun Sep 2, 6:39 pm)

Re: [PATCH -mm] IPS SCSI driver: Check return of scsi_add_ho..., Jesper Juhl, (Sun Sep 2, 4:03 pm)

[PATCH -mm] drivers/usb/serial/bus.c: Fix incompatible point..., Satyam Sharma, (Sun Sep 2, 4:12 pm)

[PATCH -mm] net/wireless/sysfs.c: Shut up build warning, Satyam Sharma, (Sun Sep 2, 4:11 pm)

Re: [PATCH -mm] net/wireless/sysfs.c: Shut up build warning, Johannes Berg, (Sun Sep 2, 4:24 pm)

[PATCH -mm] sunrpc svc: Shut up bogus uninitialized variable..., Satyam Sharma, (Sun Sep 2, 4:09 pm)

[PATCH -mm] sisusbvga: Fix bug and build warnings, Satyam Sharma, (Sun Sep 2, 4:07 pm)

patch usb-sisusbvga-fix-bug-and-build-warnings.patch added t..., , (Sun Sep 9, 5:32 pm)

Re: [PATCH -mm] sisusbvga: Fix bug and build warnings, Jesper Juhl, (Sun Sep 2, 4:11 pm)

Re: [PATCH -mm] sisusbvga: Fix bug and build warnings, Satyam Sharma, (Sun Sep 2, 4:32 pm)

Re: [-mm patchset] War on warnings, Jesper Juhl, (Sun Sep 2, 4:04 pm)

Re: [-mm patchset] War on warnings, Satyam Sharma, (Sun Sep 2, 4:39 pm)

Navigation

Popular discussions


linux-kernel:
Andrew Morton	-mm merge plans for 2.6.23
Greg Kroah-Hartman	[PATCH 005/196] Chinese: add translation of SubmittingDrivers
david	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Roland Dreier	Re: Integration of SCST in the mainstream Linux kernel
git:

linux-netdev:
Gerrit Renker	[PATCH 15/37] dccp: Set per-connection CCIDs via socket options
David Miller	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller	[GIT]: Networking
Jan Kara	Re: [BUG] New Kernel Bugs
openbsd-misc:

Colocation donated by:

Who's online

There are currently 2 users and 605 guests online.

Online users

Syndicate