login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2007
»
September
»
19
Re: [PATCH] Use list_first_entry in locks_wake_up_blocks
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From: J. Bruce Fields
Subject:
Re: [PATCH] Use list_first_entry in locks_wake_up_blocks
Date: Wednesday, September 19, 2007 - 12:22 pm
On Wed, Sep 19, 2007 at 04:44:07PM +0400, Pavel Emelyanov wrote:
quoted text
> This routine deletes all the elements from the list > with the "while (!list_empty())" loop, and we already > have a list_first_entry() macro to help it look nicer :)
OK. --b.
quoted text
> > Signed-off-by: Pavel Emelyanov <xemul@openvz.org> > > --- > > diff --git a/fs/locks.c b/fs/locks.c > index 746dc70..5fa072a 100644 > --- a/fs/locks.c > +++ b/fs/locks.c > @@ -534,7 +534,9 @@ static void locks_insert_block(struct fi > static void locks_wake_up_blocks(struct file_lock *blocker) > { > while (!list_empty(&blocker->fl_block)) { > - struct file_lock *waiter = list_entry(blocker->fl_block.next, > + struct file_lock *waiter; > + > + waiter = list_first_entry(&blocker->fl_block, > struct file_lock, fl_block); > __locks_delete_block(waiter); > if (waiter->fl_lmops && waiter->fl_lmops->fl_notify)
-
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[PATCH] Use list_first_entry in locks_wake_up_blocks
, Pavel Emelyanov
, (Wed Sep 19, 5:44 am)
Re: [PATCH] Use list_first_entry in locks_wake_up_blocks
, J. Bruce Fields
, (Wed Sep 19, 12:22 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Frederic Weisbecker
[PATCH v2] struct sort_entry has a callback named snprintf that turns an entry int...
FUJITA Tomonori
Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel
Andrew Morton
Re: [PATCH v3 0/4] Introduce hardware spinlock framework
Ingo Molnar
Re: [GIT PULL] time.c - respin
Alexander van Heukelum
Re: [PATCH] bitops: simplify generic bit finding functions
git
:
Mark Junker
git on MacOSX and files with decomposed utf-8 file names
Junio C Hamano
Re: git-svnimport
Johannes Schindelin
Re: [PATCH] Fix approxidate("never") to always return 0
A Large Angry SCM
Re: [RFC] origin link for cherry-pick and revert
Michal Sojka
[PATCHv5 1/2] filter-branch: Fix to allow replacing submodules with another content
git-commits-head
:
Linux Kernel Mailing List
ath9k_htc: Allocate URBs properly
Linux Kernel Mailing List
sata_mv: drop unncessary EH callback resetting
Linux Kernel Mailing List
timer: Try to survive timer callback preempt_count leak
Linux Kernel Mailing List
powerpc/kexec: Add support for FSL-BookE
Linux Kernel Mailing List
ARM: 5670/1: bcmring: add default configuration for bcmring arch
linux-netdev
:
Arnaldo Carvalho de Melo
Re: [PATCH 06/37] dccp: Limit feature negotiation to connection setup phase
Gerrit Renker
[PATCH 1/5] dccp: Initialisation framework for feature negotiation
Daniel Lezcano
getsockopt(TCP_DEFER_ACCEPT) value change
David Miller
Re: 2.6.27.18: bnx2/tg3: BUG: "scheduling while atomic" trying to ifenslave a seco...
Gerrit Renker
[PATCH 37/37] dccp: Debugging functions for feature negotiation
openbsd-misc
:
Stephen J. Bevan
GRE over IPsec
Rene Maroufi
smtpd: Aliases only work with for local alias aliases
Christophe Rioux
Implementation example of snmp
Darrin Chandler
Re: strange output on openbsd C code
Nick Holland
Re: booting openbsd on eee without cd-rom
Colocation donated by:
Syndicate