Re: 2.6.23-rc6-mm1 powerpc - kgdb is broken

Previous thread: [PATCH] Rework /proc/locks via seq_files and seq_list helpers by Pavel Emelyanov on Wednesday, September 19, 2007 - 7:35 am. (3 messages)

Next thread: LTP Latest Snapshot now available by Subrata Modak on Wednesday, September 19, 2007 - 8:36 am. (1 message)
To: <akpm@...>, <linux-kernel@...>, <amitkale@...>, <trini@...>
Date: Wednesday, September 19, 2007 - 8:23 am

Hi Andrew,

The kgdb seems to be broken on the powerpc, while compiling with
allyesconfig.

LD [M] drivers/isdn/hysdn/hysdn.o
CC [M] drivers/net/kgdboe.o
CC [M] drivers/scsi/scsi_wait_scan.o
In file included from include/linux/kgdb.h:22,
from drivers/net/kgdboe.c:28:
include/asm/kgdb.h:34: error: 'debugger' redeclared as different kind of symbol
include/asm/system.h:85: error: previous definition of 'debugger' was here
include/asm/kgdb.h:35: error: 'debugger_bpt' redeclared as different kind of symbol
include/asm/system.h:87: error: previous definition of 'debugger_bpt' was here
include/asm/kgdb.h:36: error: 'debugger_sstep' redeclared as different kind of symbol
include/asm/system.h:88: error: previous definition of 'debugger_sstep' was here
include/asm/kgdb.h:37: error: 'debugger_iabr_match' redeclared as different kind of symbol
include/asm/system.h:89: error: previous definition of 'debugger_iabr_match' was here
include/asm/kgdb.h:38: error: 'debugger_dabr_match' redeclared as different kind of symbol
include/asm/system.h:90: error: previous definition of 'debugger_dabr_match' was here
include/asm/kgdb.h:39: error: 'debugger_fault_handler' redeclared as different kind of symbol
include/asm/system.h:91: error: previous definition of 'debugger_fault_handler' was here
In file included from drivers/net/kgdboe.c:28:
include/linux/kgdb.h:69: error: 'BREAK_INSTR_SIZE' undeclared here (not in a function)
make[3]: *** [drivers/net/kgdboe.o] Error 1
make[2]: *** [drivers/net] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [drivers] Error 2
make: *** [modules] Error 2

--

Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.

-

To: Kamalesh Babulal <kamalesh@...>
Cc: <akpm@...>, <linux-kernel@...>, <amitkale@...>, <trini@...>
Date: Wednesday, September 19, 2007 - 2:53 pm

I am not exactly sure how to fix this...

Another git tree is overriding the patch to include/asm-powerpc/kgdb.h
in the -mm tree. The patches as I provide them against 2.6.23-rc6 for
KGDB work correctly for ppc/powerpc in 32 and 64 bit modes and compile
correctly.

At issue is that someone merged a bogus copy of asm-ppc/kgdb.h from the
git tree in -mm that is called: git-powerpc.patch.

Jason.

-

To: Jason Wessel <jason.wessel@...>
Cc: Kamalesh Babulal <kamalesh@...>, <linux-kernel@...>, <amitkale@...>, <trini@...>
Date: Wednesday, September 19, 2007 - 3:36 pm

Yeah, this was pointed out and largely ignored.

I'm afraid you'll have to wait until that powerpc stuff hits mainline
and then fix it all up.
-

To: Andrew Morton <akpm@...>
Cc: Jason Wessel <jason.wessel@...>, Kamalesh Babulal <kamalesh@...>, <linux-kernel@...>, <amitkale@...>, <trini@...>
Date: Thursday, September 20, 2007 - 1:23 am

I could remove all the kgdb support from arch/powerpc as a first step,
if that would make it easier to pull in the new stuff...

Paul.
-

To: Paul Mackerras <paulus@...>
Cc: Andrew Morton <akpm@...>, Jason Wessel <jason.wessel@...>, Kamalesh Babulal <kamalesh@...>, <linux-kernel@...>, <amitkale@...>, <trini@...>
Date: Thursday, September 20, 2007 - 3:38 am

Given that the existing powerpc kgdb bits didn't seem to work at all when
I tried them that seems like a perfectly fine thing to do.

-

To: Paul Mackerras <paulus@...>, <linux-kernel@...>, <amitkale@...>, <trini@...>
Cc: Andrew Morton <akpm@...>, Christoph Hellwig <hch@...>, Jason Wessel <jason.wessel@...>, Andy Whitcroft <apw@...>
Date: Friday, September 28, 2007 - 6:37 am

Hi Paul,

The kgdb is also broken with 2.6.23-rc8-mm2 on the powerpc .
The below patch disables the kgdb from getting compiled over
powerpc platform.

Signed-off-by : Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
---

--- linux-2.6.23-rc8/lib/Kconfig.kgdb 2007-09-28 06:33:37.000000000 +0530
+++ linux-2.6.23-rc8/lib/~Kconfig.kgdb 2007-09-28 23:48:33.000000000 +0530
@@ -14,7 +14,7 @@ config KGDB
bool "KGDB: kernel debugging with remote gdb"
select WANT_EXTRA_DEBUG_INFORMATION
select KGDB_ARCH_HAS_SHADOW_INFO if X86_64
- depends on DEBUG_KERNEL && (ARM || X86 || MIPS || (SUPERH && !SUPERH64) || IA64 || PPC)
+ depends on DEBUG_KERNEL && (ARM || X86 || MIPS || (SUPERH && !SUPERH64) || IA64 || !PPC)
help
If you say Y here, it will be possible to remotely debug the
kernel using gdb. Documentation of kernel debugger is available

--
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.

-

To: Kamalesh Babulal <kamalesh@...>
Cc: Paul Mackerras <paulus@...>, <linux-kernel@...>, <amitkale@...>, <trini@...>, Andrew Morton <akpm@...>, Christoph Hellwig <hch@...>, Jason Wessel <jason.wessel@...>, Andy Whitcroft <apw@...>
Date: Friday, September 28, 2007 - 6:47 am

This enables the KGDB config for _ALL_ platforms except powerpc.

Just remove PPC completely.

tglx

-

To: Paul Mackerras <paulus@...>
Cc: Thomas Gleixner <tglx@...>, <linux-kernel@...>, <amitkale@...>, <trini@...>, Andrew Morton <akpm@...>, Christoph Hellwig <hch@...>, Jason Wessel <jason.wessel@...>, Andy Whitcroft <apw@...>
Date: Friday, September 28, 2007 - 8:28 am

Thanks thomas for the suggestion, resending the patch.

Signed-off-by : Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
---

--- linux-2.6.23-rc8/lib/Kconfig.kgdb 2007-09-28 17:46:55.000000000 +0530
+++ linux-2.6.23-rc8/lib/~Kconfig.kgdb 2007-09-28 17:51:43.000000000 +0530
@@ -14,7 +14,7 @@ config KGDB
bool "KGDB: kernel debugging with remote gdb"
select WANT_EXTRA_DEBUG_INFORMATION
select KGDB_ARCH_HAS_SHADOW_INFO if X86_64
- depends on DEBUG_KERNEL && (ARM || X86 || MIPS || (SUPERH && !SUPERH64) || IA64 || PPC)
+ depends on DEBUG_KERNEL && (ARM || X86 || MIPS || (SUPERH && !SUPERH64) || IA64)
help
If you say Y here, it will be possible to remotely debug the
kernel using gdb. Documentation of kernel debugger is available

--

Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.

-

To: Paul Mackerras <paulus@...>
Cc: Jason Wessel <jason.wessel@...>, Kamalesh Babulal <kamalesh@...>, <linux-kernel@...>, <amitkale@...>, <trini@...>
Date: Thursday, September 20, 2007 - 1:53 am

I don't know if/when the new stuff will be merged - it's missed 2.6.24.

It might be better to proceed as you intended. Presumably it won't be too
hard to hack things back into shape.

-

Previous thread: [PATCH] Rework /proc/locks via seq_files and seq_list helpers by Pavel Emelyanov on Wednesday, September 19, 2007 - 7:35 am. (3 messages)

Next thread: LTP Latest Snapshot now available by Subrata Modak on Wednesday, September 19, 2007 - 8:36 am. (1 message)