[PATCH] [UFS] fs/ufs/super.c misreads the file system state

Previous thread: A little coding style nugget of joy by Matt LaPlante on Wednesday, September 19, 2007 - 12:34 pm. (8 messages)

Next thread: none
To: <linux-kernel@...>
Date: Wednesday, September 19, 2007 - 12:31 pm

ufs_get_fs_state() needs the file system type to read the state from the
correct place in the superblock. It takes the type from
UFS_SB(sb)->s_flags, but that value is stored after the first call to
ufs_get_fs_state(). The patch below moves the assignment of s_flags up,
before the first call to ufs_get_fs_state().

The patch is against linux-2.6.23-rc6-git7, but it applies (with offset)
to 2.6.22 and to earlier versions as well. It has been tested on the
Solaris flavor of UFS (ufstype=sunx86) - with this change, the file
system can be used in read-write mode.

* Please cc me when replying to this - I am not subscribed to the
linux-kernel list. *

Leonid

To: Leonid Kalev <lion@...>
Cc: Linux Kernel Mailing List <linux-kernel@...>, Andrew Morton <akpm@...>, <dushistov@...>
Date: Thursday, September 20, 2007 - 8:39 am

The same fix is already in 2.6.23-rc6-mm1 (don't know if it's lined up
for .23 though, I think it should be).

Satyam

PS: All my mails to Evgeniy Dushistov never reach him. The mail.ru server
is absolutely *evil* and simply rejects all mails unless the sender
is already whitelisted by the reciever (!)
-

Previous thread: A little coding style nugget of joy by Matt LaPlante on Wednesday, September 19, 2007 - 12:34 pm. (8 messages)

Next thread: none