Cc: Luis R. Rodriguez <mcgrof@...>, Alan Cox <alan@...>, linux-kernel <linux-kernel@...>, John W. Linville <linville@...>, linux-wireless <linux-wireless@...>
Side note: just allowing readl/writel on the iomap'ed pointers obviously
avoids that proliferation, but iomap really is architecture-specific, so
not only will different architectures act very differently, it's not
necessarily the case that iomap() will always have the same pointer as the
old ioremap(), even though the routines in the *default* implementation in
lib/iomap.c do that.
In fact, for IO port accesses, we already do some debugging to make sure
that people don't misuse the iomap() interfaces (ie the whole "Bad IO
access.." thing). I could well see the same thing happening for MMIO under
some debugging option, explicitly using some high bits in a 64-bit address
as a cookie - and that would make using regular readl/writel on the cookie
just fail spectacularly.
That said, it does seem unlikely (ie if we added a cookie for MMIO
pointers, we'd probably do it *both* for iomap and for ioremap(), and
readl/writel would continue to work). So in practice the readl/writel
probably works.
Linus
-
