Re: [PATCH] JBD slab cleanups

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Christoph Hellwig <hch@...>

Cc: Badari Pulavarty <pbadari@...>, Christoph Lameter <clameter@...>, linux-fsdevel <linux-fsdevel@...>, ext4 development <linux-ext4@...>, lkml <linux-kernel@...>

Subject: Re: [PATCH] JBD slab cleanups

Date: Tuesday, September 18, 2007 - 12:35 pm

On Tue, 2007-09-18 at 10:04 +0100, Christoph Hellwig wrote:
quoted text> On Mon, Sep 17, 2007 at 03:57:31PM -0700, Mingming Cao wrote:
> > Here is the incremental small cleanup patch. 
> > 
> > Remove kamlloc usages in jbd/jbd2 and consistently use jbd_kmalloc/jbd2_malloc.
> 
> Shouldn't we kill jbd_kmalloc instead?
> 

It seems useful to me to keep jbd_kmalloc/jbd_free. They are central
places to handle memory (de)allocation(<page size) via kmalloc/kfree, so
in the future if we need to change memory allocation in jbd(e.g. not
using kmalloc or using different flag), we don't need to touch every
place in the jbd code calling jbd_kmalloc.

Regards,
Mingming

-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[31/36] Large Blocksize: Core piece, , (Tue Aug 28, 3:06 pm)

Re: [31/36] Large Blocksize: Core piece, Mingming Cao, (Wed Aug 29, 8:11 pm)

Re: [31/36] Large Blocksize: Core piece, Christoph Lameter, (Wed Aug 29, 8:12 pm)

[RFC 4/4]ext4: fix rec_len overflow with 64KB block size, Mingming Cao, (Wed Aug 29, 8:48 pm)

[RFC 3/4] ext3: fix rec_len overflow with 64KB block size, Mingming Cao, (Wed Aug 29, 8:48 pm)

[RFC 2/4]ext2: fix rec_len overflow with 64KB block size, Mingming Cao, (Wed Aug 29, 8:47 pm)

[RFC 1/4] Large Blocksize support for Ext2/3/4, Mingming Cao, (Wed Aug 29, 8:47 pm)

[PATCH 2/2] ext3: Avoid rec_len overflow with 64KB block size, Mingming Cao, (Mon Oct 1, 8:36 pm)

[PATCH 1/2] ext3: Support large blocksize up to PAGESIZE, Mingming Cao, (Mon Oct 1, 8:36 pm)

[PATCH 2/2] ext2: Avoid rec_len overflow with 64KB block size, Mingming Cao, (Mon Oct 1, 8:35 pm)

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB block..., Andrew Morton, (Thu Oct 4, 4:12 pm)

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB block..., Jan Kara, (Thu Oct 11, 7:18 am)

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB block..., Andrew Morton, (Thu Oct 18, 12:09 am)

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB block..., Mingming Cao, (Thu Oct 18, 10:05 pm)

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB block..., Christoph Lameter, (Thu Oct 18, 5:03 am)

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB block..., Andrew Morton, (Thu Oct 18, 5:11 am)

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB block..., Andrew Morton, (Thu Oct 18, 12:07 am)

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB block..., Jan Kara, (Mon Oct 8, 9:02 am)

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB block..., Andreas Dilger, (Thu Oct 4, 6:40 pm)

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB block..., Andrew Morton, (Thu Oct 4, 7:11 pm)

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB block..., Jan Kara, (Thu Oct 11, 6:30 am)

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB block..., Andrew Morton, (Thu Oct 11, 6:14 am)

[PATCH 1/2] ext2: Support large blocksize up to PAGESIZE, Mingming Cao, (Mon Oct 1, 8:35 pm)

[PATCH 2/2] ext4: Avoid rec_len overflow with 64KB block size, Mingming Cao, (Mon Oct 1, 8:35 pm)

[PATCH 1/2] ext4: Support large blocksize up to PAGESIZE, Mingming Cao, (Mon Oct 1, 8:34 pm)

Re: [RFC 1/4] Large Blocksize support for Ext2/3/4, Christoph Lameter, (Wed Aug 29, 8:59 pm)

[RFC 2/2] JBD: blocks reservation fix for large block support, Mingming Cao, (Fri Aug 31, 8:12 pm)

[RFC 1/2] JBD: slab management support for large block(>8k), Mingming Cao, (Fri Aug 31, 8:12 pm)

Re: [RFC 1/2] JBD: slab management support for large block(&..., Christoph Hellwig, (Sat Sep 1, 2:39 pm)

Re: [RFC 1/2] JBD: slab management support for large block(&..., Christoph Lameter, (Sun Sep 2, 7:40 am)

Re: [RFC 1/2] JBD: slab management support for large block(&..., Christoph Hellwig, (Sun Sep 2, 11:28 am)

Re: [RFC 1/2] JBD: slab management support for large block(&..., Christoph Lameter, (Mon Sep 3, 3:55 am)

Re: [RFC 1/2] JBD: slab management support for large block(&..., Christoph Hellwig, (Mon Sep 3, 9:40 am)

Re: [RFC 1/2] JBD: slab management support for large block(&..., Christoph Lameter, (Mon Sep 3, 3:31 pm)

Re: [RFC 1/2] JBD: slab management support for large block(&..., Christoph Hellwig, (Mon Sep 3, 3:33 pm)

[PATCH] JBD slab cleanups, Mingming Cao, (Fri Sep 14, 2:53 pm)

Re: [PATCH] JBD slab cleanups, Mingming Cao, (Mon Sep 17, 3:29 pm)

Re: [PATCH] JBD slab cleanups, Badari Pulavarty, (Mon Sep 17, 6:01 pm)

Re: [PATCH] JBD slab cleanups, Mingming Cao, (Mon Sep 17, 6:57 pm)

Re: [PATCH] JBD slab cleanups, Christoph Hellwig, (Tue Sep 18, 5:04 am)

Re: [PATCH] JBD slab cleanups, Mingming Cao, (Tue Sep 18, 12:35 pm)

Re: [PATCH] JBD slab cleanups, Dave Kleikamp, (Tue Sep 18, 2:04 pm)

Re: [PATCH] JBD slab cleanups, Mingming Cao, (Tue Sep 18, 9:00 pm)

Re: [PATCH] JBD slab cleanups, Andrew Morton, (Tue Sep 18, 10:19 pm)

Re: [PATCH] JBD slab cleanups, Mingming Cao, (Wed Sep 19, 3:15 pm)

Re: [PATCH] JBD slab cleanups, Andreas Dilger, (Wed Sep 19, 3:48 pm)

Re: [PATCH] JBD slab cleanups, Mingming Cao, (Wed Sep 19, 6:03 pm)

[PATCH] JBD/ext34 cleanups: convert to kzalloc, Mingming Cao, (Fri Sep 21, 7:13 pm)

Re: [PATCH] JBD/ext34 cleanups: convert to kzalloc, Andrew Morton, (Wed Sep 26, 3:54 pm)

Re: [PATCH] JBD/ext34 cleanups: convert to kzalloc, Mingming Cao, (Wed Sep 26, 5:05 pm)

[PATCH] JBD2/ext4 naming cleanup, Mingming Cao, (Fri Sep 21, 7:32 pm)

Re: [PATCH] JBD slab cleanups, Dave Kleikamp, (Wed Sep 19, 3:26 pm)

Re: [PATCH] JBD slab cleanups, Dave Kleikamp, (Wed Sep 19, 3:28 pm)

Re: [PATCH] JBD slab cleanups, Mingming Cao, (Wed Sep 19, 4:47 pm)

[PATCH] JBD: use GFP_NOFS in kmalloc, Mingming Cao, (Wed Sep 19, 3:22 pm)

Re: [PATCH] JBD: use GFP_NOFS in kmalloc, Andreas Dilger, (Thu Sep 20, 12:25 am)

Re: [PATCH] JBD: use GFP_NOFS in kmalloc, Andrew Morton, (Wed Sep 19, 5:34 pm)

Re: [PATCH] JBD: use GFP_NOFS in kmalloc, Mingming Cao, (Wed Sep 19, 5:55 pm)

Re: [PATCH] JBD slab cleanups, Christoph Hellwig, (Mon Sep 17, 3:34 pm)

Re: [PATCH] JBD slab cleanups, Christoph Lameter, (Fri Sep 14, 2:58 pm)

Re: [RFC 1/4] Large Blocksize support for Ext2/3/4, Mingming Cao, (Fri Aug 31, 8:01 pm)

Navigation

Popular discussions


linux-kernel:
jjohansen	[AppArmor 39/45] AppArmor: Profile loading and manipulation, pathname matching
Vladislav Bolkhovitin	Re: Integration of SCST in the mainstream Linux kernel
Heiko Carstens	Re: -mm merge plans for 2.6.23 -- sys_fallocate
Andrew Morton	2.6.23-rc6-mm1
git:

linux-netdev:
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Evgeniy Polyakov	Re: [BUG] New Kernel Bugs
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller	[GIT]: Networking
openbsd-misc:

Colocation donated by: