Re: Add all thread stats for TASKSTATS_CMD_ATTR_TGID (v5)

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Oleg Nesterov
Date: Tuesday, September 18, 2007 - 8:29 am

On 09/18, Guillaume Chazarain wrote:

No, no, this is wrong.

tsk->signal->stats contains the accumulated info about the already exited
threads, we shouldn't throw it out.

Also, fill_tgid() doesn't make sense here, current is the last live sub-thread.


Hmm. We have another race here. There is no guarantee that tsk->signal->stats
covers all sub-threads, as it is supposed to be. It is quite possible that
another sub-thread decremented ->signal->live before us, but didn't complete
taskstats_exit()->fill_tgid_exit() yet.

Oleg.

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] Add all thread stats for TASKSTATS_CMD_ATTR_TGID, Guillaume Chazarain, (Thu Aug 2, 6:53 am)
Re: [PATCH] Add all thread stats for TASKSTATS_CMD_ATTR_TGID, Guillaume Chazarain, (Sun Aug 19, 12:34 pm)
Re: [PATCH] Add all thread stats for TASKSTATS_CMD_ATTR_TGID, Guillaume Chazarain, (Sat Aug 25, 8:10 am)
Re: [PATCH] Add all thread stats for TASKSTATS_CMD_ATTR_TGID, Guillaume Chazarain, (Sun Aug 26, 2:44 am)
Add all thread stats for TASKSTATS_CMD_ATTR_TGID (v3), Guillaume Chazarain, (Fri Aug 31, 5:35 am)
Re: [PATCH] Add all thread stats for TASKSTATS_CMD_ATTR_TGID, Guillaume Chazarain, (Mon Sep 10, 6:03 am)
Re: Add all thread stats for TASKSTATS_CMD_ATTR_TGID (v3), Andrew Morton, (Wed Sep 12, 5:18 pm)
Add all thread stats for TASKSTATS_CMD_ATTR_TGID (v4), Guillaume Chazarain, (Sat Sep 15, 11:42 am)
Add all thread stats for TASKSTATS_CMD_ATTR_TGID (v5), Guillaume Chazarain, (Mon Sep 17, 3:23 pm)
Re: Add all thread stats for TASKSTATS_CMD_ATTR_TGID (v5), Oleg Nesterov, (Tue Sep 18, 8:29 am)
Re: Add all thread stats for TASKSTATS_CMD_ATTR_TGID (v5), Andrew Morton, (Wed Sep 19, 11:20 pm)
Re: Add all thread stats for TASKSTATS_CMD_ATTR_TGID (v5), Oleg Nesterov, (Thu Sep 20, 5:16 am)