On Tue, Sep 18, 2007 at 05:19:45PM +0900, KAMEZAWA Hiroyuki wrote:
quoted text > Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com> wrote:
> > + tg->cfs_rq = kzalloc(sizeof(cfs_rq) * num_possible_cpus(), GFP_KERNEL);
> > + if (!tg->cfs_rq)
> > + goto err;
> > + tg->se = kzalloc(sizeof(se) * num_possible_cpus(), GFP_KERNEL);
> > + if (!tg->se)
> > + goto err;
> Sorry for very lazy responce..
>
> num_possible_cpus() just returns # of possible cpus. Then it will not return
> Max-cpu-id to be used. I think just use NR_CPUS here is an easy way.
Good catch! Yes, you are right, the pointer array needs to be NR_CPUS
size.
On closer examination, I think I can simply use alloc_percpu() here.
Will send a patch after some testing.
--
Regards,
vatsa
-
unsubscribe notice To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/ Messages in current thread:
Re: [PATCH] Hookup group-scheduler with task container inf ... , Srivatsa Vaddagiri , (Tue Sep 18, 3:44 am)
