Home » Mailing list archives » linux-kernel » 2007 » September » 18

[PATCH 0/2] unify DMA_..BIT_MASK definitions: v1

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Borislav Petkov <bbpetkov@...>
To: <linux-kernel@...>
Cc: Jeremy Fitzhardinge <jeremy@...>
Subject: [PATCH 0/2] unify DMA_..BIT_MASK definitions: v1
Date: Tuesday, September 18, 2007 - 12:29 am

These patches remove redundant DMA_..BIT_MASK definitions across two drivers.
In this version of the patches, the computation of the bitmasks is done by
the compiler.

Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>

--
Index: 23-rc6/include/linux/dma-mapping.h
===================================================================
--- 23-rc6/include/linux/dma-mapping.h.orig	2007-09-17 17:48:20.000000000 +0200
+++ 23-rc6/include/linux/dma-mapping.h	2007-09-18 06:12:33.000000000 +0200
@@ -13,16 +13,19 @@
 	DMA_NONE = 3,
 };
 
-#define DMA_64BIT_MASK	0xffffffffffffffffULL
-#define DMA_48BIT_MASK	0x0000ffffffffffffULL
-#define DMA_40BIT_MASK	0x000000ffffffffffULL
-#define DMA_39BIT_MASK	0x0000007fffffffffULL
-#define DMA_32BIT_MASK	0x00000000ffffffffULL
-#define DMA_31BIT_MASK	0x000000007fffffffULL
-#define DMA_30BIT_MASK	0x000000003fffffffULL
-#define DMA_29BIT_MASK	0x000000001fffffffULL
-#define DMA_28BIT_MASK	0x000000000fffffffULL
-#define DMA_24BIT_MASK	0x0000000000ffffffULL
+#define DMA_BIT_MASK(n)	((1ULL<<(n))-1)
+
+#define DMA_64BIT_MASK	DMA_BIT_MASK(64)
+#define DMA_48BIT_MASK	DMA_BIT_MASK(48)
+#define DMA_40BIT_MASK	DMA_BIT_MASK(40)
+#define DMA_39BIT_MASK	DMA_BIT_MASK(39)
+#define DMA_35BIT_MASK	DMA_BIT_MASK(35)
+#define DMA_32BIT_MASK	DMA_BIT_MASK(32)
+#define DMA_31BIT_MASK	DMA_BIT_MASK(31)
+#define DMA_30BIT_MASK	DMA_BIT_MASK(30)
+#define DMA_29BIT_MASK	DMA_BIT_MASK(29)
+#define DMA_28BIT_MASK	DMA_BIT_MASK(28)
+#define DMA_24BIT_MASK	DMA_BIT_MASK(24)
 
 static inline int valid_dma_direction(int dma_direction)
 {

-- 
Regards/Gruß,
    Boris.
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 0/2] unify DMA_..BIT_MASK definitions: v1, Borislav Petkov, (Tue Sep 18, 12:29 am)
Re: [PATCH 0/2] unify DMA_..BIT_MASK definitions: v1, Muli Ben-Yehuda, (Tue Sep 18, 1:58 am)
Re: [PATCH 0/2] unify DMA_..BIT_MASK definitions: v1, Jeremy Fitzhardinge, (Tue Sep 18, 2:01 am)
Re: [PATCH 0/2] unify DMA_..BIT_MASK definitions: v1, Borislav Petkov, (Tue Sep 18, 2:08 am)
Re: [PATCH 0/2] unify DMA_..BIT_MASK definitions: v1, Satyam Sharma, (Tue Sep 18, 2:16 am)
Re: [PATCH 0/2] unify DMA_..BIT_MASK definitions: v1, Borislav Petkov, (Tue Sep 18, 2:34 am)