Home » Mailing list archives » linux-kernel » 2007 » September » 17

Re: [PATCH] Wake up mandatory locks waiter on chmod (v2)

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Trond Myklebust <trond.myklebust@...>
To: Pavel Emelyanov <xemul@...>
Cc: Andrew Morton <akpm@...>, J. Bruce Fields <bfields@...>, Linux Kernel Mailing List <linux-kernel@...>, <devel@...>
Subject: Re: [PATCH] Wake up mandatory locks waiter on chmod (v2)
Date: Monday, September 17, 2007 - 12:00 pm

On Mon, 2007-09-17 at 18:16 +0400, Pavel Emelyanov wrote:

Why do you think we get a deadlock or leak? AFAICS if the user turns off
mandatory locks on the file, then the existing locks default back into
advisory locks which use the same notification mechanism as the
mandatory locks.

IOW: the process that is waiting in locks_mandatory_area() will be
released as soon as the advisory lock is dropped. If that theory is
broken in practice, then that is the bug that we need to fix. We neither
want to add a load of locking crap to notify_change(), nor should we
need to.

Cheers
   Trond

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] Wake up mandatory locks waiter on chmod (v2), Pavel Emelyanov, (Mon Sep 17, 4:13 am)
Re: [PATCH] Wake up mandatory locks waiter on chmod (v2), Trond Myklebust, (Mon Sep 17, 9:55 am)
Re: [PATCH] Wake up mandatory locks waiter on chmod (v2), Pavel Emelyanov, (Mon Sep 17, 10:16 am)
Re: [PATCH] Wake up mandatory locks waiter on chmod (v2), Trond Myklebust, (Mon Sep 17, 12:00 pm)
Re: [PATCH] Wake up mandatory locks waiter on chmod (v2), Pavel Emelyanov, (Tue Sep 18, 2:33 am)
Re: [PATCH] Wake up mandatory locks waiter on chmod (v2), J. Bruce Fields, (Tue Sep 18, 11:19 am)
Re: [PATCH] Wake up mandatory locks waiter on chmod (v2), Trond Myklebust, (Tue Sep 18, 12:14 pm)
Re: [PATCH] Wake up mandatory locks waiter on chmod (v2), J. Bruce Fields, (Tue Sep 18, 12:52 pm)
Re: [PATCH] Wake up mandatory locks waiter on chmod (v2), Trond Myklebust, (Tue Sep 18, 12:54 pm)
Re: [PATCH] Wake up mandatory locks waiter on chmod (v2), J. Bruce Fields, (Tue Sep 18, 1:40 pm)
[PATCH 1/2] Documentation: move mandatory locking documentat..., J. Bruce Fields, (Tue Sep 25, 12:55 pm)
Re: [PATCH 1/2] Documentation: move mandatory locking docume..., Randy Dunlap, (Tue Sep 25, 1:12 pm)
Re: [PATCH 1/2] Documentation: move mandatory locking docume..., J. Bruce Fields, (Tue Sep 25, 1:24 pm)
[PATCH 2/2] locks: add warning about mandatory locking races, J. Bruce Fields, (Tue Sep 25, 12:56 pm)
Re: [PATCH] Wake up mandatory locks waiter on chmod (v2), Hugh Dickins, (Tue Sep 18, 2:38 pm)