linux-kernel mailing list

FromSubjectsort iconDate
Nick Piggin
Re: [PATCH 001/104] KVM: Fix *nopage() in kvm_main.c
It should be mostly possible to ifdef a nopage() handler, which is just a wrapper function to translate arguments then call your new ->fault() handler. With luck, fault would mostly inline into nopage, and do some constant folding to make it cheaper... I'm planning to go through and convert the rest of the in-tree users at some point soon, so if you do get a chance to convert your upstream code before I try, it would nice ;) Thanks, Nick -
Sep 16, 5:29 pm 2007
shinkoi2005a
printk format "%4.4s"
Hi, all I have a question about printk format. Can printk format use "%4.4s"? This format is used following source. ############# drivers/acpi/tables/tbinstal.c ACPI_ERROR((AE_INFO, "Table has invalid signature [%4.4s], must be SSDT, PSDT or OEMx", table_desc->pointer->signature)); ############## At least, my dmesg is buggy output like that.. ############## $ dmesg (snip) ACPI Warning (tbutils-0158): Incorr...
Sep 16, 8:57 pm 2007
David Miller Sep 16, 5:54 pm 2007
David Miller
Re: + pktgen-srcmac-fix.patch added to -mm tree
From: akpm@linux-foundation.org I've applied this patch to net-2.6, thanks! -
Sep 16, 5:52 pm 2007
Jesper Juhl
[PATCH] Remove an unused variable from the Intel I/OAT DMA e...
The 'u16 chanctrl' variable in drivers/dma/ioatdma.c::ioat_dma_free_chan_resources() is completely unused and gcc quite rightfully warns about it: drivers/dma/ioatdma.c:247: warning: unused variable 'chanctrl' This patch removes the unused variable and silences the warning. Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com> --- ioatdma.c | 1 - 1 file changed, 1 deletion(-) --- linux-2.6/drivers/dma/ioatdma.c~ 2007-09-16 23:24:20.000000000 +0200 +++ linux-2.6/drivers/dm...
Sep 16, 5:31 pm 2007
David Miller
Re: [PATCH] Remove an unused variable from the Intel I/OAT D...
From: Jesper Juhl <jesper.juhl@gmail.com> Applied to net-2.6.24, thanks Jesper. -
Sep 16, 5:42 pm 2007
Jesper Juhl
[PATCH] cifs: Fix a small memory leak in directory creation ...
There is a small memory leak in fs/cifs/inode.c::cifs_mkdir(). Storage for 'pInfo' is allocated with kzalloc(), but if the call to CIFSPOSIXCreate(...) happens to return 0 and pInfo->Type == -1, then we'll jump to the 'mkdir_get_info' label without freeing the storage allocated for 'pInfo'. This patch adds a kfree() call to free the storage just before jumping to the label, thus getting rid of the leak. Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com> --- inode.c | 4 +++...
Sep 16, 5:15 pm 2007
Francis Moreau
x86_64: vsyscall vs vdso
Hello, I'm a bit puzzled because vdso doesn't seem to be used on my fedora 7: I just compiled a trivial program which just call gettimeofday() and ld.so resolves this call with vsyscall's gettimeofday. Now I'm wondering when vdso is used, could anybody give me a clue ? Another question: is vdso going to replace vsyscall at all ? If so how are statically programs going to be handled ? Thanks, -- Francis -
Sep 16, 4:24 pm 2007
Ulrich Drepper
Re: x86_64: vsyscall vs vdso
F7 was released before the vdso for x86_64 was upstream so you should not expect anything else. F8 will use the available vdso. This Unfortunately the vsyscalls cannot ever go completely away. Statically linked apps, the bane of progress, will need them. There are also people updating kernels but not the user userland code. What we will have to do in future is to make vsyscalls configurable. Both a compile time option and a runtime option (perhaps also under control of SELinux) are likely ne...
Sep 16, 4:46 pm 2007
Satyam Sharma
iunique() fails to return ino_t (after commit 866b04fccbf125...
Hi Jeff, I think commit 866b04fccbf125cd39f2bdbcfeaa611d39a061a8 was wrong, and introduced a regression. 1. First and foremost, there was nothing wrong with the existing code that needed to be "fixed" at all, i.e. there was no "problem" to be solved in the first place. As was said, glibc *correctly* returns EOVERFLOW when a userspace application built *without* _FILE_OFFSET_BITS == 64 (i.e. ino_t != __ino64_t) tries to stat(2) a file whose serial number does not fit in the "st...
Sep 16, 3:28 pm 2007
Jeff Layton
Re: iunique() fails to return ino_t (after commit 866b04fccb...
On Mon, 17 Sep 2007 00:58:54 +0530 The ideal situation is that everyone would recompile their programs with LFS defines. Unfortunately people have old userspace programs to which they don't have sources, or that can't easily be recompiled this way. These programs would occasionally break when run on 64 bit kernels It most certainly does have something to do with 32 bit userspace on 64 bit kernels. On a 32 bit kernel, new_inode and iunique generate no inode numbers >32 bits. On a 64 bit kernel,...
Sep 16, 7:53 pm 2007
Satyam Sharma
Re: iunique() fails to return ino_t (after commit 866b04fccb...
That's a bad excuse! Such userspace programs are buggy, period. Let's fix *them*. And, seriously, are you *really* talking of "supporting" userspace programs whose even *sources* are no longer available ? The standard is clear and simple -- calls from userspace programs (that don't define LFS) to stat(2) on a file whose serial number is >2**32 must see EOVERFLOW. This is *not* a kernel problem that needs "fixing". Moreover, changing a kernel function such as iunique() (which was expressly *w...
Sep 16, 10:36 pm 2007
Andrew Morton
Re: iunique() fails to return ino_t (after commit 866b04fccb...
yup. Actually, when I do the copying of the [0/n] text into [1/n]'s changelog I could add text to the changelogs of [2/n] ... [n/n] mentioning that more details are in the preceding changelog. -
Sep 16, 3:39 pm 2007
Can E. Acar
Re: Wasting our Freedom
You are so cleanly isolating and cutting away of a group of developers. I sincerely hope your fellow developers will not cut you off if you make a similar mistake. I know mine wont. What you are saying is, a Copyright violation done by someone else is Somebody Else's Problem (tm). There are a couple of issues with this point of view: First, these developers got questionable advice from senior Linux kernel developers, and SLFC (which is closely related to FSF) in the process. There have been ...
Sep 16, 2:48 pm 2007
Daniel Hazelton
Re: Wasting our Freedom
No, I'm saying "You are complaining about this in the wrong place and accusing IIRC, the advice was "Yes, it is legal to choose to follow only one of multiple offered licenses on a project" - nothing else. They looked at the patches and said "Wait, you've changed the license on files that aren't under a dual license." Hence, no problems here - no questionable advice only. Then file the lawsuit - if they have violated the license and ignored requests to fix the problem then there is sou...
Sep 16, 4:32 pm 2007
Can E. Acar
Re: Wasting our Freedom
The replies suggest that some (most?) people are not aware of the recent developments, and that it is a dual licensing issue. This has very little to do with dual licensing right now, there has been other developments, more "advice" from SLFC. The code in question is Reyk's open source HAL work. I want to emphasize. This work was NOT ever dual licensed. Furthermore, since it is compatible with the binary HAL from Atheros, the interface is fixed and the same both in Linux and *BSD. So, even ...
Sep 16, 11:00 pm 2007
Jeff Garzik
Re: Wasting our Freedom
Hardly. It is software; the interface most definitely can and will change. Jeff -
Sep 16, 11:32 pm 2007
Adrian Bunk
Re: Wasting our Freedom
The most questionable legal advice in this thread was by Theo de Raadt who claimed choosing one licence for _dual-licenced_ code was illegal... This was the first email that was forwarded to linux-kernel, and it made it really hard to see at first that there was also an accidental s/community/communities/ This seems to be a common thinko by some people: The Linux kernel developers and the FSF are two very distinct communities, and there are quite different views on some copyright issu...
Sep 16, 3:59 pm 2007
Hannah Schroeter
Re: Wasting our Freedom
Hi! JFTR, I do *not* think that that assessment was questionable. Unless the dual-licensing *explicitly* allows relicensing, relicensing is forbidden by copyright law. The dual-licensing allows relicensing only if that's *explicitly* stated, either in the statement offering the alternative, or in one of the licenses. Neither GPL nor BSD/ISC allow relicensing in their well-known wordings. If you think that's questionable, you should at least provide arguments (and be ready to have your interp...
Sep 16, 4:39 pm 2007
David Schwartz
RE: Wasting our Freedom
Nobody is relicensing anything, ever. If the author licenses a work under the GPL only, then that is forever how that work is licensed. If an author licenses a work under the BSD, then that is forever how that work is licensed. Same for a dual license. This applies until the copyright expires or the author offers the code under some other license. Nobody ever relicenses anything, ever. If I give you a copy of a work covered by the GPL, the BSD, a dual-license, or whatever, you get a license ...
Sep 16, 6:19 pm 2007
Adrian Bunk
Re: Wasting our Freedom
Dual licenced code by definition explicitely states that you can choose The licence in question was: <-- snip --> /*- * Copyright (c) 2002-2004 Sam Leffler, Errno Consulting * All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions * are met: * 1. Redistributions of source code must retain the above copyright * notice, this list of conditions and the followi...
Sep 16, 5:13 pm 2007
David Schwartz
RE: Wasting our Freedom
He is quite right. You cannot choose the license under which someone else's code is offered. It would "break the law" not in the sense that you would be breaking the law, in the sense that it's impossible because the law does not allow it. You can, however, remove the BSD license notice if you'd like. While the BSD license prohibits you from removing it, you may choose to obtain the right to remove it from the GPL. The GPL does not prohibit removing a BSD license and explicitly grants you the right t...
Sep 16, 6:37 pm 2007
Adrian Bunk
Re: Wasting our Freedom
You can choose the licence under which you distribute the code. It's obvious that everyone else receiving the dual licenced code still It would have helped if you would have read the email I gave a link to... Theo was saying in his email: <-- snip --> In http://lkml.org/lkml/2007/8/29/183, Alan Cox managed to summarize what Jiri Slaby and Luis Rodriguez were trying to do by proposing a modification of a Dual Licenced file without the consent of all the authors. Alan asks "So wha...
Sep 16, 7:09 pm 2007
David Schwartz
RE: Wasting our Freedom
This is a misleading statement. When you distribute the code, you can choose from which license you obtain the right to distribute, but this has *NO* effect on the rights the recipient of the code gets. Everyone receiving dual-licensed code who wishes to modify or distribute that code may choose from which license they obtain that right. They need only comply with the terms of the license from which they obtain rights. But this has no effect on anybody else nor does it have any effect on what right...
Sep 16, 8:29 pm 2007
Theodore Tso
Re: Wasting our Freedom
Careful; the devil is really in the details on this one. If you have a file where all of the code was originally dual licensed (say, like drivers/char/random.c, which was written by me and deliberately dual licensed because I wanted other OS's to be able to use it), then this might be true. However, consider a file which was originally BSD licensed. Now suppose it is modified (i.e., a derived work was created) and another author slaps on a BSD/GPL dual notice. That's fine, so far; the BSD lic...
Sep 16, 9:19 pm 2007
Adrian Bunk
Re: Wasting our Freedom
It's actually the other way round: cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed -
Sep 16, 9:44 pm 2007
David Schwartz
RE: Wasting our Freedom
Theodore Tso wrote: Essentially, I agree with you. My only disagremeent with you is that I think I would argue that it's really not so fine so far. You need to careful to make sure that anybody who receives this file understands that they *must* comply with the BSD license in addition to the GPL. There choices are not "BSD or GPL" they are "BSD or BSD+GPL". They may choose to comply with just the terms of the BSD license, or they may choose to in addition require those who make further deriva...
Sep 16, 9:40 pm 2007
Adrian Bunk
Re: Wasting our Freedom
I hope noone believes this bullshit you are spreading. When you incorporate BSD licenced code into a GPL'ed project it's impossible that the GPL could give you any permission to remove the linux-kernel is not "almost every other forum I know of". Considering how long you are already trolling [1] on linux-kernel cu Adrian [1] Have you ever contributed any patch to the Linux kernel? -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. Ther...
Sep 16, 8:57 pm 2007
David Schwartz
RE: Wasting our Freedom
That's right. I never said otherwise. I did not say that under all conceivable circumstances, the GPL gives you the right to remove a BSD license notice. The example I was talking about was a dual-licensed work. If you choose to make modifications under the GPL, then you are not obtaining any righst under the BSD license and are under no obligation to comply with its terms. In that case, the GPL gives you the right to remove the BSD license notice. (The license remains, of course, only the notice is ...
Sep 16, 9:35 pm 2007
Adrian Bunk
Re: Wasting our Freedom
You did say otherwise. Your claim was that "You can obtain, *from the GPL*, the right to remove a BSD license notice." This claim is bullshit. You can get this right from the copyright holder, e.g. when he cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed -
Sep 16, 9:51 pm 2007
David Schwartz
RE: Wasting our Freedom
By that argument, the GPL never grants anyone any rights, they always come from the copyright holder. For dual-licensed code, it's the GPL that gives you the right to remove the BSD license notice. The copyright holder says you may distribute and modify the code under either license. That doesn't let you remove the text of the other license by itself. For example, if both the BSD and the GPL licenses said you could not modify *any* license text, then you still couldn't remove the other license since ...
Sep 16, 11:37 pm 2007
Theodore Tso
Re: Wasting our Freedom
Hannah, What is going on whenever someone changes a code is that they make a "derivative work". Whether or not you can even make a derivative work, and under what terms the derivitive work can be licensed, is strictly up to the license of the original. For example, the BSD license says: Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met.... Note the "with or without modification". This is wha...
Sep 16, 5:12 pm 2007
Jacob Meuser
Re: Wasting our Freedom
which is _exactly_ what you guys are doing. so the linux community is morally equivilent to a corporation? that's what it sounds like you are all legally satisfied with. -- jakemsr@sdf.lonestar.org SDF Public Access UNIX System - http://sdf.lonestar.org -
Sep 16, 7:16 pm 2007
david
Re: Wasting our Freedom
if it's legal it's legal. it's not a matter of the Linux community being satisfied eith it, it's a matter of the BSD people desiring it based on their selection of license (and the repeated statements that this feature of the BSD license being an advantage compared to the GPL makes it clear that this isn't an unknown side effect, it's an explicit desire). so the Linux community is following the desires of the BSD community by following their license but the BSD community is unhappy, why? y...
Sep 16, 7:40 pm 2007
Jeff Garzik
Re: Wasting our Freedom
There are two highly relevant angles to this that nobody is mentioning: 1) Does it make sense to share code, at a technical level? The fact is, BSD and Linux wireless stacks are quite different. Linux also has a technical requirement that "Linux drivers look like Linux drivers." This enables a vast array of source code checking tools like Coverity and sparse, as well as maximizing human reviewer bandwidth. Therefore, there is a strong /technical/ motivation for the source code to dive...
Sep 16, 8:01 pm 2007
Daniel Hazelton
Re: Wasting our Freedom
That advice wasn't regarding relicensing. Dual-licensed code allows distribution and use under either license. If I get BSD/GPL code, I can follow the GPL exclusively and I don't have to follow the BSD license at all. And the alternative is also true. (ie: follow the BSD license exclusively and ignore the GPL) It's not "relicensing" - it's following *WHICH* of the offered terms are more agreeable. I'll just snip the rest, since you seem confused. <snip> DRH -- Dialup is li...
Sep 16, 5:11 pm 2007
Jeff Garzik
Re: Wasting our Freedom
Regarding "Linux Kernel developers," false. _I_ have posted. ath5k, wireless, and net driver maintainers have all sent emails. License and code fixes have been committed. As for the FSF: It has been repeatedly stated that the FSF has zip to You are failing to observe that changes have been made in response to criticism. Given that Linux Kernel devs have responded both with code changes and emails, "silence" and "inaction" are provably false. And since the changes go ath5k->linv...
Sep 16, 3:40 pm 2007
FD Cami
scheduler improvements : 2.6.21 vs 2.6.22-ck1 vs 2.6.23-rc6
Warning: I have not run any benchmarks. One thing I am (more or less) able to measure is my own ability to headshot in some games like UT99. The other thing is to see if flash videos stutter or die under load. Please remember, this is about desktop usage - not numbers. my computer: PIII-S 1400 (512KB L2) TUSL2-C (i815ep) 512MB PC133 FireGL 8800 (~Radeon 8500 128MB) with dri drivers Hello Ingo, LKML, Here are the results of a few informal tests (flash videos, playing UT99, and looping k...
Sep 16, 1:26 pm 2007
Roman Zippel
Re: [PATCH 2.6.23-rc4] qconf ("make xconfig") Search Dialog ...
Hi, I like the direction, but first of all please fix the coding style. I would also prefer to move more of the search functionality into the generic code, so it can be used by other front ends as well, otherwise a lot of this had to be duplicated. I think a filter function makes it maybe a bit to flexible, if a front end wants to do some weird filtering, it can still access the symbol data base directly. So what I have in mind is something like this: struct symbol **sym_generic_search(const c...
Sep 16, 12:43 pm 2007
Thomas Gleixner
clockevents - regression fixes for 2.6.23
Linus, please pull the clockevents regression fixes from my hrt tree. Thanks, tglx The following changes since commit d0174640eedc1cd756754f03afe2dbb3d56de74e: Linus Torvalds (1): Merge branch 'upstream-linus' of master.kernel.org:/.../jgarzik/netdev-2.6 are available in the git repository at: ssh://master.kernel.org/pub/scm/linux/kernel/git/tglx/linux-2.6-hrt.git for-2.6.23 Thomas Gleixner (5): timekeeping: access rtc outside of xtime lock timekeeping: Preven...
Sep 16, 9:44 am 2007
Frans Pop
TSC && HPET calibration
I'm seeing the same error as reported by Sami Farin earlier today [1], but from my logs I can see that the issue is intermittent (2/3 failures). The logs indicate that the issue was introduced with 2.6.22 as TSC sync was correct for all boots with 2.6.21-6. My system is also Pentium D: Intel(R) Pentium(R) D CPU 3.20GHz Cheers, Frans Pop [1] http://lkml.org/lkml/2007/9/16/34 Jul 12 10:54:37 faramir kernel: Linux version 2.6.21-2-amd64 (Debian 2.6.21-6) (waldi@debian.org) (gcc version 4.1.3 20...
Sep 16, 9:02 am 2007
lepton
[PATCH] 2.6.22.6 reiserfs: work around for dead loop in fini...
Hi, There is possible dead loop in finish_unfinished function. In most situation, the call chain iput -> ... -> reiserfs_delete_inode -> remove_save_link will success. But for some reason such as data corruption, reiserfs_delete_inode fails on reiserfs_do_truncate -> search_for_position_by_key. Then remove_save_link doesn't be called. We always get the same "save_link_key" in the while loop in finish_unfinished function. The following patch adds a check for the possib...
Sep 16, 8:02 am 2007
Sami Farin
TSC && HPET calibration
/var/log # grep -Ei "hpet|tsc" dmesg-2.6.19.7 dmesg.2.6.22.6-x86_64 dmesg-2.6.19.7:ACPI: HPET (v001 INTEL DQ965GF 0x000015db MSFT 0x01000013) @ 0x3e6f2000 dmesg-2.6.19.7:ACPI: HPET id: 0x8086a201 base: 0xfed00000 dmesg-2.6.19.7:[ 34.337155] hpet0: at MMIO 0xfed00000, IRQs 2, 8, 0 dmesg-2.6.19.7:[ 34.337296] hpet0: 3 64-bit timers, 14318180 Hz [*] dmesg-2.6.19.7:[ 34.338350] Using HPET for base-timer dmesg-2.6.19.7:[ 34.594096] checking TSC synchronization across 2 CPUs: passed. dmesg-2.6.1...
Sep 16, 6:47 am 2007
Sam Ravnborg
kbuild update
A summary of what is planned to be submitted in next merge window for kbuild. The shortlog below have additional details but the headlines are: o Make the kernel buildable on a cygwin box (but not without a few glitches) o detect unterminated device id list o add export_report as a valid top-level make target o add script to find unused kconfig symbols (try it!) o allow a user to specify additional flags on the commandline with CFLAGS, AFLAGS or CPPFLAGS. The flags will be appended to the kernel ...
Sep 16, 5:47 am 2007
Robert P. J. Day
Re: kbuild update
based on my experiences with this, unless you filter carefully, you're going to end up with a *whack* of false positives given the number of developers who elect to name their local macros starting with a prefix of "CONFIG_". good luck dealing with *that*. :-) rday -- ======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://crashcourse.ca ===========================...
Sep 16, 8:58 am 2007
Andrew Morton
Re: kbuild update
box:/usr/src/linux-2.6.23-rc6> grep -r '^[ ]*#[ ]*define[ ]*CONFIG_' . | wc -l 415 bah. They're all bugs - The CONFIG_foo namespace is (should be) reserved in kernel coding. -
Sep 16, 3:23 pm 2007
Sam Ravnborg
Re: kbuild update
I get (after a bit more filtering 349 hits of which 182 are outside drivers/ Of the 182 the 25 of them are in arch specific code. I se no good reasons to address this unless we touch code in that area anyway. But avoiding new entries are good. Sam -
Sep 16, 4:38 pm 2007
Sam Ravnborg
Re: kbuild update
This is useful for specific people but not for kernel janitorial fodder. As you already experience the amount of false positive are too high. But for a developer of a module it is no deal to ignore the false positives. It is for godd reasons not integrated in the build process. Sam -
Sep 16, 11:13 am 2007
Robert P. J. Day
Re: kbuild update
right, i agree completely. if it were absolutely reliable in generating *only* actual unused symbols, then that *might* (i stress, *might*) be a viable argument for making it part of the Kbuild system. but, really, if you can whip off a script that does most of the job in a few minutes, there's really no motivation to then spend hours trying to nail those last few harmless bits of irrelevant output. rday -- ======================================================================== Robert P. J...
Sep 16, 11:21 am 2007
Sam Ravnborg
Re: [PATCH 2.6.23-rc4] qconf ("make xconfig") Search Dialog ...
I fixed up the line breake in the patch and applied it. Please add a signed-off-by next time. Thanks, Sam -
Sep 16, 5:25 am 2007
previous daytodaynext day
September 15, 2007September 16, 2007September 17, 2007