Home » Mailing list archives » linux-kernel » 2007 » September » 16

Re: [PATCH] modpost: detect unterminated device id lists

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Satyam Sharma <satyam.sharma@...>
To: Andrew Morton <akpm@...>
Cc: Kees Cook <kees@...>, Greg KH <greg@...>, Alexey Dobriyan <adobriyan@...>, Jeff Garzik <jeff@...>, <linux-kernel@...>, Ben Collins <bcollins@...>, Michael Wu <flamingice@...>
Subject: Re: [PATCH] modpost: detect unterminated device id lists
Date: Sunday, September 16, 2007 - 8:24 pm

On 9/17/07, Andrew Morton <akpm@linux-foundation.org> wrote:

Hmm? Are you sure you didn't see any "drivers/media/video/pv" before the
"rusb2/pvrusb2" bit? Looking at Kees' patch (and the existing code), I've no
clue how/why this should happen ... will try to reproduce here ...



USB_DEVICE(0, 0) is not empty termination, actually, and this looks like
a genuine bug caught by the patch. As that dump shows, USB_DEVICE(0, 0)
assigns "0x03 0x00" (in little endian) to usb_device_id.match_flags. And
I don't think the USB code treats such an entry as an empty entry (?)

Interestingly, the "USB_DEVICE(0, 0)" thing is absent from latest -git
tree and also in my copy of 23-rc4-mm1 -- so this looks like something
you must've merged recently.
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] pci: fix unterminated pci_device_id lists, Kees Cook, (Wed Sep 12, 2:41 am)
Re: [PATCH] pci: fix unterminated pci_device_id lists, Jeff Garzik, (Wed Sep 12, 7:10 am)
Re: [PATCH] pci: fix unterminated pci_device_id lists, Alexey Dobriyan, (Wed Sep 12, 7:48 am)
Re: [PATCH] pci: fix unterminated pci_device_id lists, Greg KH, (Wed Sep 12, 5:53 pm)
[PATCH] modpost: detect unterminated device id lists, Kees Cook, (Wed Sep 12, 8:49 pm)
Re: [PATCH] modpost: detect unterminated device id lists, Satyam Sharma, (Sun Sep 16, 9:22 pm)
Re: [PATCH] modpost: detect unterminated device id lists, Kees Cook, (Sun Sep 16, 11:45 pm)
Re: [PATCH] modpost: detect unterminated device id lists, Andrew Morton, (Mon Sep 17, 2:48 am)
Re: [PATCH] modpost: detect unterminated device id lists, Andrew Morton, (Sun Sep 16, 6:14 pm)
Re: [PATCH] modpost: detect unterminated device id lists, Satyam Sharma, (Sun Sep 16, 8:24 pm)
Re: [PATCH] modpost: detect unterminated device id lists, Andrew Morton, (Mon Sep 17, 2:46 am)
Re: [PATCH] modpost: detect unterminated device id lists, Satyam Sharma, (Mon Sep 17, 5:45 pm)
Re: [PATCH] modpost: detect unterminated device id lists, Andrew Morton, (Mon Sep 17, 5:50 pm)
Re: [PATCH] modpost: detect unterminated device id lists, Mauro Carvalho Chehab, (Mon Sep 17, 7:36 pm)
Re: [PATCH] modpost: detect unterminated device id lists, Andrew Morton, (Wed Sep 12, 9:21 pm)
Re: [PATCH] pci: fix unterminated pci_device_id lists, Andrew Morton, (Wed Sep 12, 7:08 pm)
Re: [PATCH] pci: fix unterminated pci_device_id lists, Alexey Dobriyan, (Thu Sep 13, 2:34 am)
Re: [PATCH] pci: fix unterminated pci_device_id lists, Sam Ravnborg, (Thu Sep 13, 2:58 am)
Re: [PATCH] pci: fix unterminated pci_device_id lists, Jeff Garzik, (Thu Sep 13, 2:42 am)
Re: [PATCH] pci: fix unterminated pci_device_id lists, Jan Engelhardt, (Sat Sep 15, 5:01 am)