Home » Mailing list archives » linux-kernel » 2007 » September » 16

Re: [PATCH] modpost: detect unterminated device id lists

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Andrew Morton <akpm@...>
To: Kees Cook <kees@...>
Cc: Greg KH <greg@...>, Alexey Dobriyan <adobriyan@...>, Jeff Garzik <jeff@...>, <linux-kernel@...>, Ben Collins <bcollins@...>, Michael Wu <flamingice@...>
Subject: Re: [PATCH] modpost: detect unterminated device id lists
Date: Sunday, September 16, 2007 - 6:14 pm

On Wed, 12 Sep 2007 17:49:37 -0700 Kees Cook <kees@ubuntu.com> wrote:


I'm getting this:

rusb2/pvrusb2: struct usb_device_id is 20 bytes.  The last of 3 is:
0x03 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 
FATAL: drivers/media/video/pvrusb2/pvrusb2: struct usb_device_id is not terminated with a NULL entry!

("rusb2/pvrusb2" ??)

but:

struct usb_device_id pvr2_device_table[] = {
	[PVR2_HDW_TYPE_29XXX] = { USB_DEVICE(0x2040, 0x2900) },
	[PVR2_HDW_TYPE_24XXX] = { USB_DEVICE(0x2040, 0x2400) },
	{ USB_DEVICE(0, 0) },
};
	
looks OK?

Using plain old "{ }" shut the warning up.
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] pci: fix unterminated pci_device_id lists, Kees Cook, (Wed Sep 12, 2:41 am)
Re: [PATCH] pci: fix unterminated pci_device_id lists, Jeff Garzik, (Wed Sep 12, 7:10 am)
Re: [PATCH] pci: fix unterminated pci_device_id lists, Alexey Dobriyan, (Wed Sep 12, 7:48 am)
Re: [PATCH] pci: fix unterminated pci_device_id lists, Greg KH, (Wed Sep 12, 5:53 pm)
[PATCH] modpost: detect unterminated device id lists, Kees Cook, (Wed Sep 12, 8:49 pm)
Re: [PATCH] modpost: detect unterminated device id lists, Satyam Sharma, (Sun Sep 16, 9:22 pm)
Re: [PATCH] modpost: detect unterminated device id lists, Kees Cook, (Sun Sep 16, 11:45 pm)
Re: [PATCH] modpost: detect unterminated device id lists, Andrew Morton, (Mon Sep 17, 2:48 am)
Re: [PATCH] modpost: detect unterminated device id lists, Andrew Morton, (Sun Sep 16, 6:14 pm)
Re: [PATCH] modpost: detect unterminated device id lists, Satyam Sharma, (Sun Sep 16, 8:24 pm)
Re: [PATCH] modpost: detect unterminated device id lists, Andrew Morton, (Mon Sep 17, 2:46 am)
Re: [PATCH] modpost: detect unterminated device id lists, Satyam Sharma, (Mon Sep 17, 5:45 pm)
Re: [PATCH] modpost: detect unterminated device id lists, Andrew Morton, (Mon Sep 17, 5:50 pm)
Re: [PATCH] modpost: detect unterminated device id lists, Mauro Carvalho Chehab, (Mon Sep 17, 7:36 pm)
Re: [PATCH] modpost: detect unterminated device id lists, Andrew Morton, (Wed Sep 12, 9:21 pm)
Re: [PATCH] pci: fix unterminated pci_device_id lists, Andrew Morton, (Wed Sep 12, 7:08 pm)
Re: [PATCH] pci: fix unterminated pci_device_id lists, Alexey Dobriyan, (Thu Sep 13, 2:34 am)
Re: [PATCH] pci: fix unterminated pci_device_id lists, Sam Ravnborg, (Thu Sep 13, 2:58 am)
Re: [PATCH] pci: fix unterminated pci_device_id lists, Jeff Garzik, (Thu Sep 13, 2:42 am)
Re: [PATCH] pci: fix unterminated pci_device_id lists, Jan Engelhardt, (Sat Sep 15, 5:01 am)