Home » Mailing list archives » linux-kernel » 2007 » September » 15

[PATCH -mm] Hibernation: Resume consoles if hibernation_platform_enter fails

Previous thread: Re: + taskstats-add-all-thread-stats-for-taskstats_cmd_attr_tgid.patch added to -mm tree by Guillaume Chazarain on Saturday, September 15, 2007 - 11:51 am. (2 messages)

Next thread: CPU usage for 10Gbps UDP transfers by Lukas Hejtmanek on Saturday, September 15, 2007 - 12:00 pm. (4 messages)
[view original message]
From: Rafael J. Wysocki
Subject: [PATCH -mm] Hibernation: Resume consoles if hibernation_platform_enter fails
Date: Saturday, September 15, 2007 - 12:17 pm

[This is a fix on top of
hibernation-enter-platform-hibernation-state-in-a-consistent-way-rev-4.patch]
---
From: Rafael J. Wysocki <rjw@sisk.pl>

If hibernation_platform_enter() fails, consoles should be resumed so that
diagnostic information related to the failure is available to the user.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
 kernel/power/disk.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Index: linux-2.6.23-rc6/kernel/power/disk.c
===================================================================
--- linux-2.6.23-rc6.orig/kernel/power/disk.c
+++ linux-2.6.23-rc6/kernel/power/disk.c
@@ -293,7 +293,7 @@ int hibernation_platform_enter(void)
 	suspend_console();
 	error = device_suspend(PMSG_SUSPEND);
 	if (error)
-		return error;
+		goto Resume_console;
 
 	error = hibernation_ops->prepare();
 	if (error)
@@ -320,6 +320,8 @@ int hibernation_platform_enter(void)
 	hibernation_ops->finish();
  Resume_devices:
 	device_resume();
+ Resume_console:
+	resume_console();
 	return error;
 }
 
-


[ message continues ]
Previous thread: Re: + taskstats-add-all-thread-stats-for-taskstats_cmd_attr_tgid.patch added to -mm tree by Guillaume Chazarain on Saturday, September 15, 2007 - 11:51 am. (2 messages)

Next thread: CPU usage for 10Gbps UDP transfers by Lukas Hejtmanek on Saturday, September 15, 2007 - 12:00 pm. (4 messages)