Re: Credentials test patch

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: David Howells <dhowells@...>
Cc: <viro@...>, <hch@...>, <torvalds@...>, <linux-kernel@...>
Date: Saturday, September 15, 2007 - 11:51 am

In sys_faccessat you temporarily allocate a cred object which is
discarded in the end.  With a few more macro definitions you could
create a dup_cred variant which initialized an automatic variable of
type struct cred.  This way the kmalloc/kfree pair would fall away.

access is actually used frequently.  For instance, ld.so uses it on
every startup as a quicker possibility to check for a file which
usually doesn't exist.  So, speeding up access has some small effect
on performance.  The resulting code might actually reduce the kernel
size a bit due to all the checks and calls which go away.
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Credentials test patch, David Howells, (Thu Sep 13, 3:56 pm)
Re: Credentials test patch, David Howells, (Tue Sep 18, 12:33 pm)
Re: Credentials test patch, Trond Myklebust, (Tue Sep 18, 12:44 pm)
Re: Credentials test patch, Casey Schaufler, (Tue Sep 18, 1:58 pm)
Re: Credentials test patch, Trond Myklebust, (Tue Sep 18, 2:03 pm)
Re: Credentials test patch, David Howells, (Tue Sep 18, 2:24 pm)
Re: Credentials test patch, David Howells, (Tue Sep 18, 1:25 pm)
Re: Credentials test patch, David Howells, (Mon Sep 17, 11:27 am)
Re: Credentials test patch, Ulrich Drepper, (Sat Sep 15, 11:51 am)
Re: Credentials test patch, David Howells, (Mon Sep 17, 7:02 am)
Re: Credentials test patch, Ulrich Drepper, (Mon Sep 17, 10:28 am)
Re: Credentials test patch, Linus Torvalds, (Thu Sep 13, 4:09 pm)
Re: Credentials test patch, David Howells, (Thu Sep 13, 5:19 pm)
Re: Credentials test patch, Linus Torvalds, (Thu Sep 13, 5:33 pm)