login
Header Space

 
 

Re: [linux-dvb] [PATCH] Userspace tuner

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Markus Rechberger <mrechberger@...>
Cc: Johannes Stezenbach <js@...>, video4linux-list@redhat.com <video4linux-list@...>, Manu Abraham <abraham.manu@...>, linux-kernel@vger.kernel.org <linux-kernel@...>, akpm@linux-foundation.org <akpm@...>, linux-dvb@linuxtv.org <linux-dvb@...>, <mschimek@...>
Date: Friday, September 14, 2007 - 2:29 pm

> > - The hybrid tuner support, that where your requirement, when all those

Maybe it is still not perfect. Feel free to improve it. Several people
from the community, including me, already offered you help to add your
driver, reworking on the 5% of the stuff that aren't compatible with the
V4L/DVB core API design.

We can use the full 64 bits of v4l2_std_id. We just need to take some
care. 

Due to the lack of __ucmpdi2 on ppc32 architecture, with some gcc
versions, a hack were added at v4l2-common.c, that truncates it to 32
bits, at the function v4l2_norm_to_name():

http://git.kernel.org/?p=linux/kernel/git/mchehab/v4l-dvb.git;a=commit;h=412297d31d439...

So, using more than 32 bits is possible, providing that we change the
implementation of v4l2_norm_to_name() or find a way for it to work with
ppc32.

Instead of just adding a standard for each possible combination, we may
just add bits for the supported audio formats. For example, we can use
the bitmask as:

#define V4L2_STD_AUDIO_NICAM_A  ((v4l2_std_id)0x04000000)
#define V4L2_STD_AUDIO_A2_A     ((v4l2_std_id)0x08000000)

Since for all other chipsets but xc3028, all audio standards are
supported, maybe we can, instead, use a negate bitmap logic for the
non-supported audio standards. Something like:

#define V4L2_STD_AUDIO_NOT_NICAM_A  ((v4l2_std_id)0x04000000)
#define V4L2_STD_AUDIO_NOT_A2_A     ((v4l2_std_id)0x08000000)

And define some macros for the specific standards you need. For example:

#define V4L2_STD_AUDIO_NOT_ALL	V4L2_STD_AUDIO_NOT_A2_A | V4L2_STD_AUDIO_NOT_NICAM_A

#define V4L2_STD_PAL_BG_A2 	V4L2_STD_PAL_BG | (V4L2_STD_AUDIO_NOT_ALL & !V4L2_STD_AUDIO_NOT_A2_A)

This way, V4L2_STD_PAL_BG will mean that this PAL/BG accepts all
possible audio standards (being binary compatible), while
V4L2_STD_PAL_BG_A2_A will mean that only A2 response 'A' audio format is
supported for PAL/BG.

-- 
Cheers,
Mauro

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [linux-dvb] [PATCH] Userspace tuner, Markus Rechberger, (Wed Sep 12, 7:10 pm)
Re: [linux-dvb] [PATCH] Userspace tuner, Johannes Stezenbach, (Thu Sep 13, 9:13 am)
Re: [linux-dvb] [PATCH] Userspace tuner, Markus Rechberger, (Thu Sep 13, 10:12 am)
Re: [linux-dvb] [PATCH] Userspace tuner, Manu Abraham, (Thu Sep 13, 11:50 am)
Re: [linux-dvb] [PATCH] Userspace tuner, Markus Rechberger, (Thu Sep 13, 12:08 pm)
Re: [linux-dvb] [PATCH] Userspace tuner, Steven Toth, (Thu Sep 13, 4:36 pm)
Re: [linux-dvb] [PATCH] Userspace tuner, Alan Cox, (Fri Sep 14, 8:10 am)
Re: [linux-dvb] [PATCH] Userspace tuner, hermann pitton, (Thu Sep 13, 8:49 pm)
Re: [linux-dvb] [PATCH] Userspace tuner, Markus Rechberger, (Thu Sep 13, 7:17 pm)
Re: [linux-dvb] [PATCH] Userspace tuner, Alan Cox, (Fri Sep 14, 9:52 am)
Re: [linux-dvb] [PATCH] Userspace tuner, Markus Rechberger, (Fri Sep 14, 12:18 pm)
Re: [linux-dvb] [PATCH] Userspace tuner, Jelle Foks, (Tue Sep 18, 4:19 am)
Re: [linux-dvb] [PATCH] Userspace tuner, Mauro Carvalho Chehab, (Tue Sep 18, 6:56 pm)
Re: [linux-dvb] [PATCH] Userspace tuner, Alan Cox, (Tue Sep 18, 7:00 pm)
Re: [linux-dvb] [PATCH] Userspace tuner, Markus Rechberger, (Tue Sep 18, 4:55 am)
Re: [linux-dvb] [PATCH] Userspace tuner, Steven Toth, (Thu Sep 13, 9:03 pm)
Re: [linux-dvb] [PATCH] Userspace tuner, Markus Rechberger, (Fri Sep 14, 2:38 am)
Re: [linux-dvb] [PATCH] Userspace tuner, Johannes Stezenbach, (Fri Sep 14, 7:38 am)
Re: [linux-dvb] [PATCH] Userspace tuner, Markus Rechberger, (Fri Sep 14, 12:36 pm)
Re: [linux-dvb] [PATCH] Userspace tuner, Johannes Stezenbach, (Fri Sep 14, 4:43 pm)
Re: [linux-dvb] [PATCH] Userspace tuner, Markus Rechberger, (Fri Sep 14, 9:49 pm)
Re: [linux-dvb] [PATCH] Userspace tuner, Johannes Stezenbach, (Sat Sep 15, 9:34 am)
Re: [linux-dvb] [PATCH] Userspace tuner, Steven Toth, (Sat Sep 15, 10:56 am)
Re: [linux-dvb] [PATCH] Userspace tuner, Manu Abraham, (Sat Sep 15, 4:52 am)
Re: [linux-dvb] [PATCH] Userspace tuner, Mauro Carvalho Chehab, (Fri Sep 14, 11:09 pm)
Re: [linux-dvb] [PATCH] Userspace tuner, Markus Rechberger, (Sat Sep 15, 8:59 am)
Re: [linux-dvb] [PATCH] Userspace tuner, Markus Rechberger, (Fri Sep 14, 9:29 pm)
Re: [linux-dvb] [PATCH] Userspace tuner, Johannes Stezenbach, (Sat Sep 15, 9:16 am)
Re: [linux-dvb] [PATCH] Userspace tuner, Markus Rechberger, (Sat Sep 15, 9:38 am)
Re: [linux-dvb] [PATCH] Userspace tuner, Mauro Carvalho Chehab, (Sat Sep 15, 10:04 am)
Re: [linux-dvb] [PATCH] Userspace tuner, Bernard Jungen, (Sat Sep 15, 12:58 pm)
Re: [linux-dvb] [PATCH] Userspace tuner, Markus Rechberger, (Mon Sep 17, 4:46 am)
Re: [linux-dvb] [PATCH] Userspace tuner, Hans Verkuil, (Sun Sep 16, 7:30 am)
Re: [linux-dvb] [PATCH] Userspace tuner, Markus Rechberger, (Sat Sep 15, 10:33 am)
Re: [linux-dvb] [PATCH] Userspace tuner, Mauro Carvalho Chehab, (Sat Sep 15, 10:45 am)
Re: [linux-dvb] [PATCH] Userspace tuner, Mauro Carvalho Chehab, (Fri Sep 14, 9:49 pm)
Re: [linux-dvb] [PATCH] Userspace tuner, Mauro Carvalho Chehab, (Fri Sep 14, 1:32 pm)
Re: [linux-dvb] [PATCH] Userspace tuner, Markus Rechberger, (Fri Sep 14, 1:46 pm)
Re: [linux-dvb] [PATCH] Userspace tuner, Mauro Carvalho Chehab, (Fri Sep 14, 2:29 pm)
Re: [linux-dvb] [PATCH] Userspace tuner, Michael Krufky, (Fri Sep 14, 3:20 pm)
Re: [linux-dvb] [PATCH] Userspace tuner, Aidan Thornton, (Fri Sep 14, 5:07 pm)
Re: [linux-dvb] [PATCH] Userspace tuner, Manu Abraham, (Fri Sep 14, 5:53 pm)
Re: [linux-dvb] [PATCH] Userspace tuner, Mauro Carvalho Chehab, (Fri Sep 14, 5:16 pm)
Re: [linux-dvb] [PATCH] Userspace tuner, Manu Abraham, (Fri Sep 14, 3:57 am)
Re: [linux-dvb] [PATCH] Userspace tuner, Joerg Roedel, (Fri Sep 14, 5:15 am)
Re: [linux-dvb] [PATCH] Userspace tuner, Manu Abraham, (Fri Sep 14, 8:00 am)
Re: [linux-dvb] [PATCH] Userspace tuner, Joerg Roedel, (Fri Sep 14, 12:13 pm)
Re: [linux-dvb] [PATCH] Userspace tuner, Manu Abraham, (Fri Sep 14, 12:56 pm)
Re: [linux-dvb] [PATCH] Userspace tuner, Joerg Roedel, (Fri Sep 14, 1:40 pm)
Re: [linux-dvb] [PATCH] Userspace tuner, Markus Rechberger, (Fri Sep 14, 12:09 pm)
Re: [linux-dvb] [PATCH] Userspace tuner, Alex Deucher, (Fri Sep 14, 2:52 pm)
Re: [linux-dvb] [PATCH] Userspace tuner, Markus Rechberger, (Fri Sep 14, 2:59 pm)
Re: [linux-dvb] [PATCH] Userspace tuner, Alex Deucher, (Fri Sep 14, 3:38 pm)
Re: [linux-dvb] [PATCH] Userspace tuner, Manu Abraham, (Thu Sep 13, 12:22 pm)
Re: [linux-dvb] [PATCH] Userspace tuner, Markus Rechberger, (Thu Sep 13, 12:32 pm)
Re: [linux-dvb] [PATCH] Userspace tuner, Manu Abraham, (Thu Sep 13, 12:52 pm)
speck-geostationary