Home » Mailing list archives » linux-kernel » 2007 » September » 14

Re: [PATCH] mm: use pagevec to rotate reclaimable page

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Hisashi Hifumi <hifumi.hisashi@...>
To: Andrew Morton <akpm@...>
Cc: <linux-kernel@...>, <linux-mm@...>
Subject: Re: [PATCH] mm: use pagevec to rotate reclaimable page
Date: Friday, September 14, 2007 - 3:42 am

Thank you for your comment.

At 11:37 07/09/14, Andrew Morton wrote:

 >The page_count() test here is a bit of a worry, too.  Why do we need it?
 >The caller must have pinned the page in some fashion else we couldn't use
 >it safely in this function at all.
 >
 >I assume that you discovered that once we've cleared PageWriteback(), the
 >page can get reclaimed elsewhere?  If so, that could still happen
 >immediately after the page_count() test.  It's all a bit of a worry.
 >Deferring the ClearPageWriteback() will fix any race concerns, but I do
 >think that we need to take a ref on the page for the pagevec ownership.
 >

Actually, I considered taking a ref to pin pages. But this could prevent 
the page
reclaiming activity so I did not use it.

I reflect your comment and send you modified patch.

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] mm: use pagevec to rotate reclaimable page, Hisashi Hifumi, (Tue Sep 11, 5:31 am)
Re: [PATCH] mm: use pagevec to rotate reclaimable page, Andrew Morton, (Thu Sep 13, 10:37 pm)
Re: [PATCH] mm: use pagevec to rotate reclaimable page, Hisashi Hifumi, (Tue Sep 18, 6:41 am)
Re: [PATCH] mm: use pagevec to rotate reclaimable page, Andrew Morton, (Wed Sep 19, 6:17 pm)
Re: [PATCH] mm: use pagevec to rotate reclaimable page, Nick Piggin, (Mon Sep 17, 9:29 pm)
Re: [PATCH] mm: use pagevec to rotate reclaimable page, Andrew Morton, (Tue Sep 18, 1:44 pm)
Re: [PATCH] mm: use pagevec to rotate reclaimable page, Nick Piggin, (Mon Sep 17, 9:47 pm)
Re: [PATCH] mm: use pagevec to rotate reclaimable page, Andrew Morton, (Tue Sep 18, 2:03 pm)
Re: [PATCH] mm: use pagevec to rotate reclaimable page, Hisashi Hifumi, (Fri Sep 14, 3:42 am)