Driver core: remove subsys_get()

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <linux-kernel@...>
Date: Thursday, September 13, 2007 - 7:40 pm

There are no more subsystems, it's a kset now so remove the function and
the only two users, which are in the driver core.


Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 drivers/base/bus.c      |    2 +-
 drivers/base/class.c    |    2 +-
 include/linux/kobject.h |    7 -------
 lib/kobject.c           |    2 +-
 4 files changed, 3 insertions(+), 10 deletions(-)

--- a/drivers/base/bus.c
+++ b/drivers/base/bus.c
@@ -728,7 +728,7 @@ EXPORT_SYMBOL_GPL(device_reprobe);
 
 struct bus_type *get_bus(struct bus_type *bus)
 {
-	return bus ? container_of(subsys_get(&bus->subsys),
+	return bus ? container_of(kset_get(&bus->subsys),
 				struct bus_type, subsys) : NULL;
 }
 
--- a/drivers/base/class.c
+++ b/drivers/base/class.c
@@ -93,7 +93,7 @@ void class_remove_file(struct class * cl
 static struct class *class_get(struct class *cls)
 {
 	if (cls)
-		return container_of(subsys_get(&cls->subsys), struct class, subsys);
+		return container_of(kset_get(&cls->subsys), struct class, subsys);
 	return NULL;
 }
 
--- a/include/linux/kobject.h
+++ b/include/linux/kobject.h
@@ -231,13 +231,6 @@ extern void subsystem_init(struct kset *
 extern int __must_check subsystem_register(struct kset *);
 extern void subsystem_unregister(struct kset *);
 
-static inline struct kset *subsys_get(struct kset *s)
-{
-	if (s)
-		return kset_get(s);
-	return NULL;
-}
-
 struct subsys_attribute {
 	struct attribute attr;
 	ssize_t (*show)(struct kset *, char *);
--- a/lib/kobject.c
+++ b/lib/kobject.c
@@ -679,7 +679,7 @@ int subsys_create_file(struct kset *s, s
 	if (!s || !a)
 		return -EINVAL;
 
-	if (subsys_get(s)) {
+	if (kset_get(s)) {
 		error = sysfs_create_file(&s->kobj, &a->attr);
 		kset_put(s);
 	}
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC] Some driver core and kobject minor patches, Greg KH, (Thu Sep 13, 7:37 pm)
Re: [RFC] Some driver core and kobject minor patches, Cornelia Huck, (Fri Sep 14, 7:25 am)
kobject: remove the static array for the name, Greg KH, (Thu Sep 13, 7:44 pm)
cdev: remove unneeded setting of cdev names, Greg KH, (Thu Sep 13, 7:43 pm)
Driver core: remove subsys_set_kset, Greg KH, (Thu Sep 13, 7:40 pm)
Driver core: remove subsys_put(), Greg KH, (Thu Sep 13, 7:40 pm)
Driver core: remove subsys_get(), Greg KH, (Thu Sep 13, 7:40 pm)
Driver core: remove put_bus(), Greg KH, (Thu Sep 13, 7:39 pm)
Re: Driver core: remove put_bus(), Cornelia Huck, (Fri Sep 14, 7:03 am)
Driver core: remove kset_set_kset_s, Greg KH, (Thu Sep 13, 7:39 pm)
Driver core: remove get_bus(), Greg KH, (Thu Sep 13, 7:38 pm)
Re: Driver core: remove get_bus(), Cornelia Huck, (Fri Sep 14, 7:02 am)
Re: Driver core: remove get_bus(), Greg KH, (Fri Sep 14, 7:27 am)