Home » Mailing list archives » linux-kernel » 2007 » September » 13

Commit 02a5e0acb3cb85d80d0fe834e366d38a92bbaa22 might break kernel build

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: <aherrman@...>
To: Linus Torvalds <torvalds@...>, Andrew Morton <akpm@...>
Cc: Jens Axboe <jens.axboe@...>, David Howells <dhowells@...>, <linux-kernel@...>
Subject: Commit 02a5e0acb3cb85d80d0fe834e366d38a92bbaa22 might break kernel build
Date: Thursday, September 13, 2007 - 7:28 pm

Due to commit 02a5e0acb3cb85d80d0fe834e366d38a92bbaa22
kernel build is broken if (CONFIG_COMPAT && ! CONFIG_BLOCK):

  CC      fs/compat_ioctl.o
In file included from include/linux/raid/md_k.h:19,
                 from include/linux/raid/md.h:54,
                 from fs/compat_ioctl.c:25:
include/linux/raid/../../../drivers/md/dm-bio-list.h: In bio_list_:
include/linux/raid/../../../drivers/md/dm-bio-list.h:40: error: dereferencing pointer to incomplete type
include/linux/raid/../../../drivers/md/dm-bio-list.h: In bio_list_:
include/linux/raid/../../../drivers/md/dm-bio-list.h:48: error: dereferencing pointer to incomplete type
include/linux/raid/../../../drivers/md/dm-bio-list.h:51: error: dereferencing pointer to incomplete type
include/linux/raid/../../../drivers/md/dm-bio-list.h: In bio_list_:
include/linux/raid/../../../drivers/md/dm-bio-list.h:64: error: dereferencing pointer to incomplete type
include/linux/raid/../../../drivers/md/dm-bio-list.h: In bio_list_merge_:
include/linux/raid/../../../drivers/md/dm-bio-list.h:78: error: dereferencing pointer to incomplete type
include/linux/raid/../../../drivers/md/dm-bio-list.h: In bio_list_:
include/linux/raid/../../../drivers/md/dm-bio-list.h:90: error: dereferencing pointer to incomplete type
include/linux/raid/../../../drivers/md/dm-bio-list.h:94: error: dereferencing pointer to incomplete type
make[1]: *** [fs/compat_ioctl.o] Error 1
make: *** [fs] Error 2


So either revert that commit or better apply the attached patch to fix it.


Regards,

Andreas

--
Fix kernel compilation if CONFIG_COMPAT is selected but CONFIG_BLOCK is not.
This is needed due to commit

    02a5e0acb3cb85d80d0fe834e366d38a92bbaa22

Signed-off-by: Andreas Herrmann <aherrman@arcor.de>
---
 drivers/md/dm-bio-list.h |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/md/dm-bio-list.h b/drivers/md/dm-bio-list.h
index 16ee3b0..3f7b827 100644
--- a/drivers/md/dm-bio-list.h
+++ b/drivers/md/dm-bio-list.h
@@ -9,6 +9,8 @@
 
 #include <linux/bio.h>
 
+#ifdef CONFIG_BLOCK
+
 struct bio_list {
 	struct bio *head;
 	struct bio *tail;
@@ -106,4 +108,5 @@ static inline struct bio *bio_list_get(struct bio_list *bl)
 	return bio;
 }
 
+#endif /* CONFIG_BLOCK */
 #endif
-- 
1.5.3


-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
Commit 02a5e0acb3cb85d80d0fe834e366d38a92bbaa22 might break ..., , (Thu Sep 13, 7:28 pm)
Re: Commit 02a5e0acb3cb85d80d0fe834e366d38a92bbaa22 might br..., David Howells, (Thu Sep 13, 8:53 pm)